From patchwork Sun Jul 17 12:42:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= X-Patchwork-Id: 12920524 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6DA7CCA47B for ; Sun, 17 Jul 2022 12:44:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RkgbkmvN9m4LGaYCqS/OsqcXwKLn7wAWHo6cEPadraA=; b=Lrlsl+Jl4bwy2O /9RZK8knyGZi6sos0hTIKSqGO5AlOa5L2yPpDi4+XLkCcC1pJT35+XAoO4KgngL0y37f+JQdCdQH3 dxyhGL3ltszvaELGw8n+j204cg6bbMdgcUrVohzLFl/lMyGL5OBzi1UUyYaX6azdIo0LCPbv/ufdG JB2Sdbe5vx01repc7KZbDlgNKW7IyDP6bKiBJAATnUeU/5lLQ5XBRXoReaqZ/iwHGvtUvuRCWVZiu 6bao0ia78e1emcic0ANoxB/rjjGmD8uQnvBRzwvU3TuwiIzeaHySNrNR1W9Lg7tdLeMO3oBkysYlF 9ocFYVJ8hM1mgEsyrlZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oD3cL-006oYx-0w; Sun, 17 Jul 2022 12:43:25 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oD3c3-006oQk-7v for linux-arm-kernel@lists.infradead.org; Sun, 17 Jul 2022 12:43:08 +0000 Received: by mail-ej1-x634.google.com with SMTP id sz17so16743868ejc.9 for ; Sun, 17 Jul 2022 05:43:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YYzoacsZMoWFZstDTYaMwcaR8lS9+roWWLsiPfEpSnk=; b=e4uJUwKO+QuZiIwn6MC8rXU63K4IQnrySJmVyWBlaYif3fEz+/I8FexF02N7TDtzwA zHQmFzbKcC93LA0JZiHT89zqpF8q04j3rxXpaIvh8yselMOnEWl3fZSN7p87Top8KD+1 Ijkpgvmnde3BdhbD75TOHeFc2y+z6j7wvxTassSQY9kf7CdS/Ehe1bS7pjq5Y1B0+8VO LpEilgind89SzZKFYbSuPpOvdjAr3RejDAxvejRx6ZmfU5f+seWqjMbbArt9fgvLrH5u VIi6MJ8Eece+DJ0vZquVDkEU6XX131ME3J4wWi4FXqXoJYFmiYFUTl5MOYDL2bISl38o 8yDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YYzoacsZMoWFZstDTYaMwcaR8lS9+roWWLsiPfEpSnk=; b=uxhxgbQ+cRRDNsctrg1M5SJO2TnoDBnqNAdXB9RIL83GzSMb44uGZ78pq7nHmAIJ8s yxscWE6aDpn6KPfayel2TV80max1qSOV9ifzRCGfdrZlqEI4E1XcjdcxZCJnXG5iygvO Lov4XTVMoNqZumErUjBnUosOIhiewUPrLDe8DQKFXd2ZE3IbSm//4XCXBzpsDInkzCdI C5vH2XiQR+U90S0rUJPfwfYCzoXqdOFqaP53wnz9i+U64TBl+SBT0MXL5quqUYP5TxVG mAtkdFG4XhRbsb0Mfij6bv/SMtQJRcGI75YiVJP1qlVLxRFIHOfaZBwSnjtNnjY8OAwX JSCg== X-Gm-Message-State: AJIora91kNJUP1wXEuVF2AivFRR3ldyHPWFALUYd9tB5YkCm7m3K7dqt WItkyf6W1COLnTGBiotQJAQ= X-Google-Smtp-Source: AGRyM1sttkl1O/1N7usBItncy6DZS9ukz2ekFShxJ2xUrrGYNYHYHmSTZlR9vyWolD2P98D++QtOfA== X-Received: by 2002:a17:907:1def:b0:72b:33e6:46d6 with SMTP id og47-20020a1709071def00b0072b33e646d6mr21444035ejc.414.1658061784949; Sun, 17 Jul 2022 05:43:04 -0700 (PDT) Received: from localhost.lan (ip-194-187-74-233.konfederacka.maverick.com.pl. [194.187.74.233]) by smtp.gmail.com with ESMTPSA id i22-20020aa7c716000000b0043a64eee322sm4520588edq.28.2022.07.17.05.43.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Jul 2022 05:43:04 -0700 (PDT) From: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= To: Pavel Machek Cc: Rob Herring , Krzysztof Kozlowski , William Zhang , Anand Gore , Kursad Oney , Florian Fainelli , linux-leds@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= Subject: [PATCH 3/3] leds: leds-bcm63138: get rid of LED_OFF Date: Sun, 17 Jul 2022 14:42:48 +0200 Message-Id: <20220717124248.13562-4-zajec5@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220717124248.13562-1-zajec5@gmail.com> References: <20220717124248.13562-1-zajec5@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220717_054307_337030_0250A75C X-CRM114-Status: GOOD ( 12.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Rafał Miłecki The whole "enum led_brightness" is marked as obsolete. Replace it with a (non-)zero check. Reported-by: Pavel Machek Signed-off-by: Rafał Miłecki --- drivers/leds/blink/leds-bcm63138.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/leds/blink/leds-bcm63138.c b/drivers/leds/blink/leds-bcm63138.c index c083cb1332cb..2cf2761e4914 100644 --- a/drivers/leds/blink/leds-bcm63138.c +++ b/drivers/leds/blink/leds-bcm63138.c @@ -113,8 +113,7 @@ static void bcm63138_leds_enable_led(struct bcm63138_leds *leds, { u32 bit = BIT(led->pin); - bcm63138_leds_update_bits(leds, BCM63138_SW_DATA, bit, - value == LED_OFF ? 0 : bit); + bcm63138_leds_update_bits(leds, BCM63138_SW_DATA, bit, value ? bit : 0); } /*