From patchwork Thu Jul 21 04:36:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kepplinger X-Patchwork-Id: 12924710 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 303C8C433EF for ; Thu, 21 Jul 2022 04:38:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7hDzu7skYf81GLrvvNHWX6WcfsMwNdVObscKYXYmTy8=; b=t5ilhgRSv/RRIc JMBT9bhNhc+G1Cn7OKdn0kdnLTs3+LwDcduhOFiNozARSx9duY4Qtn3NPXHR0Zu/66J52LEfQzxfF XFwqkksi398B7hUoGNr3NNo0gIWpAQLhupOYmon01DxPPxPWmQtsKqlNV2C66rQZZZbC7KvyN/6nN f34rRk/Bo2SfCmGVAKbjLCTM8O9SeVj4celV2sQGNYVgsaom6jj3EZmjndU5VLeWL8s8YCgkXOExd 7a/BgjhKPStLFBDrw0ATH12SJt02QxCLOigynCPRgEQHQMyRaDYBU5AnrdYwk3aZXenCMSJ+DpUCp YGeq80aGM/BexU2aIBbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oENvm-00GajW-IH; Thu, 21 Jul 2022 04:36:58 +0000 Received: from comms.puri.sm ([159.203.221.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oENvi-00GaeR-Qo for linux-arm-kernel@lists.infradead.org; Thu, 21 Jul 2022 04:36:56 +0000 Received: from localhost (localhost [127.0.0.1]) by comms.puri.sm (Postfix) with ESMTP id 21313DFFAD; Wed, 20 Jul 2022 21:36:53 -0700 (PDT) Received: from comms.puri.sm ([127.0.0.1]) by localhost (comms.puri.sm [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vyK_ybaBOpjU; Wed, 20 Jul 2022 21:36:52 -0700 (PDT) From: Martin Kepplinger DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=puri.sm; s=comms; t=1658378212; bh=o2yNLa0wPhFYr2u615+caHpTvHnlqkg5x/WICPzNwHg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TKLiY3KYJp6SfK/XDJMjbqm57vNeK7RNTyd5kWkSlWBf89ZB+3CmoLs0+pBMsq6v4 kZ/FEYHs1n9TZmE4zLKAOV4uxkDXEY3JrzGr7hfWxjnlpcl4Q21dOyOVfESxIXMjjj IjhM9PueBCtHJtm+sWiYdpSS3c0nafOVd0kf5TZeLXPHAr1rUVoS4bM/gEU3a6oDQs /r7NsAQ0nXY93YJOY+EI0a+vap8cH4GyuewhyRYdhAtuH/qv27dOiOkepmUyKi5asL l1bVpCLkq9T9zMfnTjP1F3b529pukxLh9L4KCbB3L+oe3NSeyii8cTnhc/CrClbIrC ijQgFgkutvHkw== To: rafael@kernel.org, khilman@kernel.org, ulf.hansson@linaro.org, robh@kernel.org, krzysztof.kozlowski@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, pavel@ucw.cz Cc: kernel@puri.sm, linux-imx@nxp.com, broonie@kernel.org, l.stach@pengutronix.de, aford173@gmail.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Martin Kepplinger Subject: [PATCH v5 2/3] power: domain: handle genpd correctly when needing interrupts Date: Thu, 21 Jul 2022 06:36:07 +0200 Message-Id: <20220721043608.1527686-3-martin.kepplinger@puri.sm> In-Reply-To: <20220721043608.1527686-1-martin.kepplinger@puri.sm> References: <20220721043608.1527686-1-martin.kepplinger@puri.sm> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220720_213654_891688_462E46CF X-CRM114-Status: GOOD ( 15.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org If for example the power-domains' power-supply node (regulator) needs interrupts to work, the current setup with noirq callbacks cannot work; for example a pmic regulator on i2c, when suspending, usually already times out during suspend_noirq: [ 41.024193] buck4: failed to disable: -ETIMEDOUT So fix system suspend and resume for these power-domains by using the "outer" suspend/resume callbacks instead. Tested on the imx8mq-librem5 board, but by looking at the dts, this will fix imx8mq-evk and possibly many other boards too. This is designed so that genpd providers just say "this genpd needs interrupts" (by setting the flag) - without implying an implementation. Initially system suspend problems had been discussed at https://lore.kernel.org/linux-arm-kernel/20211002005954.1367653-8-l.stach@pengutronix.de/ which led to discussing the pmic that contains the regulators which serve as power-domain power-supplies: https://lore.kernel.org/linux-pm/573166b75e524517782471c2b7f96e03fd93d175.camel@puri.sm/T/ Signed-off-by: Martin Kepplinger --- drivers/base/power/domain.c | 13 +++++++++++++ include/linux/pm_domain.h | 5 +++++ 2 files changed, 18 insertions(+) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 5a2e0232862e..ef77700e0def 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -130,6 +130,7 @@ static const struct genpd_lock_ops genpd_spin_ops = { #define genpd_is_active_wakeup(genpd) (genpd->flags & GENPD_FLAG_ACTIVE_WAKEUP) #define genpd_is_cpu_domain(genpd) (genpd->flags & GENPD_FLAG_CPU_DOMAIN) #define genpd_is_rpm_always_on(genpd) (genpd->flags & GENPD_FLAG_RPM_ALWAYS_ON) +#define genpd_irq_on(genpd) (genpd->flags & GENPD_FLAG_IRQ_ON) static inline bool irq_safe_dev_in_sleep_domain(struct device *dev, const struct generic_pm_domain *genpd) @@ -2079,6 +2080,13 @@ int pm_genpd_init(struct generic_pm_domain *genpd, genpd->dev_ops.start = pm_clk_resume; } + if (genpd_irq_on(genpd)) { + genpd->domain.ops.suspend = genpd_suspend_noirq; + genpd->domain.ops.resume = genpd_resume_noirq; + genpd->domain.ops.suspend_noirq = NULL; + genpd->domain.ops.resume_noirq = NULL; + } + /* The always-on governor works better with the corresponding flag. */ if (gov == &pm_domain_always_on_gov) genpd->flags |= GENPD_FLAG_RPM_ALWAYS_ON; @@ -2769,6 +2777,11 @@ static int __genpd_dev_pm_attach(struct device *dev, struct device *base_dev, goto err; dev_gpd_data(dev)->default_pstate = pstate; } + + if (pd->domain.ops.suspend_noirq && (pd->flags & GENPD_FLAG_IRQ_ON)) + dev_err(dev, "PM domain %s needs irqs but uses noirq suspend\n", + pd->name); + return 1; err: diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h index 76bc9e3ef5ff..03bb86e43550 100644 --- a/include/linux/pm_domain.h +++ b/include/linux/pm_domain.h @@ -61,6 +61,10 @@ * GENPD_FLAG_MIN_RESIDENCY: Enable the genpd governor to consider its * components' next wakeup when determining the * optimal idle state. + * + * GENPD_FLAG_IRQ_ON: genpd needs irqs to be able to manage power + * on/off. Use the outer suspend/resume callbacks + * instead of noirq for example. */ #define GENPD_FLAG_PM_CLK BIT(0) #define GENPD_FLAG_IRQ_SAFE BIT(1) @@ -69,6 +73,7 @@ #define GENPD_FLAG_CPU_DOMAIN BIT(4) #define GENPD_FLAG_RPM_ALWAYS_ON BIT(5) #define GENPD_FLAG_MIN_RESIDENCY BIT(6) +#define GENPD_FLAG_IRQ_ON BIT(7) enum gpd_status { GENPD_STATE_ON = 0, /* PM domain is on */