| Message ID | 20220721043608.1527686-4-martin.kepplinger@puri.sm (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | power: domain: handle power supplies that need interrupts | expand |
Am Donnerstag, dem 21.07.2022 um 06:36 +0200 schrieb Martin Kepplinger: > For boards that use power-domains' power-supplies that need interrupts > to work (like regulator over i2c), set GENPD_FLAG_IRQ_ON. > This will tell genpd to adjust accordingly. Currently it "only" sets the > correct suspend/resume callbacks. > > This fixes suspend/resume on imx8mq-librem5 boards (tested) and > imx8mq-evk (by looking at dts) and possibly more. > > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> > --- > drivers/soc/imx/gpcv2.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c > index 6383a4edc360..e058aed76602 100644 > --- a/drivers/soc/imx/gpcv2.c > +++ b/drivers/soc/imx/gpcv2.c > @@ -1337,6 +1337,9 @@ static int imx_pgc_domain_probe(struct platform_device *pdev) > regmap_update_bits(domain->regmap, domain->regs->map, > domain->bits.map, domain->bits.map); > > + if (of_parse_phandle(domain->dev->of_node, "power-supply", 0)) We don't actually need to parse the phandle. For a simple presence check of_property_read_bool() is enough. Regards, Lucas > + domain->genpd.flags |= GENPD_FLAG_IRQ_ON; > + > ret = pm_genpd_init(&domain->genpd, NULL, true); > if (ret) { > dev_err(domain->dev, "Failed to init power domain\n");
diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c index 6383a4edc360..e058aed76602 100644 --- a/drivers/soc/imx/gpcv2.c +++ b/drivers/soc/imx/gpcv2.c @@ -1337,6 +1337,9 @@ static int imx_pgc_domain_probe(struct platform_device *pdev) regmap_update_bits(domain->regmap, domain->regs->map, domain->bits.map, domain->bits.map); + if (of_parse_phandle(domain->dev->of_node, "power-supply", 0)) + domain->genpd.flags |= GENPD_FLAG_IRQ_ON; + ret = pm_genpd_init(&domain->genpd, NULL, true); if (ret) { dev_err(domain->dev, "Failed to init power domain\n");
For boards that use power-domains' power-supplies that need interrupts to work (like regulator over i2c), set GENPD_FLAG_IRQ_ON. This will tell genpd to adjust accordingly. Currently it "only" sets the correct suspend/resume callbacks. This fixes suspend/resume on imx8mq-librem5 boards (tested) and imx8mq-evk (by looking at dts) and possibly more. Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> --- drivers/soc/imx/gpcv2.c | 3 +++ 1 file changed, 3 insertions(+)