From patchwork Thu Sep 22 14:25:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 12985333 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1051C6FA82 for ; Thu, 22 Sep 2022 14:40:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cewi+4xwmvc0oWRMANPEQeJ0OfYBrSjhAgjW0YVcIJw=; b=W0N1rQtxBm+j+r /MUck3LFHUmP+Mcdcmo4UGbaREie05NfJ4GvalLZKgtWLfUAh7sPQdcrKFGAZtNx0FLt0+uR4WUxg fpLJSJMhVTQunkI5yL3ngZRbUNxcJx28Ve/SReCIbLMvvjlPUtLw5EMXE0One5JgfDBfJnUNVG1Ww aH+4FXa9p31CKRkJUkZTV3/IgqFEDXz7zHfDKt6IBZ7YkXfIHWrrNrCZiwvQ199fX/h7axXklb77m qiHldFjGQA9vRykh7IGTRXd+t5bRm4xD3N5/FYTJkAeMwc2iONNSQYeRWploLClcoJQtlQeSrwSXn 9vP1uPy0TRh5y7pFx9fg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1obNMH-00G6ZH-HC; Thu, 22 Sep 2022 14:39:22 +0000 Received: from wnew4-smtp.messagingengine.com ([64.147.123.18]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1obNAf-00G0vU-Gs for linux-arm-kernel@lists.infradead.org; Thu, 22 Sep 2022 14:27:23 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.west.internal (Postfix) with ESMTP id 1A2BD2B05B27; Thu, 22 Sep 2022 10:27:18 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 22 Sep 2022 10:27:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1663856837; x= 1663864037; bh=53LrYaV2mhomt8gRf9sphcJoUtcRBSDR3JTPJr8moaA=; b=A RfK4qb1MbOftPljiajcc1DgnXc2Gbe3U2NFvXlECK7XzZ44M4e5LvcGYLvzWUIeu 2e2GllkQc0O+UwbAUOXMPjfhQ4w0AlzMyKGuKZbzwsmz8gHhahQfBt/+1KnS278d dv2MFn2udCgjq1tWrY3POLRPPwVkcZG262jfAWfvx1koAMawwwBhSy1HugslD3D2 ScBeN5EzPHdrA1YdPEeOYttU4AblPe44x915+dYbflSVmYUjzuTDrGRoUltFdcZL joBVxdI5M81oAS3o26N0NMyeDKYzNhOhDmQIQPjvxmtedHaLN1Rn7CmdZ52aMQ3j Oz3nQlrZ5vFeH3JEFiRDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1663856837; x= 1663864037; bh=53LrYaV2mhomt8gRf9sphcJoUtcRBSDR3JTPJr8moaA=; b=M /3o+KIhg/f0A5/9Ekdl9jajH+LZLDS7nQXhvz9zqZpW3Ln68K7tGy5i0gCpFjf0l IOc0Z6Ptp8T28GQlG6boNtZOo88/vjdCOtoLtrwzdSTLmf9rx5cHjhAFhtL4Orc9 EmdOnfN7YK2YBExJTbAf3Qy5xEMP8xd4iQm0X9PHLmfAraolnUXx2FW6WpzWk1cD mPW/oh62fg5qf+a2GTulRKXnp6x0FD8n2YRKYUupNw2nmTC0Ugfg45bAkTIK3WHE Axuyp3Ag81L6tn+BBJpQ0wUHVOPd868jtExtvnR7BYIfwDes10aAZESt6ar1ByFe drGMOfZvbPI/GnWLaSpTQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeefgedgudejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephfffufggtgfgkfhfjgfvvefosehtkeertdertdejnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepudduudfhveejteefgedvffdvvedvjedugedukeejhedtlefhffevtefh jeeltdevnecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 22 Sep 2022 10:27:16 -0400 (EDT) From: Maxime Ripard Date: Thu, 22 Sep 2022 16:25:32 +0200 Subject: [PATCH v2 15/33] drm/modes: Bail out of named mode parsing if empty MIME-Version: 1.0 Message-Id: <20220728-rpi-analog-tv-properties-v2-15-f733a0ed9f90@cerno.tech> References: <20220728-rpi-analog-tv-properties-v2-0-f733a0ed9f90@cerno.tech> In-Reply-To: <20220728-rpi-analog-tv-properties-v2-0-f733a0ed9f90@cerno.tech> To: Jernej Skrabec , Rodrigo Vivi , Ben Skeggs , David Airlie , Maxime Ripard , Joonas Lahtinen , Emma Anholt , Karol Herbst , Samuel Holland , Jani Nikula , Thomas Zimmermann , Daniel Vetter , Lyude Paul , Maarten Lankhorst , Tvrtko Ursulin , Chen-Yu Tsai Cc: =?unknown-8bit?q?Hans_de_Goede_=3Chdegoede=40redhat=2Ecom=3E=2C_nouveau?= =?unknown-8bit?q?=40lists=2Efreedesktop=2Eorg=2C_Geert_Uytterhoeven_=3Cgeer?= =?unknown-8bit?q?t=40linux-m68k=2Eorg=3E=2C?= =?unknown-8bit?q?_Dave_Stevenson_=3Cdave=2Estevenson=40raspberrypi=2Ecom=3E?= =?unknown-8bit?q?=2C_linux-kernel=40vger=2Ekernel=2Eorg=2C_linux-arm-kernel?= =?unknown-8bit?q?=40lists=2Einfradead=2Eorg=2C?= =?unknown-8bit?q?_Phil_Elwell_=3Cphil=40raspberrypi=2Ecom=3E=2C_intel-gfx=40?= =?unknown-8bit?q?lists=2Efreedesktop=2Eorg=2C_Noralf_Tr=C3=B8nnes_=3Cnoralf?= =?unknown-8bit?q?=40tronnes=2Eorg=3E=2C?= =?unknown-8bit?q?_Dom_Cobley_=3Cdom=40raspberrypi=2Ecom=3E=2C_linux-sunxi=40?= =?unknown-8bit?q?lists=2Elinux=2Edev=2C_Maxime_Ripard_=3Cmaxime=40cerno=2Et?= =?unknown-8bit?q?ech=3E=2C?= =?unknown-8bit?q?_Mateusz_Kwiatkowski_=3Ckfyatek+publicgit=40gmail=2Ecom=3E?= =?unknown-8bit?q?=2C_dri-devel=40lists=2Efreedesktop=2Eorg?= X-Mailer: b4 0.10.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=672; i=maxime@cerno.tech; h=from:subject:message-id; bh=LKwTlWbGSe8b9P99h7leZiXJ3B6Avu2KKY+GOK8gNk0=; b=owGbwMvMwCX2+D1vfrpE4FHG02pJDMk6BQGqpWo/719bl6wawfHuyaMrYf8mvLlTp17f8Mz13rPn 0+Yc6ChlYRDjYpAVU2SJETZfEndq1utONr55MHNYmUCGMHBxCsBEDt5k+GcQJHfBb7Z8itrPYLmjqz Kvu78x5z8iJdEvetmxZObUplOMDGftxN/+b7eSs2hS1S2Onnn3afbhZf8NjW6rTb6akyc6jQ8A X-Developer-Key: i=maxime@cerno.tech; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220922_072721_660396_43F8F094 X-CRM114-Status: UNSURE ( 9.65 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org If the name we want to parse has a length of zero, there's no need to compare it to the list of all the named modes we support, we can return straight away. Signed-off-by: Maxime Ripard diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c index b1e800e4ed60..8d629fbb1047 100644 --- a/drivers/gpu/drm/drm_modes.c +++ b/drivers/gpu/drm/drm_modes.c @@ -2235,6 +2235,9 @@ static int drm_mode_parse_cmdline_named_mode(const char *name, { unsigned int i; + if (!name_end) + return 0; + /* * We're sure we're a named mode at that point, iterate over the * list of modes we're aware of.