| Message ID | 20220731174726.72631-3-jagan@edgeble.ai (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: Add Rockchip RV1126 support | expand |
On 31/07/2022 19:47, Jagan Teki wrote: > Add power-domain header for RV1126 SoC from description in TRM. > > Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com> > Signed-off-by: Jagan Teki <jagan@edgeble.ai> > --- > Changes for v2: > - add blank line > > include/dt-bindings/power/rv1126-power.h | 35 ++++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > create mode 100644 include/dt-bindings/power/rv1126-power.h > > diff --git a/include/dt-bindings/power/rv1126-power.h b/include/dt-bindings/power/rv1126-power.h Vendor in filename is needed. > new file mode 100644 > index 000000000000..38a68e000d38 > --- /dev/null > +++ b/include/dt-bindings/power/rv1126-power.h > @@ -0,0 +1,35 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ Dual license, please, unless some copyrights are no allowing this. Best regards, Krzysztof
On Tue, 2 Aug 2022 at 16:08, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 31/07/2022 19:47, Jagan Teki wrote: > > Add power-domain header for RV1126 SoC from description in TRM. > > > > Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com> > > Signed-off-by: Jagan Teki <jagan@edgeble.ai> > > --- > > Changes for v2: > > - add blank line > > > > include/dt-bindings/power/rv1126-power.h | 35 ++++++++++++++++++++++++ > > 1 file changed, 35 insertions(+) > > create mode 100644 include/dt-bindings/power/rv1126-power.h > > > > diff --git a/include/dt-bindings/power/rv1126-power.h b/include/dt-bindings/power/rv1126-power.h > > Vendor in filename is needed. Yes this follows how similar rockchip vendor notation $ ls include/dt-bindings/power/rk3* -l include/dt-bindings/power/rk3036-power.h include/dt-bindings/power/rk3066-power.h include/dt-bindings/power/rk3128-power.h include/dt-bindings/power/rk3188-power.h include/dt-bindings/power/rk3228-power.h include/dt-bindings/power/rk3288-power.h include/dt-bindings/power/rk3328-power.h include/dt-bindings/power/rk3366-power.h include/dt-bindings/power/rk3368-power.h include/dt-bindings/power/rk3399-power.h include/dt-bindings/power/rk3568-power.h > > > new file mode 100644 > > index 000000000000..38a68e000d38 > > --- /dev/null > > +++ b/include/dt-bindings/power/rv1126-power.h > > @@ -0,0 +1,35 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > Dual license, please, unless some copyrights are no allowing this. Yes, as we discussed in v1 - I'm not liable to change so I keep this as it is. Jagan.
On 03/08/2022 12:24, Jagan Teki wrote: >> Vendor in filename is needed. > > Yes this follows how similar rockchip vendor notation > > $ ls include/dt-bindings/power/rk3* -l > include/dt-bindings/power/rk3036-power.h > include/dt-bindings/power/rk3066-power.h > include/dt-bindings/power/rk3128-power.h > include/dt-bindings/power/rk3188-power.h > include/dt-bindings/power/rk3228-power.h > include/dt-bindings/power/rk3288-power.h > include/dt-bindings/power/rk3328-power.h > include/dt-bindings/power/rk3366-power.h > include/dt-bindings/power/rk3368-power.h > include/dt-bindings/power/rk3399-power.h > include/dt-bindings/power/rk3568-power.h So when are we going to switch to vendor,device pattern if you keep adding files with wrong naming? > >> >>> new file mode 100644 >>> index 000000000000..38a68e000d38 >>> --- /dev/null >>> +++ b/include/dt-bindings/power/rv1126-power.h >>> @@ -0,0 +1,35 @@ >>> +/* SPDX-License-Identifier: GPL-2.0 */ >> >> Dual license, please, unless some copyrights are no allowing this. > > Yes, as we discussed in v1 - I'm not liable to change so I keep this as it is. OK Best regards, Krzysztof
On Wed, 3 Aug 2022 at 16:13, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 03/08/2022 12:24, Jagan Teki wrote: > >> Vendor in filename is needed. > > > > Yes this follows how similar rockchip vendor notation > > > > $ ls include/dt-bindings/power/rk3* -l > > include/dt-bindings/power/rk3036-power.h > > include/dt-bindings/power/rk3066-power.h > > include/dt-bindings/power/rk3128-power.h > > include/dt-bindings/power/rk3188-power.h > > include/dt-bindings/power/rk3228-power.h > > include/dt-bindings/power/rk3288-power.h > > include/dt-bindings/power/rk3328-power.h > > include/dt-bindings/power/rk3366-power.h > > include/dt-bindings/power/rk3368-power.h > > include/dt-bindings/power/rk3399-power.h > > include/dt-bindings/power/rk3568-power.h > > > So when are we going to switch to vendor,device pattern if you keep > adding files with wrong naming? Do you mean the above files are following the wrong naming pattern? Jagan.
On 03/08/2022 12:46, Jagan Teki wrote: > On Wed, 3 Aug 2022 at 16:13, Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> On 03/08/2022 12:24, Jagan Teki wrote: >>>> Vendor in filename is needed. >>> >>> Yes this follows how similar rockchip vendor notation >>> >>> $ ls include/dt-bindings/power/rk3* -l >>> include/dt-bindings/power/rk3036-power.h >>> include/dt-bindings/power/rk3066-power.h >>> include/dt-bindings/power/rk3128-power.h >>> include/dt-bindings/power/rk3188-power.h >>> include/dt-bindings/power/rk3228-power.h >>> include/dt-bindings/power/rk3288-power.h >>> include/dt-bindings/power/rk3328-power.h >>> include/dt-bindings/power/rk3366-power.h >>> include/dt-bindings/power/rk3368-power.h >>> include/dt-bindings/power/rk3399-power.h >>> include/dt-bindings/power/rk3568-power.h >> >> >> So when are we going to switch to vendor,device pattern if you keep >> adding files with wrong naming? > > Do you mean the above files are following the wrong naming pattern? Yes, or at least discouraged naming. The recommended naming which I hope all new files will follow are vendor,device.h. Best regards, Krzysztof
On Wed, 3 Aug 2022 at 16:57, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 03/08/2022 12:46, Jagan Teki wrote: > > On Wed, 3 Aug 2022 at 16:13, Krzysztof Kozlowski > > <krzysztof.kozlowski@linaro.org> wrote: > >> > >> On 03/08/2022 12:24, Jagan Teki wrote: > >>>> Vendor in filename is needed. > >>> > >>> Yes this follows how similar rockchip vendor notation > >>> > >>> $ ls include/dt-bindings/power/rk3* -l > >>> include/dt-bindings/power/rk3036-power.h > >>> include/dt-bindings/power/rk3066-power.h > >>> include/dt-bindings/power/rk3128-power.h > >>> include/dt-bindings/power/rk3188-power.h > >>> include/dt-bindings/power/rk3228-power.h > >>> include/dt-bindings/power/rk3288-power.h > >>> include/dt-bindings/power/rk3328-power.h > >>> include/dt-bindings/power/rk3366-power.h > >>> include/dt-bindings/power/rk3368-power.h > >>> include/dt-bindings/power/rk3399-power.h > >>> include/dt-bindings/power/rk3568-power.h > >> > >> > >> So when are we going to switch to vendor,device pattern if you keep > >> adding files with wrong naming? > > > > Do you mean the above files are following the wrong naming pattern? > > Yes, or at least discouraged naming. The recommended naming which I hope > all new files will follow are vendor,device.h. rockchip-rv1126-power.h Will this be Okay? Thanks, Jagan.
On 03/08/2022 13:30, Jagan Teki wrote: > On Wed, 3 Aug 2022 at 16:57, Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> On 03/08/2022 12:46, Jagan Teki wrote: >>> On Wed, 3 Aug 2022 at 16:13, Krzysztof Kozlowski >>> <krzysztof.kozlowski@linaro.org> wrote: >>>> >>>> On 03/08/2022 12:24, Jagan Teki wrote: >>>>>> Vendor in filename is needed. >>>>> >>>>> Yes this follows how similar rockchip vendor notation >>>>> >>>>> $ ls include/dt-bindings/power/rk3* -l >>>>> include/dt-bindings/power/rk3036-power.h >>>>> include/dt-bindings/power/rk3066-power.h >>>>> include/dt-bindings/power/rk3128-power.h >>>>> include/dt-bindings/power/rk3188-power.h >>>>> include/dt-bindings/power/rk3228-power.h >>>>> include/dt-bindings/power/rk3288-power.h >>>>> include/dt-bindings/power/rk3328-power.h >>>>> include/dt-bindings/power/rk3366-power.h >>>>> include/dt-bindings/power/rk3368-power.h >>>>> include/dt-bindings/power/rk3399-power.h >>>>> include/dt-bindings/power/rk3568-power.h >>>> >>>> >>>> So when are we going to switch to vendor,device pattern if you keep >>>> adding files with wrong naming? >>> >>> Do you mean the above files are following the wrong naming pattern? >> >> Yes, or at least discouraged naming. The recommended naming which I hope >> all new files will follow are vendor,device.h. > > rockchip-rv1126-power.h > > Will this be Okay? After vendor prefix goes coma, so rockchip,rv1126-power.h Best regards, Krzysztof
On Wed, 3 Aug 2022 at 17:09, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 03/08/2022 13:30, Jagan Teki wrote: > > On Wed, 3 Aug 2022 at 16:57, Krzysztof Kozlowski > > <krzysztof.kozlowski@linaro.org> wrote: > >> > >> On 03/08/2022 12:46, Jagan Teki wrote: > >>> On Wed, 3 Aug 2022 at 16:13, Krzysztof Kozlowski > >>> <krzysztof.kozlowski@linaro.org> wrote: > >>>> > >>>> On 03/08/2022 12:24, Jagan Teki wrote: > >>>>>> Vendor in filename is needed. > >>>>> > >>>>> Yes this follows how similar rockchip vendor notation > >>>>> > >>>>> $ ls include/dt-bindings/power/rk3* -l > >>>>> include/dt-bindings/power/rk3036-power.h > >>>>> include/dt-bindings/power/rk3066-power.h > >>>>> include/dt-bindings/power/rk3128-power.h > >>>>> include/dt-bindings/power/rk3188-power.h > >>>>> include/dt-bindings/power/rk3228-power.h > >>>>> include/dt-bindings/power/rk3288-power.h > >>>>> include/dt-bindings/power/rk3328-power.h > >>>>> include/dt-bindings/power/rk3366-power.h > >>>>> include/dt-bindings/power/rk3368-power.h > >>>>> include/dt-bindings/power/rk3399-power.h > >>>>> include/dt-bindings/power/rk3568-power.h > >>>> > >>>> > >>>> So when are we going to switch to vendor,device pattern if you keep > >>>> adding files with wrong naming? > >>> > >>> Do you mean the above files are following the wrong naming pattern? > >> > >> Yes, or at least discouraged naming. The recommended naming which I hope > >> all new files will follow are vendor,device.h. > > > > rockchip-rv1126-power.h > > > > Will this be Okay? > > After vendor prefix goes coma, so rockchip,rv1126-power.h Thanks. I will fix it in v3. Jagan.
On Wed, Aug 03, 2022 at 03:54:56PM +0530, Jagan Teki wrote: > On Tue, 2 Aug 2022 at 16:08, Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: > > > > On 31/07/2022 19:47, Jagan Teki wrote: > > > Add power-domain header for RV1126 SoC from description in TRM. > > > > > > Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com> > > > Signed-off-by: Jagan Teki <jagan@edgeble.ai> > > > --- > > > Changes for v2: > > > - add blank line > > > > > > include/dt-bindings/power/rv1126-power.h | 35 ++++++++++++++++++++++++ > > > 1 file changed, 35 insertions(+) > > > create mode 100644 include/dt-bindings/power/rv1126-power.h > > > > > > diff --git a/include/dt-bindings/power/rv1126-power.h b/include/dt-bindings/power/rv1126-power.h > > > > Vendor in filename is needed. > > Yes this follows how similar rockchip vendor notation > > $ ls include/dt-bindings/power/rk3* -l > include/dt-bindings/power/rk3036-power.h > include/dt-bindings/power/rk3066-power.h > include/dt-bindings/power/rk3128-power.h > include/dt-bindings/power/rk3188-power.h > include/dt-bindings/power/rk3228-power.h > include/dt-bindings/power/rk3288-power.h > include/dt-bindings/power/rk3328-power.h > include/dt-bindings/power/rk3366-power.h > include/dt-bindings/power/rk3368-power.h > include/dt-bindings/power/rk3399-power.h > include/dt-bindings/power/rk3568-power.h > > > > > > new file mode 100644 > > > index 000000000000..38a68e000d38 > > > --- /dev/null > > > +++ b/include/dt-bindings/power/rv1126-power.h > > > @@ -0,0 +1,35 @@ > > > +/* SPDX-License-Identifier: GPL-2.0 */ > > > > Dual license, please, unless some copyrights are no allowing this. > > Yes, as we discussed in v1 - I'm not liable to change so I keep this as it is. I assume that would be Rockchip. Can someone from Rockchip please give an okay here to dual license? Rob
On Thu, 4 Aug 2022 at 04:03, Rob Herring <robh@kernel.org> wrote: > > On Wed, Aug 03, 2022 at 03:54:56PM +0530, Jagan Teki wrote: > > On Tue, 2 Aug 2022 at 16:08, Krzysztof Kozlowski > > <krzysztof.kozlowski@linaro.org> wrote: > > > > > > On 31/07/2022 19:47, Jagan Teki wrote: > > > > Add power-domain header for RV1126 SoC from description in TRM. > > > > > > > > Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com> > > > > Signed-off-by: Jagan Teki <jagan@edgeble.ai> > > > > --- > > > > Changes for v2: > > > > - add blank line > > > > > > > > include/dt-bindings/power/rv1126-power.h | 35 ++++++++++++++++++++++++ > > > > 1 file changed, 35 insertions(+) > > > > create mode 100644 include/dt-bindings/power/rv1126-power.h > > > > > > > > diff --git a/include/dt-bindings/power/rv1126-power.h b/include/dt-bindings/power/rv1126-power.h > > > > > > Vendor in filename is needed. > > > > Yes this follows how similar rockchip vendor notation > > > > $ ls include/dt-bindings/power/rk3* -l > > include/dt-bindings/power/rk3036-power.h > > include/dt-bindings/power/rk3066-power.h > > include/dt-bindings/power/rk3128-power.h > > include/dt-bindings/power/rk3188-power.h > > include/dt-bindings/power/rk3228-power.h > > include/dt-bindings/power/rk3288-power.h > > include/dt-bindings/power/rk3328-power.h > > include/dt-bindings/power/rk3366-power.h > > include/dt-bindings/power/rk3368-power.h > > include/dt-bindings/power/rk3399-power.h > > include/dt-bindings/power/rk3568-power.h > > > > > > > > > new file mode 100644 > > > > index 000000000000..38a68e000d38 > > > > --- /dev/null > > > > +++ b/include/dt-bindings/power/rv1126-power.h > > > > @@ -0,0 +1,35 @@ > > > > +/* SPDX-License-Identifier: GPL-2.0 */ > > > > > > Dual license, please, unless some copyrights are no allowing this. > > > > Yes, as we discussed in v1 - I'm not liable to change so I keep this as it is. > > I assume that would be Rockchip. Can someone from Rockchip please give > an okay here to dual license? Kever or Heiko - any comments on this? Thanks, Jagan.
diff --git a/include/dt-bindings/power/rv1126-power.h b/include/dt-bindings/power/rv1126-power.h new file mode 100644 index 000000000000..38a68e000d38 --- /dev/null +++ b/include/dt-bindings/power/rv1126-power.h @@ -0,0 +1,35 @@ +/* SPDX-License-Identifier: GPL-2.0 */ + +#ifndef __DT_BINDINGS_POWER_RV1126_POWER_H__ +#define __DT_BINDINGS_POWER_RV1126_POWER_H__ + +/* VD_CORE */ +#define RV1126_PD_CPU_0 0 +#define RV1126_PD_CPU_1 1 +#define RV1126_PD_CPU_2 2 +#define RV1126_PD_CPU_3 3 +#define RV1126_PD_CORE_ALIVE 4 + +/* VD_PMU */ +#define RV1126_PD_PMU 5 +#define RV1126_PD_PMU_ALIVE 6 + +/* VD_NPU */ +#define RV1126_PD_NPU 7 + +/* VD_VEPU */ +#define RV1126_PD_VEPU 8 + +/* VD_LOGIC */ +#define RV1126_PD_VI 9 +#define RV1126_PD_VO 10 +#define RV1126_PD_ISPP 11 +#define RV1126_PD_VDPU 12 +#define RV1126_PD_CRYPTO 13 +#define RV1126_PD_DDR 14 +#define RV1126_PD_NVM 15 +#define RV1126_PD_SDIO 16 +#define RV1126_PD_USB 17 +#define RV1126_PD_LOGIC_ALIVE 18 + +#endif