From patchwork Wed Aug 3 19:12:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bhupesh Sharma X-Patchwork-Id: 12935858 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18A2CC19F28 for ; Wed, 3 Aug 2022 19:14:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=grtaDwok2ZYgqBn6kz40eDb5amdPTqfJe8Dj04++WKA=; b=eocVd7AIPZJlPV rLs4A9CHya2c+HG6suJgY29dS6nr0BxPPYbdrxb4kdxjEDQxhogE46PXxZ63sacehyE6I/sSmCKG6 WPqi1CW7s+wnO0giEg/FiagKQh6H5g6bQwaktYHifEUlTkD6AwoqrHwpxxK5UxXRtVNNHfu4H+Upt nn8sZ21F1g4Z/LXX6W17fUI+FZdo/EgzEhWQSsFrzTwaOoAiwi1EhLRCjsSuop6Ko/giibWNFXej+ uKXBmaV+hRXQSHTxYRdXuI1zqnk/v1IvS+DO3uLsrQE35llxivCC+HVkbgR76aKVE19EiD1PxrpN4 QE0PpUGuqgljkKNpMZfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJJnh-008ksB-BD; Wed, 03 Aug 2022 19:13:01 +0000 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJJnc-008koY-1q for linux-arm-kernel@lists.infradead.org; Wed, 03 Aug 2022 19:12:58 +0000 Received: by mail-pl1-x632.google.com with SMTP id 17so1806580plj.10 for ; Wed, 03 Aug 2022 12:12:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc; bh=4zK98BC9usZ9tCVJy5TId+ZcNTpp4zIbOepI4rir8+w=; b=jefqFTwXKQxf9ICOYbWVIDyQg4yWmfjrIZmSzw/bSBZ83YTAGVnnRSeh6mOJNxCZ5g yDnFiIHRXE0f4s0Kwp9tvz4GBi5F9zihVzVEqhhu9+DEDOLhz3TIJv4XDi7MFbqir6g2 evAIYudAWhonqSxE9Ml/Xtwox+WswEwhojHLS3Osj/nk3oxZ3pX3Zn1sNNRmFno42nth 6EHSqaZ7JGpv+5T+zrriqdYmxMLuk9UdqgOcUXjHSFXv/cyOqMLaEqrIzMQlq4NsAv1z bJISEiPsEWdfj2rR/Gs84Jd2TlK+ec74LfRdkE9ZhRnAQS382UBb14kRtGGJBKuLpBDz l3lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc; bh=4zK98BC9usZ9tCVJy5TId+ZcNTpp4zIbOepI4rir8+w=; b=Q078sYUEsL04Ez4FABZIKNCbZg2flU2n4UcdNlX7+qyU0o0R7pYMb5f7YGWsXIa7ud Uk07EXU58849ivqmWQ3uKXflklEsOBqge8AlyLpO1hlab8gHziLyhEvraI61uID8qYPW eUNjYvZ7vYGvHe2ioSVfIC/k4b2VVX05rJSDo2GvSTAm/ZgTQFCwQs/jswxsmhryqLZ3 gtFykedF3SLwX6DB74LaXff2po/SWl8P6WLpF3VwhTLCP24CiYwzg9KQqqHJnYytP2oK kGvoYkur+AAXjsOkCgKdBEiL19wAHVX653r6Qhv4PtuHDlKJXX96P+ShHtkavpRsAhty 428w== X-Gm-Message-State: ACgBeo3JbQa2SraBeXxvoinqr2A0yu7zyPu1CjOzsekKa/uyoWSYNAyV 8WvV0KMF79hMVOQMK+bh8VbyBQ== X-Google-Smtp-Source: AA6agR7eif7XcVJJauFJ7KJikkw8K6ljVbPKusohoOjLWeaqzENPk+57orK916Zy3RzqqeWDsMgaPA== X-Received: by 2002:a17:902:6b82:b0:16d:d268:3842 with SMTP id p2-20020a1709026b8200b0016dd2683842mr26784523plk.16.1659553973988; Wed, 03 Aug 2022 12:12:53 -0700 (PDT) Received: from localhost.localdomain ([2401:4900:1c5e:ddbf:1bd6:4443:9e5b:2aa2]) by smtp.gmail.com with ESMTPSA id a2-20020a17090a740200b001f1694dafb1sm1971285pjg.44.2022.08.03.12.12.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Aug 2022 12:12:53 -0700 (PDT) From: Bhupesh Sharma To: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org Cc: mathieu.poirier@linaro.org, suzuki.poulose@arm.com, mike.leach@linaro.org, leo.yan@linaro.org, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org, bhupesh.linux@gmail.com, Bhupesh Sharma , Greg Kroah-Hartman Subject: [PATCH] coresight: etm4x: Fix crash observed on Qcom ETM parts with 'Low power override' Date: Thu, 4 Aug 2022 00:42:36 +0530 Message-Id: <20220803191236.3037591-1-bhupesh.sharma@linaro.org> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220803_121257_036709_68931F2E X-CRM114-Status: GOOD ( 16.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Some Qualcomm ETM implementations require skipping powering up the trace unit, as the ETMs are in the same power domain as their CPU cores. Via commit 5214b563588e ("coresight: etm4x: Add support for sysreg only devices"), the setting of 'skip_power_up' flag was moved after the 'etm4_init_arch_data' function is called, whereas the flag value is itself used inside the function. This causes a crash when ETM mode 'Low-power state behavior override' is set on some Qualcomm parts. Fix the same. Fixes: 5214b563588e ("coresight: etm4x: Add support for sysreg only devices") Cc: Mike Leach Cc: Suzuki K Poulose Cc: Mathieu Poirier Cc: Greg Kroah-Hartman Signed-off-by: Bhupesh Sharma --- drivers/hwtracing/coresight/coresight-etm4x-core.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c index d39660a3e50c..cf6254b87fd5 100644 --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c @@ -1943,6 +1943,16 @@ static int etm4_probe(struct device *dev, void __iomem *base, u32 etm_pid) init_arg.csa = &desc.access; init_arg.pid = etm_pid; + /* + * Some Qualcomm implementations require skipping powering up the trace unit, + * as the ETMs are in the same power domain as their CPU cores. + * + * Since the 'skip_power_up' flag is used inside 'etm4_init_arch_data' function, + * initialize it before the function is called. + */ + if (fwnode_property_present(dev_fwnode(dev), "qcom,skip-power-up")) + drvdata->skip_power_up = true; + if (smp_call_function_single(drvdata->cpu, etm4_init_arch_data, &init_arg, 1)) dev_err(dev, "ETM arch init failed\n"); @@ -1951,8 +1961,7 @@ static int etm4_probe(struct device *dev, void __iomem *base, u32 etm_pid) return -EINVAL; /* TRCPDCR is not accessible with system instructions. */ - if (!desc.access.io_mem || - fwnode_property_present(dev_fwnode(dev), "qcom,skip-power-up")) + if (!desc.access.io_mem) drvdata->skip_power_up = true; major = ETM_ARCH_MAJOR_VERSION(drvdata->arch);