From patchwork Thu Aug 11 06:24:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Yan X-Patchwork-Id: 12941178 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BFEFCC19F2D for ; Thu, 11 Aug 2022 06:29:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/gDU0dJdCqx2I/ZvyoQGSOjsWBlxqBlx2axhIGDgObc=; b=ALbmoZKRcfj98F l8lqOsvfDsYKH5s2DMK69LV7pT8bUwBHZ8bbcg0AENgtlplifdaazGW+wKgS/l3aIDVvMoTJ0Z802 nh2UoCUIO1rbslm5xxzPMSVXesIjvYs1fGR9vb9UnlcdU3YufhmLybe9BsPwvlpTm0iIZGEu2qMfv uTIeUWiwL4r6lD0gHbLVtBhNhnmv5T/TQmAMJDAdnQkzqzW7J0Jw8Pf82TjyYJ5y2cDICoQZHNcqF KOjR385Q7ukF5DHCLep5H2rYWGWAWKb1UWWovf3fgr0gY9HFcLZBQ3lyVHoeOdz3RHbRdgaEPPwXY HIBN94qgY5yszQRYJ5pw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oM1fb-006xHF-2o; Thu, 11 Aug 2022 06:27:51 +0000 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oM1df-006s1e-BO for linux-arm-kernel@lists.infradead.org; Thu, 11 Aug 2022 06:25:52 +0000 Received: by mail-pj1-x102a.google.com with SMTP id p14-20020a17090a74ce00b001f4d04492faso4217641pjl.4 for ; Wed, 10 Aug 2022 23:25:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=KnWKrrjawRTLOiYleRgV3PDi8JFvvBPnPLiWcsRBXJA=; b=Wck12WVdi/621N01A1wNtWUHy9F3EGU+P2AYXxv9xTLE50qIp6cX/e4fAhp7jBf1DF Uybcqy/Y7rwExBEBriginoAgd9hnvxC90/yENYjIZBCWW0Z3uxDNcjOnnxcB0nMPAFmA BQ5l3sfrksJin8TRci2uKzxzhJRiVykPITguk42FB8quNB91WqFtV6GwsYW4ohsnqx4u Nms/RIomji7n8YE47i4gsG1pR4uT1QJyUESKdb82lHF/Lr8CymO2rqGVn3GB3+sXqymk jgwmP+BWbQcYtYu4vybY6o6ExhnQiFLOZPjDIxuKMb14bPYYrGadajne3NcuDB95Rbu8 HlIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=KnWKrrjawRTLOiYleRgV3PDi8JFvvBPnPLiWcsRBXJA=; b=nxfnPw2dTnFsdOsFVofOO0BClJPaCY4Emji+sT1D99GiSo+IkvyhmxXvd8z8afI4NN Smal+0ENAV4TCR5MYxOPpG8+Ds1AD+9Qr8obsXF8dc6UDSx9ncJVdCtCEIbwNfKILabF DRrOAG3EQ08MOEw+NIjS8K+989QGZ/c3t1jFzx/V81gRFS1G11Fe1cS23Lq5L0r7kX+G LOwaY1oqc+yklVsdmyPwlO0n+CSW0ocZVvepiervZk19wqgmoUa39Me73GZnXPcknkk2 z+BoQt7DxLo7hwazBgu4d7RX7UHfOfES/IY5a26Hyh3iVjzkOoZzev8UuiorkVRDONR9 FhNQ== X-Gm-Message-State: ACgBeo0NLxsVVatVjcLFWdHuJQ3F02h22/7Y5TZoOTnvpyN01a3kcr4l sv1sZ8N6HUVG9zfr/6kJaRCBvw== X-Google-Smtp-Source: AA6agR7Ppt2+A2Pqs9k402jJcp3AHfjonp0bbtJHBieXzKmidSVkjOxrwHydskVNPI2YlzxKyhDxUw== X-Received: by 2002:a17:903:2646:b0:16f:1d75:3101 with SMTP id je6-20020a170903264600b0016f1d753101mr30681593plb.111.1660199149210; Wed, 10 Aug 2022 23:25:49 -0700 (PDT) Received: from leoy-yangtze.lan (n058152077182.netvigator.com. [58.152.77.182]) by smtp.gmail.com with ESMTPSA id o12-20020a17090a55cc00b001f506009036sm2766926pjm.49.2022.08.10.23.25.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Aug 2022 23:25:48 -0700 (PDT) From: Leo Yan To: Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , John Garry , Will Deacon , James Clark , Mike Leach , Kajol Jain , Ali Saidi , Adrian Hunter , "Gustavo A. R. Silva" , Anshuman Khandual , Ian Rogers , Like Xu , German Gomez , Timothy Hayes , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Leo Yan Subject: [PATCH v6 08/15] perf c2c: Add mean dimensions for peer operations Date: Thu, 11 Aug 2022 14:24:44 +0800 Message-Id: <20220811062451.435810-9-leo.yan@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220811062451.435810-1-leo.yan@linaro.org> References: <20220811062451.435810-1-leo.yan@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220810_232551_433126_B9C39F89 X-CRM114-Status: GOOD ( 14.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This patch adds two dimensions for the mean value of peer operations. Signed-off-by: Leo Yan Acked-by: Ian Rogers Tested-by: Ali Saidi Reviewed-by: Ali Saidi --- tools/perf/builtin-c2c.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c index dd47f068b8da..8dd9218a052f 100644 --- a/tools/perf/builtin-c2c.c +++ b/tools/perf/builtin-c2c.c @@ -55,6 +55,8 @@ struct c2c_hists { struct compute_stats { struct stats lcl_hitm; struct stats rmt_hitm; + struct stats lcl_peer; + struct stats rmt_peer; struct stats load; }; @@ -154,6 +156,8 @@ static void *c2c_he_zalloc(size_t size) init_stats(&c2c_he->cstats.lcl_hitm); init_stats(&c2c_he->cstats.rmt_hitm); + init_stats(&c2c_he->cstats.lcl_peer); + init_stats(&c2c_he->cstats.rmt_peer); init_stats(&c2c_he->cstats.load); return &c2c_he->he; @@ -253,6 +257,10 @@ static void compute_stats(struct c2c_hist_entry *c2c_he, update_stats(&cstats->rmt_hitm, weight); else if (stats->lcl_hitm) update_stats(&cstats->lcl_hitm, weight); + else if (stats->rmt_peer) + update_stats(&cstats->rmt_peer, weight); + else if (stats->lcl_peer) + update_stats(&cstats->lcl_peer, weight); else if (stats->load) update_stats(&cstats->load, weight); } @@ -1280,6 +1288,8 @@ __func(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp, struct hist_entry *he) \ MEAN_ENTRY(mean_rmt_entry, rmt_hitm); MEAN_ENTRY(mean_lcl_entry, lcl_hitm); MEAN_ENTRY(mean_load_entry, load); +MEAN_ENTRY(mean_rmt_peer_entry, rmt_peer); +MEAN_ENTRY(mean_lcl_peer_entry, lcl_peer); static int cpucnt_entry(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp, @@ -1750,6 +1760,22 @@ static struct c2c_dimension dim_mean_load = { .width = 8, }; +static struct c2c_dimension dim_mean_rmt_peer = { + .header = HEADER_SPAN("---------- cycles ----------", "rmt peer", 2), + .name = "mean_rmt_peer", + .cmp = empty_cmp, + .entry = mean_rmt_peer_entry, + .width = 8, +}; + +static struct c2c_dimension dim_mean_lcl_peer = { + .header = HEADER_SPAN_LOW("lcl peer"), + .name = "mean_lcl_peer", + .cmp = empty_cmp, + .entry = mean_lcl_peer_entry, + .width = 8, +}; + static struct c2c_dimension dim_cpucnt = { .header = HEADER_BOTH("cpu", "cnt"), .name = "cpucnt", @@ -1835,6 +1861,8 @@ static struct c2c_dimension *dimensions[] = { &dim_node, &dim_mean_rmt, &dim_mean_lcl, + &dim_mean_rmt_peer, + &dim_mean_lcl_peer, &dim_mean_load, &dim_cpucnt, &dim_srcline,