From patchwork Fri Aug 12 17:35:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tim Harvey X-Patchwork-Id: 12942438 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55788C25B0F for ; Fri, 12 Aug 2022 17:37:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UByghS0N70mqRmPFCkyBkT5EMGiwKkvRDOXBOqaMjLA=; b=dl2KK/NGAJzul3 ecz19CE9/lo1vCScGsEDOmRpujvXdJtJ4BpWz8NcCwASBZt151SEa4b7NH4N7vtGAEzvNrXqxFkGl mDA9zJbW0TXxwDkxXaBYxYeK4AEsstln6/iiwVT4OPVGIl0H+5KfOzmYX9pqVETROp+PrLVjqANnW LZ3ruDg6e9d53zrOCHky64PImM7uhpmPcFZku07x9m0VeV4nv6xr8bQzpcI082if3Ubze/CdWnRPa RSETyZSXCxzEldL16T7zUjVZIYryiIjk64L/GVwBnmy2kXc0w2NOZ2fKHER6umUmoKlLEPHX4lMnd BzXUAJXpAwJUjuK7U00A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMYZt-00BaKd-I7; Fri, 12 Aug 2022 17:36:09 +0000 Received: from finn.gateworks.com ([108.161.129.64] helo=finn.localdomain) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMYZN-00Ba2u-0Y for linux-arm-kernel@lists.infradead.org; Fri, 12 Aug 2022 17:35:38 +0000 Received: from 068-189-091-139.biz.spectrum.com ([68.189.91.139] helo=tharvey.pdc.gateworks.com) by finn.localdomain with esmtp (Exim 4.93) (envelope-from ) id 1oMYZH-00FqKk-Oa; Fri, 12 Aug 2022 17:35:31 +0000 From: Tim Harvey To: Shawn Guo , Fabio Estevam , NXP Linux Team , Sascha Hauer , Rob Herring , Krzysztof Kozlowski , Pengutronix Kernel Team , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Tim Harvey Subject: [PATCH 4/6] arm64: dts: imx8mp-venice-gw74xx: fix port/phy validation Date: Fri, 12 Aug 2022 10:35:24 -0700 Message-Id: <20220812173526.15537-4-tharvey@gateworks.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220812173526.15537-1-tharvey@gateworks.com> References: <20220812173526.15537-1-tharvey@gateworks.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220812_103537_068254_866EE923 X-CRM114-Status: UNSURE ( 8.50 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Since commit 65ac79e18120 ("net: dsa: microchip: add the phylink get_caps") the phy-mode must be set otherwise the switch driver will assume "NA" mode and invalidate the port. Fixes: 7899eb6cb15d ("arm64: dts: imx: Add i.MX8M Plus Gateworks gw7400 dts support") Signed-off-by: Tim Harvey --- arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts index 6ab4896f708b..cb4cf293a7b7 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts @@ -484,30 +484,35 @@ ports { lan1: port@0 { reg = <0>; label = "lan1"; + phy-mode = "internal"; local-mac-address = [00 00 00 00 00 00]; }; lan2: port@1 { reg = <1>; label = "lan2"; + phy-mode = "internal"; local-mac-address = [00 00 00 00 00 00]; }; lan3: port@2 { reg = <2>; label = "lan3"; + phy-mode = "internal"; local-mac-address = [00 00 00 00 00 00]; }; lan4: port@3 { reg = <3>; label = "lan4"; + phy-mode = "internal"; local-mac-address = [00 00 00 00 00 00]; }; lan5: port@4 { reg = <4>; label = "lan5"; + phy-mode = "internal"; local-mac-address = [00 00 00 00 00 00]; };