From patchwork Mon Aug 22 23:45:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 12951487 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52E60C28D13 for ; Mon, 22 Aug 2022 23:47:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=nILI79GcoyjOEjfn+CWNMSH0DHoCebUsuYz2J7mQ8ZM=; b=fEwtlYd8YPXfqs y5LwdxEB4fkg+CUcLfSZcQbRymZ1UNt2weUJcYYfBq8Tz4hGdOpBkP1Ai2/AdfJYKZFA24WEZWTAK 7Tf3iSpHx4YgKZ4rTK+BtkvP7aRxlHkFmkmX1U+m3cyp7GBZibY88j8+438okMbofbKdyZuNw6JSd JiZ9R2K9CKDwit6JPEJcqkLC1rba4KOBaBNZ0nLtI0l4o8cwWvSaKOZuH6vUAVcRINALEuS5IDyU8 qPHpzEN2Ywf+957guGJ4Ym8JIDbwIappP+QR7tobr0wl/skVtvgIaBNPAT8eutiFo1qUonsWfGnhy bt2bBUKaisyX04ThT1Ww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQH7E-00G7Ek-3C; Mon, 22 Aug 2022 23:45:56 +0000 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQH6W-00G6kG-2U for linux-arm-kernel@lists.infradead.org; Mon, 22 Aug 2022 23:45:14 +0000 Received: by mail-pf1-x432.google.com with SMTP id g129so8535946pfb.8 for ; Mon, 22 Aug 2022 16:45:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc; bh=d0Csk6K/KRDvQOW2pJh/wb18v7EwQgVkPuj58liA9sk=; b=d0OjFOtnA74HEPODGOej0roBiHJdXfjGLLMCSA7Dja6dRiZnZ+AIa+/Zq6lX5Ml6bR UhWPfGcABUeKPxY8LkSuTJTdmMgY16YD6uRueoeouqYr0jwXhuQd/vC3haQPN33MOxo8 p3cbT1GhwmDy66zEiQ8KCJgxILUB/5DBIK8oc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc; bh=d0Csk6K/KRDvQOW2pJh/wb18v7EwQgVkPuj58liA9sk=; b=KXBy3Wy4C5BZfzK9JIRoDxPGXg5Cp811oluHR7aFM3gdrXpvJZ7kHz4JWmbhxxkFjY qMjYeaEVzEzBOMQ2Sx3mh7Oj9ez+BtLEB9IBZCFqE1ynIyGI+jkAt/gVEGS/dwmY22/i an1i9mWiPvHEs0/mdC5+Ap8/I592T1zjIdHEA1Hm8F/Fo81N8d0V8I+fvRUxrKl9oEDn x0QQ2WsCiNv1BN1agLENMI+Vkd6iI2x3B1jA+h++quNCOEOkvKK94htfGxdZ8m4HBDMv df+2rgXo8gacK0iXQmhLr4ljB7r0FOTNPAYdWMtSkRQxFGSs8s1lR1OBb1eYoKLAko0e dRLQ== X-Gm-Message-State: ACgBeo2Kj2phCjQ+U1BfTqCRl0TOSs+ED7St2XnPtKSAJmKJbvhR4lpx fVyc3+/ORgFQryq/XzwFlqJw1g== X-Google-Smtp-Source: AA6agR4N9JHSXn0/iMlmacfOfIr0W8bQdy9dMMxR+LBeppeS0cmq9y8V81RI4gycpJsfnvP43c5qaA== X-Received: by 2002:a63:8749:0:b0:41d:89d4:ce3d with SMTP id i70-20020a638749000000b0041d89d4ce3dmr17913148pge.344.1661211910403; Mon, 22 Aug 2022 16:45:10 -0700 (PDT) Received: from localhost ([2620:15c:202:201:34e2:c40e:42d3:27e0]) by smtp.gmail.com with UTF8SMTPSA id h196-20020a6283cd000000b005367043e163sm4063261pfe.28.2022.08.22.16.45.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Aug 2022 16:45:09 -0700 (PDT) From: Brian Norris To: Heiko Stuebner Cc: Douglas Anderson , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Brian Norris Subject: [PATCH] arm64: dts: rockchip: Pull up wlan wake# on Gru-Bob Date: Mon, 22 Aug 2022 16:45:04 -0700 Message-Id: <20220822164453.1.I75c57b48b0873766ec993bdfb7bc1e63da5a1637@changeid> X-Mailer: git-send-email 2.37.2.609.g9ff673ca1a-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220822_164512_431844_81C0CCB7 X-CRM114-Status: GOOD ( 14.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The Gru-Bob board does not have a pull-up resistor on its WLAN_HOST_WAKE# pin, but Kevin does. The production/vendor kernel specified the pin configuration correctly as a pull-up, but this didn't get ported correctly to upstream. This means Bob's WLAN_HOST_WAKE# pin is floating, causing inconsistent wakeup behavior. Note that bt_host_wake_l has a similar dynamic, but apparently the upstream choice was to redundantly configure both internal and external pull-up on Kevin (see the "Kevin has an external pull up" comment in rk3399-gru.dtsi). This doesn't cause any functional problem, although it's perhaps wasteful. Fixes: 8559bbeeb849 ("arm64: dts: rockchip: add Google Bob") Signed-off-by: Brian Norris Reviewed-by: Douglas Anderson --- arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dts | 5 +++++ arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi | 1 + 2 files changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dts b/arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dts index 31ebb4e5fd33..0f9cc042d9bf 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dts @@ -88,3 +88,8 @@ h1_int_od_l: h1-int-od-l { }; }; }; + +&wlan_host_wake_l { + /* Kevin has an external pull up, but Bob does not. */ + rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_up>; +}; diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi index cd074641884b..45796b9fd94f 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi @@ -578,6 +578,7 @@ wifi_perst_l: wifi-perst-l { }; wlan_host_wake_l: wlan-host-wake-l { + /* Kevin has an external pull up, but Bob does not */ rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>; }; };