From patchwork Thu Aug 25 05:22:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bhupesh Sharma X-Patchwork-Id: 12954211 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8940FC04AA5 for ; Thu, 25 Aug 2022 05:23:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=103EfoIV3F0hxoIt/t67Hhypa+o1dfCE4w5p44R8v3E=; b=BJPDV67Jj1a1lq OCMQme2XlmkS0pk2MFWl40BMk2l+kOFgxPTmFi1zGJmkSuOdCGccyXoRc0TSKM4aQm5G9t5arndOe mYzDLJbohzQgSIdYhKvX048H6ruSgQPKwYduQwc+B8KAueT9IKcsr/WmuejXdj/8iolDNJPlwpQPr MeQUGGT6AKbtExDf/jC471DkXuq4NuAqIhpp5qbnL3F8CASYKuL4S13Oh8/pb2qUoTja8rbGaRWR8 U4T42SpQPqfLpDFDCBzUTWAXIU8N2cb9kaxPT24CQin1R4WmA+m4Vr2zASXT9IDTRUnlGj945Wpla t0WLmYWLHCPccMycDIqw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oR5KR-007KAy-0i; Thu, 25 Aug 2022 05:22:55 +0000 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oR5KM-007K95-WE for linux-arm-kernel@lists.infradead.org; Thu, 25 Aug 2022 05:22:52 +0000 Received: by mail-pj1-x1030.google.com with SMTP id pm13so10293978pjb.5 for ; Wed, 24 Aug 2022 22:22:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc; bh=iCasLDNUU4I0Jvm9uv7/lmaTZb534+kQ2JJzlEAGgVs=; b=ZO4Btx4iXxJLni//F+xoZy2N6xzC2V7b+5Z0aO2j6R0wSXg0WDTp/CnzD1C3z8Lww2 8HhM4nRSekycf98PzpxdMnLywyUQwkWVxlJ2qIesNY0rG3tLrd+LaDqplIYnLWbzEl69 obbxJaX5S3XqxltviPBh5d1UB6ZQKtkt8GtwA0eElWuy/AQPAcSm7grOz3d2X7IiAXp1 upMrN2mihK/f/xJAJmkrE6LcTol+GVwCFTq9VBLTDa3QYuFSXPRFpqVz1EaHPqxYcQxb dBPo5MtZGNYVvieBy+TzfjtTtHeuLAroOEQDN0aP4H+Yni1XzCTG4D+7gCsIUNvJEJ90 564g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc; bh=iCasLDNUU4I0Jvm9uv7/lmaTZb534+kQ2JJzlEAGgVs=; b=f0fzgf2Skut3WY5e+CGSD62z+11/MX2ZV75PFn778CJvvhooC6UktbsEQVGvdY+YCo UoGYlYsA7Vje+YfjpEbHhSmSCNzvB3BWv/PfQ2ztTeklkFdlLmwFYgAS8ad/dco7e/3K SLuKHdCFwn+hixhtlaNM1ZjiRoQ0RXZt77V3/+k7Yr7xmYo7MJYWfiUJTGZgFQW2vs4a tSL4f/R0feXKCeGNRwyCSLo6pP7aKNF6WWR80D7RxD4UVYVqXmKZt8qxCUADIhbV4MJW tuCSz88kIfrUv+23DMUD9Yvsn1t4hMQxeEgZShDhtY/xo4p9dul49+1BFxFxpEbxQgeh 6oRw== X-Gm-Message-State: ACgBeo1EuLbagoKMxyONuVWOY88cIt0P2B5it1iaY3LXy1Cwupgh4L7Z XUfizfUZwa9dSqgoKQX/Lwom1w== X-Google-Smtp-Source: AA6agR6pm9HVyhNr+GrQdxfFDMygHSJeTNVyUkWEGUvLvm3pHXeRRLgicmiPaBZ7ndAfW2l377hk+A== X-Received: by 2002:a17:90b:4d89:b0:1fb:1cf5:e23d with SMTP id oj9-20020a17090b4d8900b001fb1cf5e23dmr2702070pjb.133.1661404966607; Wed, 24 Aug 2022 22:22:46 -0700 (PDT) Received: from localhost.localdomain ([2401:4900:1c60:5362:9d7f:2354:1d0a:78e3]) by smtp.gmail.com with ESMTPSA id ik19-20020a170902ab1300b00172a4170ff5sm13529027plb.86.2022.08.24.22.22.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Aug 2022 22:22:46 -0700 (PDT) From: Bhupesh Sharma To: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org Cc: mathieu.poirier@linaro.org, suzuki.poulose@arm.com, mike.leach@linaro.org, leo.yan@linaro.org, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org, bhupesh.linux@gmail.com, Bhupesh Sharma , Greg Kroah-Hartman Subject: [PATCH v2] coresight: etm4x: Fix crash observed on Qcom ETM parts with 'Low power override' Date: Thu, 25 Aug 2022 10:52:32 +0530 Message-Id: <20220825052232.11013-1-bhupesh.sharma@linaro.org> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220824_222251_089435_623D5129 X-CRM114-Status: GOOD ( 17.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Some Qualcomm ETM implementations require skipping powering up the trace unit, as the ETMs are in the same power domain as their CPU cores. Via commit 5214b563588e ("coresight: etm4x: Add support for sysreg only devices"), the setting of 'skip_power_up' flag was moved after the 'etm4_init_arch_data' function is called, whereas the flag value is itself used inside the function. This causes a crash when ETM mode 'Low-power state behavior override' is set on some Qualcomm parts. Fix the same. Fixes: 5214b563588e ("coresight: etm4x: Add support for sysreg only devices") Cc: Mike Leach Cc: Suzuki K Poulose Cc: Mathieu Poirier Cc: Greg Kroah-Hartman Signed-off-by: Bhupesh Sharma --- - v1 can be seen here: https://lore.kernel.org/lkml/20220803191236.3037591-1-bhupesh.sharma@linaro.org/ - Addressed the review comments from Suzuki. - Rebased on linux-next. drivers/hwtracing/coresight/coresight-etm4x-core.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c index d39660a3e50c..14c1c7869795 100644 --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c @@ -977,6 +977,16 @@ static bool etm4_init_sysreg_access(struct etmv4_drvdata *drvdata, if (!cpu_supports_sysreg_trace()) return false; + /* + * Some Qualcomm implementations require skipping powering up the trace unit, + * as the ETMs are in the same power domain as their CPU cores. + * + * Since the 'skip_power_up' flag is used inside 'etm4_init_arch_data' function, + * initialize it before the function is called. + */ + if (fwnode_property_present(dev_fwnode(dev), "qcom,skip-power-up")) + drvdata->skip_power_up = true; + /* * ETMs implementing sysreg access must implement TRCDEVARCH. */ @@ -1951,8 +1961,7 @@ static int etm4_probe(struct device *dev, void __iomem *base, u32 etm_pid) return -EINVAL; /* TRCPDCR is not accessible with system instructions. */ - if (!desc.access.io_mem || - fwnode_property_present(dev_fwnode(dev), "qcom,skip-power-up")) + if (!desc.access.io_mem) drvdata->skip_power_up = true; major = ETM_ARCH_MAJOR_VERSION(drvdata->arch);