Message ID | 20220829212531.3184856-20-surenb@google.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F534ECAAD4 for <linux-arm-kernel@archiver.kernel.org>; Mon, 29 Aug 2022 22:00:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=n+KhZoE1F3wLhd3EGzfCHLgEf2F4w7+Ts2+u7n/57ws=; b=Xj+RW2jrwj+GKI61GdT+0cnWND nODtjevrZd58NQnDlAAQZ31WeBfuNv2LC75czefM293x+phebDnidK2leuLzzdY5FL2cqOP8h8d4n fly/9vL1jDJZN9ctjBLUdPDT7RImuCyI7hvzTZiLpyyiNAVWd2T0CGz3wlyDd3mgtiA/LSMT8LWmf Trkbbij/FAYPW/1D8Pe7ZaYj9Q0Av5VVrV8RKUHp3ojTTu9J0+Pv/5NSMyol0T9MLQ9C8h+btW7QC PV4A2UTdzzlUavYxhKqk82bbAVFL9QPz7Uz/kZ4J/BG7psK1hHa9x4ZtUobI6ZyDGhvMf3Ii2U4o5 K4igSVtw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSmmc-00Cxyh-1E; Mon, 29 Aug 2022 21:59:02 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSmmQ-00Cxru-RM for linux-arm-kernel@bombadil.infradead.org; Mon, 29 Aug 2022 21:58:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:Cc:To:From:Subject: Message-ID:References:Mime-Version:In-Reply-To:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=K93TFWAb7JwQdWCvuFbBF/NwLgqzppA/TxAstG/QPvU=; b=eD7o2Aa+4DDmcGXyhMvQsStfCf qWoFgUtYZDQYh8o9vZE7WuMgs0XHuzH0gl0+rbeI+cWlx5pOtNFdj1N2NY6cXqeNuMbdUNlrCaNmh k1VAzeewQXe6j1HJVCdgyd+Ekw/aheUe4cvQIjwhVn4/pUR108m8FSTOs/RBx4dmWMoKq+w/qA0P+ JxgeYlsu9rKP14YaKOa1jbZhFmoHlEgA0yDMMpkiKNVoC86RscJMGjgeznuhqP1Mi18PS/zkn7Ktk 9XnGViJ6UGoKyyBlr5s1ZBKb6f63HlJeCF8Y4Okm2fX8U50l3p/rXt/5N0yVXJNLMTDyqW1uiS4MT tWygzIFw==; Received: from mail-pl1-x649.google.com ([2607:f8b0:4864:20::649]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSmGp-007bk6-RD for linux-arm-kernel@lists.infradead.org; Mon, 29 Aug 2022 21:26:14 +0000 Received: by mail-pl1-x649.google.com with SMTP id s8-20020a170902ea0800b00172e456031eso6760165plg.3 for <linux-arm-kernel@lists.infradead.org>; Mon, 29 Aug 2022 14:26:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc; bh=K93TFWAb7JwQdWCvuFbBF/NwLgqzppA/TxAstG/QPvU=; b=f8ZHy6CiTcDXROb3pFMLfetBSV+kFVTeZws7OjDiiohYptMrJjGynWZ4jN+J/j3SJj dCEDPAmPkmnX5B3X46hqeY2mb8ZvMpLB7j64gw3uDHSYMAUM2B6ucp8KKPug6MxLnEu7 BmebG6DC6czjsVXnb7ENc9u7p9QGYJElvc7qRNsIMqXvgjewnR2ulhT9EyPiZ2zz1B9D 56/cpf1MfCjBxFK5vFsjvAIH2zjjfVoYxcmJWgmvbc3eCKVdp1qhJM+tuigQjNUJJMgZ jrHBPRDF7lp+rxYzH8zskIPXprMRBcWxeh9qo4POOeyeUnThUPILDVIwum49CxVeKLEs T9zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc; bh=K93TFWAb7JwQdWCvuFbBF/NwLgqzppA/TxAstG/QPvU=; b=J5VJrtDZt1UgNIKeLjmkFJvt/MWTAwavhD61GepAY9S2a1y90T0dwg7MlS1t20gOJc 2XLlvaXnadTTRWVsy8SoElQQ++ftFYMmt084uAPVxD9l6zYl9w2EfTvUenCCB44PrlEb noy9CsDkehVsBH2rejmILNcj/DFvoWY5nOZmQcCW6dtZJT5IbL3uz//kH3giLOEsMFRE uZAgfwkUuBSOsTv6rNGpRhiKHmRTODu8oOrtMnP+ZNNwUKNB0OoIGpiOvpsNTjkvSWDD pWfGS227Qq30lzG1oY1IaWCjlVpur7blDNjt2AxzDtAG9oj2UMxNADizwGs9ODzSby6p EPow== X-Gm-Message-State: ACgBeo2aiQh5F72lhd/zvhwOPm2IZp/6FKkVBqZfhR30yVxfD4WwrN2L H6b+uU2/4R3M3TfiAZ46qEH7ODfa6fY= X-Google-Smtp-Source: AA6agR7nf9+ItGZZ0+7hqrcNY7xNhTop6ny3nOph/OxIOFh5WmAm4Kp1l2Jp+ca/L6EEvcmkimt0snMwAs0= X-Received: from surenb-spec.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:3e30]) (user=surenb job=sendgmr) by 2002:a17:902:b094:b0:173:12d1:4ece with SMTP id p20-20020a170902b09400b0017312d14ecemr18383730plr.117.1661808370030; Mon, 29 Aug 2022 14:26:10 -0700 (PDT) Date: Mon, 29 Aug 2022 21:25:22 +0000 In-Reply-To: <20220829212531.3184856-1-surenb@google.com> Mime-Version: 1.0 References: <20220829212531.3184856-1-surenb@google.com> X-Mailer: git-send-email 2.37.2.672.g94769d06f0-goog Message-ID: <20220829212531.3184856-20-surenb@google.com> Subject: [RFC PATCH 19/28] mm: disallow do_swap_page to handle page faults under VMA lock From: Suren Baghdasaryan <surenb@google.com> To: akpm@linux-foundation.org Cc: michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, laurent.dufour@fr.ibm.com, paulmck@kernel.org, riel@surriel.com, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, surenb@google.com, kernel-team@android.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220829_222612_146425_BAE03CE3 X-CRM114-Status: GOOD ( 10.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org |
Series |
per-VMA locks proposal
|
expand
|
diff --git a/mm/memory.c b/mm/memory.c index 9ac9944e8c62..29d2f49f922a 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -3738,6 +3738,11 @@ vm_fault_t do_swap_page(struct vm_fault *vmf) vm_fault_t ret = 0; void *shadow = NULL; + if (vmf->flags & FAULT_FLAG_VMA_LOCK) { + ret = VM_FAULT_RETRY; + goto out; + } + if (!pte_unmap_same(vmf)) goto out;
Due to the possibility of do_swap_page dropping mmap_lock, abort fault handling under VMA lock and retry holding mmap_lock. This can be handled more gracefully in the future. Signed-off-by: Suren Baghdasaryan <surenb@google.com> --- mm/memory.c | 5 +++++ 1 file changed, 5 insertions(+)