| Message ID | 20220831080301.1092737-3-martin.kepplinger@puri.sm (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: imx8mq-librem5: phone DT updates | expand |
On 31/08/2022 11:02, Martin Kepplinger wrote: > From: Guido Günther <agx@sigxcpu.org> > > Describe the RGB notification leds on the Librem 5 phone. > Use the common defines so we're sure to adhere to the common patterns, > use predefined led colors and functions so we're being warned in case > of deprecations. > > Signed-off-by: Guido Günther <agx@sigxcpu.org> > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> > --- > .../boot/dts/freescale/imx8mq-librem5.dtsi | 26 +++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi > index 0626e4194d958..bbf49e419b498 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi > @@ -7,6 +7,7 @@ > > #include "dt-bindings/input/input.h" > #include <dt-bindings/interrupt-controller/irq.h> > +#include <dt-bindings/leds/common.h> > #include "dt-bindings/pwm/pwm.h" > #include "dt-bindings/usb/pd.h" > #include "imx8mq.dtsi" > @@ -54,6 +55,31 @@ key-vol-up { > }; > }; > > + pwmleds { > + compatible = "pwm-leds"; > + > + blue { Test your DTS (`make dtbs_check`). Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi index 0626e4194d958..bbf49e419b498 100644 --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi @@ -7,6 +7,7 @@ #include "dt-bindings/input/input.h" #include <dt-bindings/interrupt-controller/irq.h> +#include <dt-bindings/leds/common.h> #include "dt-bindings/pwm/pwm.h" #include "dt-bindings/usb/pd.h" #include "imx8mq.dtsi" @@ -54,6 +55,31 @@ key-vol-up { }; }; + pwmleds { + compatible = "pwm-leds"; + + blue { + function = LED_FUNCTION_STATUS; + color = <LED_COLOR_ID_BLUE>; + max-brightness = <248>; + pwms = <&pwm2 0 50000 0>; + }; + + green { + function = LED_FUNCTION_STATUS; + color = <LED_COLOR_ID_GREEN>; + max-brightness = <248>; + pwms = <&pwm4 0 50000 0>; + }; + + red { + function = LED_FUNCTION_STATUS; + color = <LED_COLOR_ID_RED>; + max-brightness = <248>; + pwms = <&pwm3 0 50000 0>; + }; + }; + reg_aud_1v8: regulator-audio-1v8 { compatible = "regulator-fixed"; pinctrl-names = "default";