From patchwork Thu Sep 1 00:08:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 12961577 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 12984ECAAD4 for ; Thu, 1 Sep 2022 00:09:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=oDbEMTyGMz//yw/x1Bj++MO5R5tElDIGD2krsK16xmU=; b=HQZ1yprkq/J7G6 IsDp2VHpwiiIk73LSw6VEMegIFEki1SBxJf9Wo6OkrosclLY8wA+gIocT3l2D+v1WUkOZTguQRlkO InkgVYe5M0Rd76tQjpN20H/bW8K0blBVMwU1WfZuASum+HTvJWa1DQjGLwTAY2jt54rggZ832RYzL WR33KJMiaB1PQwE9FmwMRtOeaXcWLC94zwrygWIQZfsRnOiOn61drqkh3hiGMKvTVxu67sNsVDs3d q5pJRj61i8gzie1kTbkjhT6OTATwqzToAZ3QiGKGLu0MZcbJgny0FhAaWwwleJzffT/h3GdfX/Ei3 KBr4kZMswKD8v/tV3BXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTXl5-008lMn-KX; Thu, 01 Sep 2022 00:08:35 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTXl3-008lMW-HY; Thu, 01 Sep 2022 00:08:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:In-Reply-To:References; bh=Hd91EW3kjcTC8uTz0Z3zEpV5uiB9H4sNzGD2aIxgxZU=; b=rcvUCGONI388kgK0ZU64Ib34VB 4F8NPsyi5KKll3lXXfQevIhUB9EArHeYUpNHHhSEPDxQTqZU5EQnU8AD88EiT88cxH4CbNDcanlr4 QAOO+VKgC1rAkDsxpt73gen/VYjtZgrwaiEbWz05NDGADFbSnjjdMfMdTQXFGR0Za1EljFFA4Bw+D 2h33M5pbKyZTAbvjvASm30SG51Z63MPlxY5GgxhokN4NnWmMEm0CXF9m858vrxFQL2j7BLeFKhb0D 5O1oHIWYqz2Nn/D2xCRUkE2/y/kN6SaEytBtIepaImo/QI0u2chRgGvnfQIwL+iEQOs5bq5sh8zbY NvG6gBjQ==; Received: from [2601:1c0:6280:3f0::a6b3] (helo=casper.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTXky-005Yw5-FT; Thu, 01 Sep 2022 00:08:29 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , kernel test robot , Qin Jian , Necip Fazil Yildiran , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, patches@armlinux.org.uk Subject: [PATCH v2] ARM: sunplus: fix serial console kconfig and build problems Date: Wed, 31 Aug 2022 17:08:21 -0700 Message-Id: <20220901000821.15376-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fix kconfig dependency warnings and subsequent build errors: WARNING: unmet direct dependencies detected for SERIAL_SUNPLUS Depends on [n]: TTY [=n] && HAS_IOMEM [=y] && (ARCH_SUNPLUS [=y] || COMPILE_TEST [=n]) Selected by [y]: - SOC_SP7021 [=y] && ARCH_SUNPLUS [=y] WARNING: unmet direct dependencies detected for SERIAL_SUNPLUS_CONSOLE Depends on [n]: TTY [=n] && HAS_IOMEM [=y] && SERIAL_SUNPLUS [=y] Selected by [y]: - SOC_SP7021 [=y] && ARCH_SUNPLUS [=y] (samples, not all:) drivers/tty/serial/sunplus-uart.c:342: undefined reference to `uart_get_baud_rate' arm-linux-gnueabi-ld: drivers/tty/serial/sunplus-uart.c:379: undefined reference to `uart_update_timeout' drivers/tty/serial/sunplus-uart.c:526: undefined reference to `uart_console_write' arm-linux-gnueabi-ld: drivers/tty/serial/sunplus-uart.c:274: undefined reference to `tty_flip_buffer_push' arm-linux-gnueabi-ld: drivers/tty/serial/sunplus-uart.o:(.data+0xa8): undefined reference to `uart_console_device' drivers/tty/serial/sunplus-uart.c:720: undefined reference to `uart_register_driver' arm-linux-gnueabi-ld: drivers/tty/serial/sunplus-uart.c:726: undefined reference to `uart_unregister_driver' drivers/tty/serial/sunplus-uart.c:551: undefined reference to `uart_parse_options' arm-linux-gnueabi-ld: drivers/tty/serial/sunplus-uart.c:553: undefined reference to `uart_set_options' This is the same technique that is used 2 times in arch/arm/mach-versatile/Kconfig. Fixes: 0aa94eea8d95 ("ARM: sunplus: Add initial support for Sunplus SP7021 SoC") Reported-by: kernel test robot Signed-off-by: Randy Dunlap Cc: Qin Jian Cc: Necip Fazil Yildiran Cc: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org Cc: patches@armlinux.org.uk --- KernelVersion: 6.0-rc3 v2: refresh; add KernelVersion & patches@armlinux email; arch/arm/mach-sunplus/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/arch/arm/mach-sunplus/Kconfig +++ b/arch/arm/mach-sunplus/Kconfig @@ -18,8 +18,8 @@ config SOC_SP7021 select ARM_PSCI select PINCTRL select PINCTRL_SPPCTL - select SERIAL_SUNPLUS - select SERIAL_SUNPLUS_CONSOLE + select SERIAL_SUNPLUS if TTY + select SERIAL_SUNPLUS_CONSOLE if TTY help Support for Sunplus SP7021 SoC. It is based on ARM 4-core Cortex-A7 with various peripherals (e.g.: I2C, SPI, SDIO,