diff mbox series

[v2,1/2] arm64: dts: rockchip: add LED for ROCK Pi 4A/B/C/A+/B+

Message ID 20220908031726.1307105-1-naoki@radxa.com (mailing list archive)
State New, archived
Headers show
Series [v2,1/2] arm64: dts: rockchip: add LED for ROCK Pi 4A/B/C/A+/B+ | expand

Commit Message

FUKAUMI Naoki Sept. 8, 2022, 3:17 a.m. UTC
only user_led2 (blue) is supported.

user_led1 (green) is not connected to any gpio so it cannot be
controlled.

Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
v2:
 - fix led node label

 .../boot/dts/rockchip/rk3399-rock-pi-4.dtsi   | 21 +++++++++++++++++++
 1 file changed, 21 insertions(+)

Comments

Heiko Stübner Sept. 9, 2022, 6:33 p.m. UTC | #1
On Thu, 8 Sep 2022 03:17:25 +0000, FUKAUMI Naoki wrote:
> only user_led2 (blue) is supported.
> 
> user_led1 (green) is not connected to any gpio so it cannot be
> controlled.

Applied, thanks!

[1/2] arm64: dts: rockchip: add LED for ROCK Pi 4A/B/C/A+/B+
      commit: 7ebfd4f6b52a60820e8d03577fdb082176cd8e79
[2/2] arm64: dts: rockchip: add LEDs for ROCK 4C+
      commit: 6cbd76752791552554e5587f34781408215d1e5b

I've dropped the io-domain addition from patch2.
If that is somehow necessary, please send a new patch
with an actual commit message explaining the new io-domain.

Best regards,
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi
index 401e1ae9d944..6464a6729729 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi
@@ -6,6 +6,7 @@ 
 
 /dts-v1/;
 #include <dt-bindings/input/linux-event-codes.h>
+#include <dt-bindings/leds/common.h>
 #include <dt-bindings/pwm/pwm.h>
 #include "rk3399.dtsi"
 #include "rk3399-opp.dtsi"
@@ -27,6 +28,20 @@  clkin_gmac: external-gmac-clock {
 		#clock-cells = <0>;
 	};
 
+	leds {
+		compatible = "gpio-leds";
+		pinctrl-names = "default";
+		pinctrl-0 = <&user_led2>;
+
+		/* USER_LED2 */
+		led-0 {
+			function = LED_FUNCTION_STATUS;
+			color = <LED_COLOR_ID_BLUE>;
+			gpios = <&gpio3 RK_PD5 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "heartbeat";
+		};
+	};
+
 	sdio_pwrseq: sdio-pwrseq {
 		compatible = "mmc-pwrseq-simple";
 		clocks = <&rk808 1>;
@@ -553,6 +568,12 @@  hp_int: hp-int {
 		};
 	};
 
+	leds {
+		user_led2: user-led2 {
+			rockchip,pins = <3 RK_PD5 RK_FUNC_GPIO &pcfg_pull_none>;
+		};
+	};
+
 	pcie {
 		pcie_pwr_en: pcie-pwr-en {
 			rockchip,pins = <2 RK_PD2 RK_FUNC_GPIO &pcfg_pull_none>;