From patchwork Tue Sep 13 07:21:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tang Bin X-Patchwork-Id: 12974501 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9883CC54EE9 for ; Tue, 13 Sep 2022 07:23:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=ydHlZP2c5yF3Gmm7CYk6Rm6Adg98ItsFTY6YMZq7PFg=; b=crE8U6BxEmgmYb S5DTuStO1q2UFV444IzuGUgQVP5O0Sgxv1FLjn1YqRdpEni4A3O6zYjI4bniW/TC2BQWdL4IYAGu3 APzUzxhaEypDUuRAmxlYUVeAS5IEXzuhVvZLE44t87u70fP9zhqJTYaBNH/Y42Rd8/BUiqw5M/YAf 1FststjsRmhW7eRPZhRAwVvg7vi2A8Gz3W9DgNa60FPsbqfypMmgC3XDkkGQ7iVfvXGYLXFi2sw8X cVAckZi3zMFCqxC8RyaJqe7bUX5aB5cp/+7hcRRVopoHiMa644Fz96jgTnR5Y96BaWf0NdutQ2akQ X2y2vcGpfB95Fz65qPJQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oY0F4-003UYA-JR; Tue, 13 Sep 2022 07:21:58 +0000 Received: from cmccmta2.chinamobile.com ([221.176.66.80]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oY0Er-003UUL-Oh for linux-arm-kernel@lists.infradead.org; Tue, 13 Sep 2022 07:21:56 +0000 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from spf.mail.chinamobile.com (unknown[172.16.121.1]) by rmmx-syy-dmz-app07-12007 (RichMail) with SMTP id 2ee763202f85fd7-35f89; Tue, 13 Sep 2022 15:21:43 +0800 (CST) X-RM-TRANSID: 2ee763202f85fd7-35f89 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from localhost.localdomain (unknown[223.108.79.98]) by rmsmtp-syy-appsvr01-12001 (RichMail) with SMTP id 2ee163202f844cd-4e1df; Tue, 13 Sep 2022 15:21:43 +0800 (CST) X-RM-TRANSID: 2ee163202f844cd-4e1df From: Tang Bin To: shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tang Bin Subject: [PATCH] soc: imx: imx8m-blk-ctrl: Fix wrong check Date: Tue, 13 Sep 2022 15:21:55 +0800 Message-Id: <20220913072155.13392-1-tangbin@cmss.chinamobile.com> X-Mailer: git-send-email 2.20.1.windows.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220913_002153_628247_37AE4785 X-CRM114-Status: GOOD ( 10.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In the function imx8m_blk_ctrl_probe(), dev_pm_domain_attach_by_name() may return NULL in some cases, so IS_ERR() doesn't meet the requirements. Thus fix it. Fixes: 2684ac05a8c4 ("soc: imx: add i.MX8M blk-ctrl driver") Signed-off-by: Tang Bin --- drivers/soc/imx/imx8m-blk-ctrl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c b/drivers/soc/imx/imx8m-blk-ctrl.c index ccd0577a7..98a1f2151 100644 --- a/drivers/soc/imx/imx8m-blk-ctrl.c +++ b/drivers/soc/imx/imx8m-blk-ctrl.c @@ -235,10 +235,10 @@ static int imx8m_blk_ctrl_probe(struct platform_device *pdev) domain->power_dev = dev_pm_domain_attach_by_name(dev, data->gpc_name); - if (IS_ERR(domain->power_dev)) { + if (IS_ERR_OR_NULL(domain->power_dev)) { dev_err_probe(dev, PTR_ERR(domain->power_dev), "failed to attach power domain\n"); - ret = PTR_ERR(domain->power_dev); + ret = PTR_ERR(domain->power_dev) ? : -ENODATA; goto cleanup_pds; }