From patchwork Wed Sep 14 15:32:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dorota Czaplejewicz X-Patchwork-Id: 12976320 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7E4EECAAD3 for ; Wed, 14 Sep 2022 15:33:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:Message-ID:Subject:To:From:Date:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=kErLuIDrmu+jZHmCTJqAHYPX4aNQUnKzO74nA0kMFaw=; b=vjc Ft13PHBU977TDt1TtVe2f4uXAjaoojZzFKOxQxWoRXz03v87iI+sF8OK2Ap+VOxknoId0pwjbhiM0 LMCIh0SgDHp7tQPA2VPbpnxpk4WDSMu4JBja3SmGk2H4z6EYYI9ZqJsCxC/RcrLWZp3525DTIpII0 YdAWcpSJs9PVF9+VPpMNRTTwg+vo2qjvjNiRM0CL1ibMF6wFhy1dzdg52T2LBHtpxcG4Ndj3h1IeJ fBFEK3FEKUu7sY8i8VDF/c3pojwmJddfbCk3Ames2SOlGMlr6g9qZM9mKEXMqgIJur0atyc1+QS5g YcvFUt5xzsJUnkSq8RrYxDTHisGOUwA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oYUNb-003yJD-2n; Wed, 14 Sep 2022 15:32:47 +0000 Received: from comms.puri.sm ([159.203.221.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oYUNY-003yHp-M3 for linux-arm-kernel@lists.infradead.org; Wed, 14 Sep 2022 15:32:45 +0000 Received: from localhost (localhost [127.0.0.1]) by comms.puri.sm (Postfix) with ESMTP id 11A11E0E70; Wed, 14 Sep 2022 08:32:44 -0700 (PDT) Received: from comms.puri.sm ([127.0.0.1]) by localhost (comms.puri.sm [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Poz8d05vzgzF; Wed, 14 Sep 2022 08:32:43 -0700 (PDT) Date: Wed, 14 Sep 2022 17:32:36 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=puri.sm; s=comms; t=1663169563; bh=uuekv8jywcRwSksg0sQmwcM0xjq7DU2XBG5Ob1vzVl4=; h=Date:From:To:Subject:From; b=OkUJ3VqYSP1qeb3ENwgc6YjP9UfCi1JhEp/XtdeAl/0PP+aONZ9l/UMtF2u1ZrE/A 3So+tYWo8C5RuIU93EZqd3lN8gKfKnjDih/PYiJj1gPK0wdqKY/jfJDVQqSUyO+rr2 pli8BvBfeyIcr7b6TAqCIQv5icuc5/fMw74cdyfjUxkckhn2Z0QU0cQlO8MEhCRSYf 7y8MEkmOoP+YupcjitsBaU1ixQ/r19uC0U7PgTwG1f3fLyKX9RHemaJ0OVbrWBVZQ1 LlywltdOpwAXNbEWyJ9Weq6XuOAW4w4/GJezqRlDF41YFANDydNgeKesBS+juzHxaC YGKh5+uy/YoSg== From: Dorota Czaplejewicz To: Laurent Pinchart , Steve Longerbeam , Philipp Zabel , Mauro Carvalho Chehab , Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@puri.sm, phone-devel@vger.kernel.org Subject: [PATCHv2 1/1] media: imx: Round line size to 4 bytes Message-ID: <20220914173236.3040f3a1.dorota.czaplejewicz@puri.sm> Organization: Purism MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220914_083244_743241_DD360624 X-CRM114-Status: GOOD ( 12.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Section 13.7.6.13 "CSI Image Parameter Register" of the i.MX 8M Quad Applications Processors Reference Manual states that the line size should be divisible by 8 bytes. However, the hardware also accepts sizes divisible by 4 bytes, which are needed to fully utilize the S5K3L6XX sensors. This patch accepts line sizes divisible 4-bytes in non-planar mode. --- Hello, the Librem 5 is using an out-of-tree driver for s5k3l6xx, and rounding to 4 is optimal to operate it. Please ignore my previous series, I sent it by mistake. Cheers, Dorota Czaplejewicz drivers/staging/media/imx/imx7-media-csi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c index a0553c24cce4..af821b410c3f 100644 --- a/drivers/staging/media/imx/imx7-media-csi.c +++ b/drivers/staging/media/imx/imx7-media-csi.c @@ -999,10 +999,10 @@ static int imx7_csi_mbus_fmt_to_pix_fmt(struct v4l2_pix_format *pix, } /* Round up width for minimum burst size */ - width = round_up(mbus->width, 8); + width = round_up(mbus->width, 4); /* Round up stride for IDMAC line start address alignment */ - stride = round_up((width * cc->bpp) >> 3, 8); + stride = round_up((width * cc->bpp) >> 3, 4); pix->width = width; pix->height = mbus->height;