From patchwork Tue Sep 27 23:08:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Hilman X-Patchwork-Id: 12991469 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7FF5CC07E9D for ; Tue, 27 Sep 2022 23:09:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=st/bVWmOkTiZ9U4lFMSoXjCblM9kTROOIxT4ioUGRaE=; b=M9A2zbRK/Bz2Rw D5OsqywaUgFakcd3TwND4jpC+M5GIpna7wfvEaJkdkGW1okER6Th2se5FNqzEMSEpPK+KsXBsSoje 3k9l3YRNjJREhl7+td4hR6jM8ctcc17ydL7MYuSef7KjmhGx7YI30GWMEG2rqVXaChsqnYr9Qe/ub Fw7yFxBiyreyb7Xb/QVqv2hf/8LoqW3q8C1+ADOzDqLVsCGkcsXsuZoFdbTZ8yo/rME+gr7DR2yFR 5j12xuWQC4Lim5HN7H4w1h7fjdMyxmnDY6k9C3PjTetTS9YQnKMHBtx9IgjBFIwESGYQpCb+MdLTE qxFEh5suv2R9QJPqNj1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odJgi-00D7PJ-Dr; Tue, 27 Sep 2022 23:08:28 +0000 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1odJgR-00D7N1-5i for linux-arm-kernel@lists.infradead.org; Tue, 27 Sep 2022 23:08:12 +0000 Received: by mail-pg1-x52e.google.com with SMTP id 129so9269130pgc.5 for ; Tue, 27 Sep 2022 16:08:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=3D+ViyFwrXZ0nshMyB6HV1II5SU4JDOahb0+F+RI0tE=; b=b5fb58H+z3ZJAsyvwzFqDmxJqpA96BLlhQe6uVl+mwqulv0KClo2l8aIq0msqF3k/M 2CenHdRU5BEBXXdo153aGnR7tEQaj/gBb75QvRC/gzwYD3FlPVixLJiavAGRQDMY5TQV ZFcbN7igcwVkc7HLFnGedISchZiux20mJO+2YVFAHHkbJmGNnt99pEKP/Kk7+0PvdO19 bklUCkZc/C5T4c4/qnLb4AmM77ybfRH+xX+XiQL/M0bsWms3WJJO2WI64D7qGYF/pBol nuoMcUjm8altWuSoJWS3ZA0a1s6pH7CjnC+PdyknZAKcdLFX9XBmjEGmLnYujZzjdGdV jDtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=3D+ViyFwrXZ0nshMyB6HV1II5SU4JDOahb0+F+RI0tE=; b=GQo6vKdB9YHIQpPQ8yo0ljzjLjOmcQiLYCAfy9GjHHEPrAajsrZLIFGWPgvfp8D7jJ 5T0mfUKmYkyCQiZyB/7p3lXPEjMiy1QVsjn3EafUG98/IiWCrbJTRbdpnNCtbW1cfeI/ QyAJPC3HojeZ4fJ3q8Ip5jXXlMRYhoI4makUdsyr7QtCCqL/3e/WUeeQB9DvibN9Sir6 fRfbFLAfgMnqkjfOMwEYsUqVgyoJ1ilIVtNMN34LlgxPDwr49tN9AVSVdTR0LyySDawk 3vZjyfU0OXTdUAM3tb6OHDDSNVpHQ31hBWCt+wK2qooZqw+6MjDc/salECy+TWsJ6E2p yTgw== X-Gm-Message-State: ACrzQf2C7X5qsYod131HPRK4wMsj7u9lP0izGp/uaViP+uyc/Harvxrk kRxIxKSCMxRgyt+kiAiND/uvFg== X-Google-Smtp-Source: AMsMyM525NWDdFeelA0uGSrAFLlw61Kz5Ki/PBk5/uD0cQTBGE80JfTpmVu5HT7tyhpjGHg3rpd5LA== X-Received: by 2002:a63:dd01:0:b0:439:34d8:82d5 with SMTP id t1-20020a63dd01000000b0043934d882d5mr26244218pgg.530.1664320089622; Tue, 27 Sep 2022 16:08:09 -0700 (PDT) Received: from localhost ([76.146.1.42]) by smtp.gmail.com with ESMTPSA id t17-20020aa79471000000b0053ebe7ffddcsm2338488pfq.116.2022.09.27.16.08.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Sep 2022 16:08:08 -0700 (PDT) From: Kevin Hilman To: Peter Ujfalusi , dmaengine@vger.kernel.org Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Nicolas Frayer Subject: [PATCH v2 2/3] dma/ti: convert k3-udma to module Date: Tue, 27 Sep 2022 16:08:03 -0700 Message-Id: <20220927230804.4085579-3-khilman@baylibre.com> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20220927230804.4085579-1-khilman@baylibre.com> References: <20220927230804.4085579-1-khilman@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220927_160811_233754_AD4ABB76 X-CRM114-Status: GOOD ( 20.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Currently k3-udma driver is built as separate platform drivers with a shared probe and identical code path, just differnet platform data. To enable to build as module, convert the separate platform driver into a single module_platform_driver with the data selection done via compatible string and of_match. The separate of_match tables are also combined into a single table to avoid the multiple calls to of_match_node() Since all modern TI platforms using this are DT enabled, the removal of separate platform_drivers shoul should nave no functional change. Signed-off-by: Kevin Hilman Acked-by: Peter Ujfalusi --- drivers/dma/ti/Kconfig | 4 ++-- drivers/dma/ti/k3-udma-glue.c | 5 ++++- drivers/dma/ti/k3-udma.c | 40 +++++------------------------------ 3 files changed, 11 insertions(+), 38 deletions(-) diff --git a/drivers/dma/ti/Kconfig b/drivers/dma/ti/Kconfig index 79618fac119a..f196be3b222f 100644 --- a/drivers/dma/ti/Kconfig +++ b/drivers/dma/ti/Kconfig @@ -35,7 +35,7 @@ config DMA_OMAP DMA engine is found on OMAP and DRA7xx parts. config TI_K3_UDMA - bool "Texas Instruments UDMA support" + tristate "Texas Instruments UDMA support" depends on ARCH_K3 depends on TI_SCI_PROTOCOL depends on TI_SCI_INTA_IRQCHIP @@ -48,7 +48,7 @@ config TI_K3_UDMA DMA engine is used in AM65x and j721e. config TI_K3_UDMA_GLUE_LAYER - bool "Texas Instruments UDMA Glue layer for non DMAengine users" + tristate "Texas Instruments UDMA Glue layer for non DMAengine users" depends on ARCH_K3 depends on TI_K3_UDMA help diff --git a/drivers/dma/ti/k3-udma-glue.c b/drivers/dma/ti/k3-udma-glue.c index 4fdd9f06b723..c29de4695ae7 100644 --- a/drivers/dma/ti/k3-udma-glue.c +++ b/drivers/dma/ti/k3-udma-glue.c @@ -6,6 +6,7 @@ * */ +#include #include #include #include @@ -1433,4 +1434,6 @@ static int __init k3_udma_glue_class_init(void) { return class_register(&k3_udma_glue_devclass); } -arch_initcall(k3_udma_glue_class_init); + +module_init(k3_udma_glue_class_init); +MODULE_LICENSE("GPL v2"); diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c index 2f0d2c68c93c..7239ff31c8c5 100644 --- a/drivers/dma/ti/k3-udma.c +++ b/drivers/dma/ti/k3-udma.c @@ -5,6 +5,7 @@ */ #include +#include #include #include #include @@ -4318,18 +4319,10 @@ static const struct of_device_id udma_of_match[] = { .compatible = "ti,j721e-navss-mcu-udmap", .data = &j721e_mcu_data, }, - { /* Sentinel */ }, -}; - -static const struct of_device_id bcdma_of_match[] = { { .compatible = "ti,am64-dmss-bcdma", .data = &am64_bcdma_data, }, - { /* Sentinel */ }, -}; - -static const struct of_device_id pktdma_of_match[] = { { .compatible = "ti,am64-dmss-pktdma", .data = &am64_pktdma_data, @@ -5254,14 +5247,9 @@ static int udma_probe(struct platform_device *pdev) return -ENOMEM; match = of_match_node(udma_of_match, dev->of_node); - if (!match) - match = of_match_node(bcdma_of_match, dev->of_node); if (!match) { - match = of_match_node(pktdma_of_match, dev->of_node); - if (!match) { - dev_err(dev, "No compatible match found\n"); - return -ENODEV; - } + dev_err(dev, "No compatible match found\n"); + return -ENODEV; } ud->match_data = match->data; @@ -5494,27 +5482,9 @@ static struct platform_driver udma_driver = { }, .probe = udma_probe, }; -builtin_platform_driver(udma_driver); -static struct platform_driver bcdma_driver = { - .driver = { - .name = "ti-bcdma", - .of_match_table = bcdma_of_match, - .suppress_bind_attrs = true, - }, - .probe = udma_probe, -}; -builtin_platform_driver(bcdma_driver); - -static struct platform_driver pktdma_driver = { - .driver = { - .name = "ti-pktdma", - .of_match_table = pktdma_of_match, - .suppress_bind_attrs = true, - }, - .probe = udma_probe, -}; -builtin_platform_driver(pktdma_driver); +module_platform_driver(udma_driver); +MODULE_LICENSE("GPL v2"); /* Private interfaces to UDMA */ #include "k3-udma-private.c"