diff mbox series

arm64: dts: ti: j721e-common-proc-board: Fix sound node-name

Message ID 20220928122509.143342-1-j-choudhary@ti.com (mailing list archive)
State New, archived
Headers show
Series arm64: dts: ti: j721e-common-proc-board: Fix sound node-name | expand

Commit Message

Jayesh Choudhary Sept. 28, 2022, 12:25 p.m. UTC
If root-node has no reg property, the unit-address should not
be appended at the end of node-name. sound node has no 'reg'
property, so remove the unit-address.

Fixes: ed3aad5b8268 ('arm64: dts: ti: j721e-common-proc-board: Analog audio support')
Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jai Luthra Nov. 16, 2022, 6:34 a.m. UTC | #1
On 28/09/22 17:55, Jayesh Choudhary wrote:
> If root-node has no reg property, the unit-address should not
> be appended at the end of node-name. sound node has no 'reg'
> property, so remove the unit-address.
> 
> Fixes: ed3aad5b8268 ('arm64: dts: ti: j721e-common-proc-board: Analog audio support')
> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>

Reviewed-by: Jai Luthra <j-luthra@ti.com>

> ---
>   arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> index b1691ac3442d..4da3fcdc28e5 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> @@ -96,7 +96,7 @@ vdd_sd_dv_alt: gpio-regulator-TLV71033 {
>   			 <3300000 0x1>;
>   	};
>   
> -	sound0: sound@0 {
> +	sound0: sound-0 {
>   		compatible = "ti,j721e-cpb-audio";
>   		model = "j721e-cpb";
>   

Thanks,
Jai
Nishanth Menon Nov. 17, 2022, 7:13 a.m. UTC | #2
Hi Jayesh Choudhary,

On Wed, 28 Sep 2022 17:55:09 +0530, Jayesh Choudhary wrote:
> If root-node has no reg property, the unit-address should not
> be appended at the end of node-name. sound node has no 'reg'
> property, so remove the unit-address.
> 
> 

I have applied the following to branch ti-k3-dts-next on [1].
Thank you!

When I applied, I dropped 'Fixes' tag for a few reasons:
a) It was trivial node cleanup fix, which per stable-rules dont make sense to
   get backported
b) The fixes format itself was wrong
c) The commit on which the fixes were to be applied would'nt apply (There is
   churn since then)

[1/1] arm64: dts: ti: j721e-common-proc-board: Fix sound node-name
      commit: f789fd29650b6fcee8995f53077d03d509a5d9f5

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] git://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
index b1691ac3442d..4da3fcdc28e5 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
@@ -96,7 +96,7 @@  vdd_sd_dv_alt: gpio-regulator-TLV71033 {
 			 <3300000 0x1>;
 	};
 
-	sound0: sound@0 {
+	sound0: sound-0 {
 		compatible = "ti,j721e-cpb-audio";
 		model = "j721e-cpb";