| Message ID | 20220928155519.31977-3-matthias.bgg@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | soc: mediatek: mtk-svs: refactor and cleanup the driver | expand |
Il 28/09/22 17:55, matthias.bgg@kernel.org ha scritto: > From: Matthias Brugger <matthias.bgg@gmail.com> > > If a compatible misses a match data entry, then something is wrong in > the development phase, we don't need to check for that at runtime. > > Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com> > --- > > drivers/soc/mediatek/mtk-svs.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c > index fd0f636e8644..52bb4f8bbe6d 100644 > --- a/drivers/soc/mediatek/mtk-svs.c > +++ b/drivers/soc/mediatek/mtk-svs.c > @@ -2332,10 +2332,6 @@ static struct svs_platform *svs_platform_probe(struct platform_device *pdev) > int ret; > > svsp_data = of_device_get_match_data(&pdev->dev); Changing that to device_get_match_data() (so, dropping of_) would be a plus to this cleanup, perhaps... In any case: Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > - if (!svsp_data) { > - dev_err(&pdev->dev, "no svs platform data?\n"); > - return ERR_PTR(-EPERM); > - } > > svsp = devm_kzalloc(&pdev->dev, sizeof(*svsp), GFP_KERNEL); > if (!svsp)
diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c index fd0f636e8644..52bb4f8bbe6d 100644 --- a/drivers/soc/mediatek/mtk-svs.c +++ b/drivers/soc/mediatek/mtk-svs.c @@ -2332,10 +2332,6 @@ static struct svs_platform *svs_platform_probe(struct platform_device *pdev) int ret; svsp_data = of_device_get_match_data(&pdev->dev); - if (!svsp_data) { - dev_err(&pdev->dev, "no svs platform data?\n"); - return ERR_PTR(-EPERM); - } svsp = devm_kzalloc(&pdev->dev, sizeof(*svsp), GFP_KERNEL); if (!svsp)