| Message ID | 20220930072707.516270-1-patrice.chotard@foss.st.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] usb: dwc3: st: Rely on child's compatible instead of name | expand |
On Fri, Sep 30, 2022 at 09:27:07AM +0200, patrice.chotard@foss.st.com wrote: > From: Patrice Chotard <patrice.chotard@foss.st.com> > > To ensure that child node is found, don't rely on child's node name > which can take different value, but on child's compatible name. > > Fixes: f5c5936d6b4d ("usb: dwc3: st: Fix node's child name") > > Cc: Jerome Audu <jerome.audu@st.com> > Reported-by: Felipe Balbi <felipe@balbi.sh> > Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com> > --- > drivers/usb/dwc3/dwc3-st.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c > index 166b5bde45cb..fea5290de83f 100644 > --- a/drivers/usb/dwc3/dwc3-st.c > +++ b/drivers/usb/dwc3/dwc3-st.c > @@ -251,7 +251,7 @@ static int st_dwc3_probe(struct platform_device *pdev) > /* Manage SoftReset */ > reset_control_deassert(dwc3_data->rstc_rst); > > - child = of_get_child_by_name(node, "dwc3"); > + child = of_get_compatible_child(node, "snps,dwc3"); > if (!child) { > dev_err(&pdev->dev, "failed to find dwc3 core node\n"); > ret = -ENODEV; > -- > 2.25.1 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot
On Fri, Sep 30, 2022 at 09:27:07AM +0200, patrice.chotard@foss.st.com wrote: > From: Patrice Chotard <patrice.chotard@foss.st.com> > > To ensure that child node is found, don't rely on child's node name > which can take different value, but on child's compatible name. > > Fixes: f5c5936d6b4d ("usb: dwc3: st: Fix node's child name") > > Cc: Jerome Audu <jerome.audu@st.com> > Reported-by: Felipe Balbi <felipe@balbi.sh> > Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com> > --- > drivers/usb/dwc3/dwc3-st.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c > index 166b5bde45cb..fea5290de83f 100644 > --- a/drivers/usb/dwc3/dwc3-st.c > +++ b/drivers/usb/dwc3/dwc3-st.c > @@ -251,7 +251,7 @@ static int st_dwc3_probe(struct platform_device *pdev) > /* Manage SoftReset */ > reset_control_deassert(dwc3_data->rstc_rst); > > - child = of_get_child_by_name(node, "dwc3"); > + child = of_get_compatible_child(node, "snps,dwc3"); > if (!child) { > dev_err(&pdev->dev, "failed to find dwc3 core node\n"); > ret = -ENODEV; > -- > 2.25.1 > This commit doesn't even apply to my tree. What branch is it against? confused, greg k-h
On 9/30/22 16:16, Patrice CHOTARD wrote: > > > On 9/30/22 13:48, Greg Kroah-Hartman wrote: >> On Fri, Sep 30, 2022 at 09:27:07AM +0200, patrice.chotard@foss.st.com wrote: >>> From: Patrice Chotard <patrice.chotard@foss.st.com> >>> >>> To ensure that child node is found, don't rely on child's node name >>> which can take different value, but on child's compatible name. >>> >>> Fixes: f5c5936d6b4d ("usb: dwc3: st: Fix node's child name") >>> >>> Cc: Jerome Audu <jerome.audu@st.com> >>> Reported-by: Felipe Balbi <felipe@balbi.sh> >>> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com> >>> --- >>> drivers/usb/dwc3/dwc3-st.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c >>> index 166b5bde45cb..fea5290de83f 100644 >>> --- a/drivers/usb/dwc3/dwc3-st.c >>> +++ b/drivers/usb/dwc3/dwc3-st.c >>> @@ -251,7 +251,7 @@ static int st_dwc3_probe(struct platform_device *pdev) >>> /* Manage SoftReset */ >>> reset_control_deassert(dwc3_data->rstc_rst); >>> >>> - child = of_get_child_by_name(node, "dwc3"); >>> + child = of_get_compatible_child(node, "snps,dwc3"); >>> if (!child) { >>> dev_err(&pdev->dev, "failed to find dwc3 core node\n"); >>> ret = -ENODEV; >>> -- >>> 2.25.1 >>> >> >> This commit doesn't even apply to my tree. What branch is it against? >> >> confused, > > Sorry... a v3 will be send, rebased on correct branch. > > Patrice > >> >> greg k-h
diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c index 166b5bde45cb..fea5290de83f 100644 --- a/drivers/usb/dwc3/dwc3-st.c +++ b/drivers/usb/dwc3/dwc3-st.c @@ -251,7 +251,7 @@ static int st_dwc3_probe(struct platform_device *pdev) /* Manage SoftReset */ reset_control_deassert(dwc3_data->rstc_rst); - child = of_get_child_by_name(node, "dwc3"); + child = of_get_compatible_child(node, "snps,dwc3"); if (!child) { dev_err(&pdev->dev, "failed to find dwc3 core node\n"); ret = -ENODEV;