diff mbox series

[v2] greatlakes: dts: Add Facebook greatlakes (AST2600) BMC

Message ID 20221007055008.3468691-1-Delphine_CC_Chiu@Wiwynn.com (mailing list archive)
State New, archived
Headers show
Series [v2] greatlakes: dts: Add Facebook greatlakes (AST2600) BMC | expand

Commit Message

Delphine CC Chiu Oct. 7, 2022, 5:50 a.m. UTC
Document the new compatibles used on Facebook Greatlakes

---
--- v2 - Add binding document
---
--- v1 - Initial draft
---

Signed-off-by: Bonnie Lo <Bonnie_Lo@Wiwynn.com>
---
 Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski Oct. 7, 2022, 7:08 a.m. UTC | #1
On 07/10/2022 07:50, Delphine CC Chiu wrote:
> Document the new compatibles used on Facebook Greatlakes
> 
> ---
> --- v2 - Add binding document
> ---
> --- v1 - Initial draft

????

That's not how patches are sent... About this I commented and you ignored.

This patch was a part of a patchset, so don't send it separately.

The subject is now corrupted - entirely wrong.

Best regards,
Krzysztof
Delphine CC Chiu Oct. 7, 2022, 9:31 a.m. UTC | #2
> Subject: Re: [PATCH v2] greatlakes: dts: Add Facebook greatlakes (AST2600) BMC
> 
>   Security Reminder: Please be aware that this email is sent by an external
> sender.
> 
> On 07/10/2022 07:50, Delphine CC Chiu wrote:
> > Document the new compatibles used on Facebook Greatlakes
> >
> > ---
> > --- v2 - Add binding document
> > ---
> > --- v1 - Initial draft
> 
> ????
> 
> That's not how patches are sent... About this I commented and you ignored.
> 
> This patch was a part of a patchset, so don't send it separately.
> 
> The subject is now corrupted - entirely wrong.

Could you please guide us to contribute?
[PATCH v4 1/2] greatlakes: dts: Add Facebook greatlakes (AST2600) BMC
--> This is for binding document.
[PATCH v4 2/2] greatlakes: dts: Add Facebook greatlakes (AST2600) BMC
--> This is for greatlakes DTS.
Is this correct?

> 
> Best regards,
> Krzysztof
Krzysztof Kozlowski Oct. 7, 2022, 12:35 p.m. UTC | #3
On 07/10/2022 11:31, Delphine_CC_Chiu/WYHQ/Wiwynn wrote:
>> Subject: Re: [PATCH v2] greatlakes: dts: Add Facebook greatlakes (AST2600) BMC
>>
>>   Security Reminder: Please be aware that this email is sent by an external
>> sender.
>>
>> On 07/10/2022 07:50, Delphine CC Chiu wrote:
>>> Document the new compatibles used on Facebook Greatlakes
>>>
>>> ---
>>> --- v2 - Add binding document
>>> ---
>>> --- v1 - Initial draft
>>
>> ????
>>
>> That's not how patches are sent... About this I commented and you ignored.
>>
>> This patch was a part of a patchset, so don't send it separately.
>>
>> The subject is now corrupted - entirely wrong.
> 
> Could you please guide us to contribute?
> [PATCH v4 1/2] greatlakes: dts: Add Facebook greatlakes (AST2600) BMC
> --> This is for binding document.
> [PATCH v4 2/2] greatlakes: dts: Add Facebook greatlakes (AST2600) BMC
> --> This is for greatlakes DTS.

The entire guide is already there:

https://elixir.bootlin.com/linux/v5.19.14/source/Documentation/process/submitting-patches.rst

https://elixir.bootlin.com/linux/v5.19.14/source/Documentation/process/4.Coding.rst
https://elixir.bootlin.com/linux/v5.19.14/source/Documentation/process/5.Posting.rst
https://elixir.bootlin.com/linux/v5.19.14/source/Documentation/process/6.Followthrough.rst
https://elixir.bootlin.com/linux/v5.19.14/source/Documentation/process/7.AdvancedTopics.rst

The patches are grouped together correctly, but still have wrong subjects.

Changelog is done like this:

https://lore.kernel.org/all/20220519073330.7187-1-krzysztof.kozlowski@linaro.org/

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
index 1895ce9de461..f12b94ddb9ec 100644
--- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
+++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
@@ -75,6 +75,7 @@  properties:
               - facebook,cloudripper-bmc
               - facebook,elbert-bmc
               - facebook,fuji-bmc
+              - facebook,greatlakes-bmc
               - ibm,everest-bmc
               - ibm,rainier-bmc
               - ibm,tacoma-bmc