| Message ID | 20221010133146.1430768-3-dan.scally@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Debix Model A board devicetree | expand |
Quoting Daniel Scally (2022-10-10 14:31:45) > Add an entry to the list of imx8mp boards denoting the Debix Model A > board from Polyhex Technology Co. > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com> > --- > Changes in v2: > > - Dropped 2gb suffix, added hyphens for readability (Laurent) > > Documentation/devicetree/bindings/arm/fsl.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > index 7431579ab0e8..fc0c8eb15114 100644 > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > @@ -931,6 +931,7 @@ properties: > - dh,imx8mp-dhcom-pdk2 # i.MX8MP DHCOM SoM on PDK2 board > - fsl,imx8mp-evk # i.MX8MP EVK Board > - gateworks,imx8mp-gw74xx # i.MX8MP Gateworks Board > + - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A (2GB) Board If we've dropped the 2gb suffix from the compatible string, does that mean we should drop it from the description too? I presume the implication is that we can support different sizes from the same compat string. > - toradex,verdin-imx8mp # Verdin iMX8M Plus Modules > - toradex,verdin-imx8mp-nonwifi # Verdin iMX8M Plus Modules without Wi-Fi / BT > - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules > -- > 2.34.1 >
Hi Kieran On 10/10/2022 14:56, Kieran Bingham wrote: > Quoting Daniel Scally (2022-10-10 14:31:45) >> Add an entry to the list of imx8mp boards denoting the Debix Model A >> board from Polyhex Technology Co. >> >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> >> Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com> >> --- >> Changes in v2: >> >> - Dropped 2gb suffix, added hyphens for readability (Laurent) >> >> Documentation/devicetree/bindings/arm/fsl.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml >> index 7431579ab0e8..fc0c8eb15114 100644 >> --- a/Documentation/devicetree/bindings/arm/fsl.yaml >> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml >> @@ -931,6 +931,7 @@ properties: >> - dh,imx8mp-dhcom-pdk2 # i.MX8MP DHCOM SoM on PDK2 board >> - fsl,imx8mp-evk # i.MX8MP EVK Board >> - gateworks,imx8mp-gw74xx # i.MX8MP Gateworks Board >> + - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A (2GB) Board > If we've dropped the 2gb suffix from the compatible string, does that > mean we should drop it from the description too? I presume the > implication is that we can support different sizes from the same compat > string. Argh! Yes, my bad - I'll fix that. > >> - toradex,verdin-imx8mp # Verdin iMX8M Plus Modules >> - toradex,verdin-imx8mp-nonwifi # Verdin iMX8M Plus Modules without Wi-Fi / BT >> - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules >> -- >> 2.34.1 >>
On Mon, Oct 10, 2022 at 02:57:35PM +0100, Dan Scally wrote: > On 10/10/2022 14:56, Kieran Bingham wrote: > > Quoting Daniel Scally (2022-10-10 14:31:45) > >> Add an entry to the list of imx8mp boards denoting the Debix Model A > >> board from Polyhex Technology Co. > >> > >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > >> Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com> > >> --- > >> Changes in v2: > >> > >> - Dropped 2gb suffix, added hyphens for readability (Laurent) > >> > >> Documentation/devicetree/bindings/arm/fsl.yaml | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > >> index 7431579ab0e8..fc0c8eb15114 100644 > >> --- a/Documentation/devicetree/bindings/arm/fsl.yaml > >> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > >> @@ -931,6 +931,7 @@ properties: > >> - dh,imx8mp-dhcom-pdk2 # i.MX8MP DHCOM SoM on PDK2 board > >> - fsl,imx8mp-evk # i.MX8MP EVK Board > >> - gateworks,imx8mp-gw74xx # i.MX8MP Gateworks Board > >> + - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A (2GB) Board > > > > If we've dropped the 2gb suffix from the compatible string, does that > > mean we should drop it from the description too? I presume the > > implication is that we can support different sizes from the same compat > > string. > > Argh! Yes, my bad - I'll fix that. What that change, Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > >> - toradex,verdin-imx8mp # Verdin iMX8M Plus Modules > >> - toradex,verdin-imx8mp-nonwifi # Verdin iMX8M Plus Modules without Wi-Fi / BT > >> - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml index 7431579ab0e8..fc0c8eb15114 100644 --- a/Documentation/devicetree/bindings/arm/fsl.yaml +++ b/Documentation/devicetree/bindings/arm/fsl.yaml @@ -931,6 +931,7 @@ properties: - dh,imx8mp-dhcom-pdk2 # i.MX8MP DHCOM SoM on PDK2 board - fsl,imx8mp-evk # i.MX8MP EVK Board - gateworks,imx8mp-gw74xx # i.MX8MP Gateworks Board + - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A (2GB) Board - toradex,verdin-imx8mp # Verdin iMX8M Plus Modules - toradex,verdin-imx8mp-nonwifi # Verdin iMX8M Plus Modules without Wi-Fi / BT - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules