diff mbox series

[v5,2/2] net: stmmac: Enable mac_managed_pm phylink config

Message ID 20221013133904.978802-3-shenwei.wang@nxp.com (mailing list archive)
State New, archived
Headers show
Series net: phylink: add phylink_set_mac_pm() helper | expand

Commit Message

Shenwei Wang Oct. 13, 2022, 1:39 p.m. UTC 
Enable the mac_managed_pm configuration in the phylink_config
structure to avoid the kernel warning during system resume.

'Fixes: 47ac7b2f6a1f ("net: phy: Warn about incorrect
mdio_bus_phy_resume() state")'

Signed-off-by: Shenwei Wang <shenwei.wang@nxp.com>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 +
 1 file changed, 1 insertion(+)

--
2.34.1

Comments

Florian Fainelli Oct. 13, 2022, 6:48 p.m. UTC | #1 
On 10/13/22 06:39, Shenwei Wang wrote:
> Enable the mac_managed_pm configuration in the phylink_config
> structure to avoid the kernel warning during system resume.
> 
> 'Fixes: 47ac7b2f6a1f ("net: phy: Warn about incorrect
> mdio_bus_phy_resume() state")'
> 
> Signed-off-by: Shenwei Wang <shenwei.wang@nxp.com>

Same comment as patch #1, the Fixes tag is improperly formatted and does 
not require the use of ' before and after.

With that fixed:

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
diff mbox series

Patch

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 65c96773c6d2..8273e6a175c8 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -1214,6 +1214,7 @@  static int stmmac_phy_setup(struct stmmac_priv *priv)
 	if (priv->plat->tx_queues_to_use > 1)
 		priv->phylink_config.mac_capabilities &=
 			~(MAC_10HD | MAC_100HD | MAC_1000HD);
+	priv->phylink_config.mac_managed_pm = true;

 	phylink = phylink_create(&priv->phylink_config, fwnode,
 				 mode, &stmmac_phylink_mac_ops);