From patchwork Sun Oct 16 14:39:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dorota Czaplejewicz X-Patchwork-Id: 13007817 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A164C433FE for ; Sun, 16 Oct 2022 14:42:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:Message-ID:Subject:To:From:Date:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=5WH05ZqTfoK1U9FiCExxv2pgsBTKBxOfwnJCDh8QY70=; b=GRU uFEEpkakMcEPcj6lCSlfzZnEQlzqspHBDK1jwDyZny1CjXunv0wdasG8l5TXQ5CjoFysLFugJm7jb BBu3evFuQSNgdXB4WHX1tRDI7L/JAw9xr7enD+oqpnudylBVGD6GQi0xZkqiVztoAkxa3eSm3UPXZ 4/IDBU/C1dDtx7TWLTNWCu4gqmx5VEgdletdn27RrdPp3o7/PmgZuBUEMGKx2LkCZbEnA8hMDYv/z FThGKu9Q83dSWP4NbG03qhzVyLpBNPzLBOZkLu0SoaDGvxxFaFOAW2pnEdjkqBn3homtIGRGWlWM9 /+hDrVVBvtjhyFoODvorfUI0IO4dLsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ok4of-001nyV-9U; Sun, 16 Oct 2022 14:40:37 +0000 Received: from comms.puri.sm ([159.203.221.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ok4oc-001nx7-Ef for linux-arm-kernel@lists.infradead.org; Sun, 16 Oct 2022 14:40:35 +0000 Received: from localhost (localhost [127.0.0.1]) by comms.puri.sm (Postfix) with ESMTP id AE8D7DF919; Sun, 16 Oct 2022 07:40:27 -0700 (PDT) Received: from comms.puri.sm ([127.0.0.1]) by localhost (comms.puri.sm [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Zy-5r13ibeDh; Sun, 16 Oct 2022 07:40:26 -0700 (PDT) Date: Sun, 16 Oct 2022 16:39:28 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=puri.sm; s=comms; t=1665931226; bh=W0L64e3HzKHkWHGerf0WHl/H2DONAMdk6gTSQ4fNdTQ=; h=Date:From:To:Subject:From; b=MlCG9O2oVZUmje8MmQvatYPJUdnaXr005yNJZIFe70CU1pElMsar9IHaIt+kmD2lw 7IXa+LsfgOdhuHMWny2WNuY2K5w/LtsH2Z+qZL0TQSCb5/N9sC6mf80M7w1PpFegRj vZcjWqykUs8dpv7s3wuVXTGxTZgxBK3kUS2S+i1qg8Ev8qqbh/cjVTMcS+u48SJkHK BC0RxNUxid/QIWxyXHqacrQsrf6v0rBBXDgtkB8LWY1fh9zHTO8i2tsEmbmc44fWfH tRUn96ccfNtpmqDlTmKtJI3BeVESX+G1AIz2X1fbfNW464Ro4ZH7lS29HdxSSxCReJ Y5ygQj6ugN32w== From: Dorota Czaplejewicz To: Laurent Pinchart , Steve Longerbeam , Philipp Zabel , Mauro Carvalho Chehab , Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@puri.sm, phone-devel@vger.kernel.org Subject: [PATCHv3 1/1 RESEND] media: imx: Round line size to 4 bytes Message-ID: <20221016163928.1ef0a4fe.dorota.czaplejewicz@puri.sm> Organization: Purism MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221016_074034_518268_6B37EFF1 X-CRM114-Status: GOOD ( 11.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Section 13.7.6.13 "CSI Image Parameter Register" of the i.MX 8M Quad Applications Processors Reference Manual states that the line size should be divisible by 8 bytes. However, the hardware also accepts sizes divisible by 4 bytes, which are needed to fully utilize the S5K3L6XX sensors. This patch accepts line sizes divisible by 4 bytes. Signed-off-by: Dorota Czaplejewicz --- Hello, the Librem 5 is using an out-of-tree driver for s5k3l6xx, and rounding to 4 is optimal to operate it. This revision improves the commit message. Cheers, Dorota Czaplejewicz drivers/staging/media/imx/imx7-media-csi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c index a0553c24cce4..af821b410c3f 100644 --- a/drivers/staging/media/imx/imx7-media-csi.c +++ b/drivers/staging/media/imx/imx7-media-csi.c @@ -999,10 +999,10 @@ static int imx7_csi_mbus_fmt_to_pix_fmt(struct v4l2_pix_format *pix, } /* Round up width for minimum burst size */ - width = round_up(mbus->width, 8); + width = round_up(mbus->width, 4); /* Round up stride for IDMAC line start address alignment */ - stride = round_up((width * cc->bpp) >> 3, 8); + stride = round_up((width * cc->bpp) >> 3, 4); pix->width = width; pix->height = mbus->height;