From patchwork Fri May 5 11:25:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 13232476 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0653C7EE22 for ; Fri, 5 May 2023 11:28:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GY81mb00wC4xI3NDJsb9Hann6jZa0HgQOdlKMxoS/oI=; b=J0r9dAbi2xUA0E 7Vkn57UZtGkD4JiPh3haID47wHrct9so8m9rAEKxqsooH1rEfqQ5H9WEkK7jItzbPeWFDka2SiS82 /rWz5vA/0o5PvryiTmsbLr8k/nPD2Usdpd6Mp3Y6opU4qFrPmDTst5tge34ALSPrq8l1fpAo9SF5I hvRZUF9bu3KfMSPYyk5bXW0tAsPg3eb4dGQRrrRswtK6OJnu2+1dnLd8pGQYV0FDlsMf9JwbnIcgh r+nQfula7LawuHf5Yz9ukMEKTmXXfYYDsOQZtD8EDWwhekWXKzOaunaHGvOo4BgvbQ8C9jklQTL8L urEBk3LCgR2zKUrWAlPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1putae-00AfRc-2p; Fri, 05 May 2023 11:27:08 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1putab-00AfPr-2g for linux-arm-kernel@lists.infradead.org; Fri, 05 May 2023 11:27:07 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 848DE32008FB; Fri, 5 May 2023 07:27:04 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Fri, 05 May 2023 07:27:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1683286024; x=1683372424; bh=9GaGoMGjEvM3nBtYXQHVW2cO1D65NmKSgYW AE7A71G0=; b=iuzOh4epA/+cZ/jT4D1/ya4lHkR9D4ldeGEEV+g9SofjsWkK1MQ 0xDlRdBddjvfIjHbrYa6v0Wn8jdxw6CRlxZUg5XlgRt6yJu6CpJtP+l6TkiPeD9E msuVypBB7yweyQC4TjlQRQUcXxUP+XiTaR23UMaERI3QPD/xY1aSoKn3t7uX/K+c jD2hPI0MryRi04STZKANsxy48v33aU5q1VTqHE0XQ82oTOi5ZfTYeygnYYJGhlLR YTHMpDV6RSBklioB23M7zqYDHaMqUJ0bfn9XUinGteN5+BiG7zOo+lxWrLdKTqQg Nw4rtdZ/lhpyOJrGAgbUkjbj6csi6TaW8QQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1683286024; x=1683372424; bh=9GaGoMGjEvM3nBtYXQHVW2cO1D65NmKSgYW AE7A71G0=; b=NoVfxEM3t3n5K9hegXzp46B91Aa0cKg6to74dgiULO+vckbvLap FgDGOqeK8TWWmGfbSZfq2+f05g8OZAVx+qAx2Yn4yuB1aMrZZl7s1A7ZdScMGuOJ QknUn6uXVFu8caiQEjOdRFnIrNu4h8K2N7D8ka/sTvKy72faTIyEXRgFTFiTk7lL y1b0eNzUd+zD1WPJgDhUmS18caILVU8F+Is/WFnGTyaL5/WPtDaA6NpmvAhulO/w K2SQUQPfMnLI5+TsjOrXlMnUtGCYwLN4M/11a8saghTe4aF0qLbfcZVypYYzECEB XBKmLn8ajKxtcKj8ZffhPdrKiKJ/P/4DPwQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeefvddggedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephfffufggtgfgkfhfjgfvvefosehtjeertdertdejnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepvedvleeijeegvdekffehkeehieelhfeggfffheetkeeuledvtdeuffeh teeltdffnecuvehluhhsthgvrhfuihiivgepheenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 5 May 2023 07:27:03 -0400 (EDT) From: Maxime Ripard Date: Fri, 05 May 2023 13:25:29 +0200 Subject: [PATCH v4 27/68] clk: imx: fixup-mux: Add a determine_rate hook MIME-Version: 1.0 Message-Id: <20221018-clk-range-checks-fixes-v4-27-971d5077e7d2@cerno.tech> References: <20221018-clk-range-checks-fixes-v4-0-971d5077e7d2@cerno.tech> In-Reply-To: <20221018-clk-range-checks-fixes-v4-0-971d5077e7d2@cerno.tech> To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, Maxime Ripard , Abel Vesa , Fabio Estevam , Peng Fan , Sascha Hauer , Shawn Guo , linux-arm-kernel@lists.infradead.org, NXP Linux Team , Pengutronix Kernel Team X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2211; i=maxime@cerno.tech; h=from:subject:message-id; bh=fVDmwUo+ONYakLHIku1FGCJ/Cp1OnwLFtksw10VZRy8=; b=owGbwMvMwCX2+D1vfrpE4FHG02pJDCkhzxdX1nH/5i4VvBVRx6GwIye/VFO78nKMHefJplmXFpZy rgvuKGVhEONikBVTZIkRNl8Sd2rW6042vnkwc1iZQIYwcHEKwERO5DEyXGwV0ZimHperz759Rv9uv4 VF/k65z57kbWrt/dw7oe33Xob/Gc6e6875RojWRyUUzl5fL8Hyfufud60LY+9+LJ3RtrWECwA= X-Developer-Key: i=maxime@cerno.tech; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230505_042705_910689_13BB0E92 X-CRM114-Status: GOOD ( 16.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The iMX fixup mux clock implements a mux with a set_parent hook, but doesn't provide a determine_rate implementation. This is a bit odd, since set_parent() is there to, as its name implies, change the parent of a clock. However, the most likely candidates to trigger that parent change are either the assigned-clock-parents device tree property or a call to clk_set_rate(), with determine_rate() figuring out which parent is the best suited for a given rate. The other trigger would be a call to clk_set_parent(), but it's far less used, and it doesn't look like there's any obvious user for that clock. However, the upstream device trees seem to use assigned-clock-parents on that clock to force the parent at boot time, so it's likely that the author intent was to force the parent through the device tree and prevent any reparenting but through an explicit call to clk_set_parent(). This case would be equivalent to setting the determine_rate implementation to clk_hw_determine_rate_no_reparent(). Indeed, if no determine_rate implementation is provided, clk_round_rate() (through clk_core_round_rate_nolock()) will call itself on the parent if CLK_SET_RATE_PARENT is set, and will not change the clock rate otherwise. Cc: Abel Vesa Cc: Fabio Estevam Cc: Peng Fan Cc: Sascha Hauer Cc: Shawn Guo Cc: linux-arm-kernel@lists.infradead.org Cc: NXP Linux Team Cc: Pengutronix Kernel Team Signed-off-by: Maxime Ripard --- drivers/clk/imx/clk-fixup-mux.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/imx/clk-fixup-mux.c b/drivers/clk/imx/clk-fixup-mux.c index c82401570c84..b48701864ef0 100644 --- a/drivers/clk/imx/clk-fixup-mux.c +++ b/drivers/clk/imx/clk-fixup-mux.c @@ -60,6 +60,7 @@ static int clk_fixup_mux_set_parent(struct clk_hw *hw, u8 index) } static const struct clk_ops clk_fixup_mux_ops = { + .determine_rate = clk_hw_determine_rate_no_reparent, .get_parent = clk_fixup_mux_get_parent, .set_parent = clk_fixup_mux_set_parent, };