From patchwork Fri May 5 11:25:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 13232479 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 819D5C7EE2C for ; Fri, 5 May 2023 11:28:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/a/yQNDw2obMATIPI6DuaV53nfgq9q+vIPqNQYja0ZI=; b=sybcMy8YmPse+J e4lc6JhbDXc7lSNHIMSH4DStbR13WFUWvuU76togFdV8wb+D5iRQLuUijufq+SVe/JavtlSQilxkg c9RzJ3fpAy/VvksBktYfau0VjrNKB0s088BnaRnVKhN8hNxL3N4w+5iiCLG8lr4j5FOxICf7PTtHm eGKRdE5QxbQgB4zgN2pdBmY4Pz3z9zZWZdLKJ8I8p6545e1+4GF4j1hJGL41DB7/TpHPAzu3G00cz YWoKdKr9QAtq6Hv+GVZLBvgntbH5pJtLbVDlaqei/cTxXoNtV8CURm/qgh2Ko/2hfJJ8qHAWyvPqc jUqzehlGQ0GEO9u3XbLQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1putax-00AfdZ-39; Fri, 05 May 2023 11:27:28 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1putau-00Afb5-14 for linux-arm-kernel@lists.infradead.org; Fri, 05 May 2023 11:27:25 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 4710F3200907; Fri, 5 May 2023 07:27:23 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Fri, 05 May 2023 07:27:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1683286042; x=1683372442; bh=S/HR25t5MMz/iMAs8j1aFma0SMCGKNR7/Wi h/qTo4iU=; b=IwOxUqPLa60ar1P6+aJ931QDqsVWsUHiwB1s0YvELFe8ZH1ijwO ThpDrMVDAP7UKNm6pMvOgWOKurJz1oBhQqAh4iYxEPd3iWsP7NjFtXKYm548B4Xv aJwq0L/o3fmx0OkVArKntS/2cZ6W1hBfRJibXUfk5GxCsz3kRkGhiU7O7nXzh8jz LagfOBkveVd7f3h6rZbvNN6f/cI5o0G+vAoNqCeq+jw3Uls+8xYPbU4p0KJ7B93t Z7pTTlXXOf35LvNYjaWBL0g4vyYdrttN50y8NFBRX9QnsAjJ+8EkhOiXRg2dg1ka fd4/85zz53bpKcxSFKIlSYkK/iPPqeBNbsA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1683286042; x=1683372442; bh=S/HR25t5MMz/iMAs8j1aFma0SMCGKNR7/Wi h/qTo4iU=; b=IleKLDRtqvEID2O9c9UeRODSr62k0QTNO56AwrfiZFVc9I4lCNh q4tjXW/DUjA9wgVPEwrbdCnNMSb5ksoeIS6VywUbHe2tQz5yOfwd7yC7lMbY6o7V 0nXdu9/krK+oUNLHl2MYZn7OAyshjfl1WYdrBw4/6bpeKWp6dlzR9WucvAy22uhm IA5QHuvTFPp5I/v7j2w4O4RzdbpGsSFKD6TcaBpT0HgFsBjzyeZeqe7eE0sPwlm/ aFUOKWWfXnSy37/bel+5wq0n7ipKhQG5HMqyt6PWy0Zmk7Pz0rAE//sSbYi755Dd SbWTa/c5hPjwtZ2HnpoCNF0p5HwYRHf18LA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeefvddggedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephfffufggtgfgkfhfjgfvvefosehtjeertdertdejnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepvedvleeijeegvdekffehkeehieelhfeggfffheetkeeuledvtdeuffeh teeltdffnecuvehluhhsthgvrhfuihiivgepkeenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 5 May 2023 07:27:22 -0400 (EDT) From: Maxime Ripard Date: Fri, 05 May 2023 13:25:35 +0200 Subject: [PATCH v4 33/68] clk: stm32: core: Add a determine_rate hook MIME-Version: 1.0 Message-Id: <20221018-clk-range-checks-fixes-v4-33-971d5077e7d2@cerno.tech> References: <20221018-clk-range-checks-fixes-v4-0-971d5077e7d2@cerno.tech> In-Reply-To: <20221018-clk-range-checks-fixes-v4-0-971d5077e7d2@cerno.tech> To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, Maxime Ripard , Alexandre Torgue , Maxime Coquelin , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2218; i=maxime@cerno.tech; h=from:subject:message-id; bh=fWYhKhv/wFYwQwGVziH2GFGzuOmOsKzPh9vOFbAKgeU=; b=owGbwMvMwCX2+D1vfrpE4FHG02pJDCkhz5fY8m45Jmf+SZ/rxq/8MvYOr+Lu2ccfWq9fK6vwdOaL uys7OkpZGMS4GGTFFFlihM2XxJ2a9bqTjW8ezBxWJpAhDFycAjARbmWG/2VbpnbqBS1+nNteLCocwH HlvOl9dcmpJeF98/YUe3x8spHhf3n6ScEv+l/FCue6xW/4vnN61jGpzK3J65SWab170V0WxA0A X-Developer-Key: i=maxime@cerno.tech; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230505_042724_402893_CF748A03 X-CRM114-Status: GOOD ( 15.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The STM32 mux clock implements a mux with a set_parent hook, but doesn't provide a determine_rate implementation. This is a bit odd, since set_parent() is there to, as its name implies, change the parent of a clock. However, the most likely candidate to trigger that parent change is a call to clk_set_rate(), with determine_rate() figuring out which parent is the best suited for a given rate. The other trigger would be a call to clk_set_parent(), but it's far less used, and it doesn't look like there's any obvious user for that clock. So, the set_parent hook is effectively unused, possibly because of an oversight. However, it could also be an explicit decision by the original author to avoid any reparenting but through an explicit call to clk_set_parent(). The latter case would be equivalent to setting the flag CLK_SET_RATE_NO_REPARENT, together with setting our determine_rate hook to __clk_mux_determine_rate(). Indeed, if no determine_rate implementation is provided, clk_round_rate() (through clk_core_round_rate_nolock()) will call itself on the parent if CLK_SET_RATE_PARENT is set, and will not change the clock rate otherwise. And if it was an oversight, then we are at least explicit about our behavior now and it can be further refined down the line. Since the CLK_SET_RATE_NO_REPARENT flag was already set though, it seems unlikely. Cc: Alexandre Torgue Cc: Maxime Coquelin Cc: linux-arm-kernel@lists.infradead.org Cc: linux-stm32@st-md-mailman.stormreply.com Signed-off-by: Maxime Ripard --- drivers/clk/stm32/clk-stm32-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/stm32/clk-stm32-core.c b/drivers/clk/stm32/clk-stm32-core.c index 45a279e73779..3247539683c9 100644 --- a/drivers/clk/stm32/clk-stm32-core.c +++ b/drivers/clk/stm32/clk-stm32-core.c @@ -275,6 +275,7 @@ static int clk_stm32_mux_set_parent(struct clk_hw *hw, u8 index) } const struct clk_ops clk_stm32_mux_ops = { + .determine_rate = __clk_mux_determine_rate, .get_parent = clk_stm32_mux_get_parent, .set_parent = clk_stm32_mux_set_parent, };