From patchwork Tue Oct 18 15:35:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Wunderlich X-Patchwork-Id: 13010776 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D26FC43217 for ; Tue, 18 Oct 2022 15:40:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=T9fDzEs38MZjYQCi7lKSUsKpXnhH+Mf4qa+LlYT+HDI=; b=mNxz20CFosXmyM EKM2wxq4HJS8UWafcSEn5TPINXfdiKJx8buQPurbPuOOa1F3z3gok4XHkoUmBDLXSk1B1ngY9E+8l lS9eq7hQcoXad/cZ9pkHZCxiuxxSQ+I3px49UuzSF9Gw4VBsTzE0vUm3Xg/rne0yIyY2pKUzWJU6t 0IDwQ5wJdEZDC2L3l3oeSAm7Szf6is10PzfCsBxDQF8OTfqSQKjm41KX73yst9a+D4yBN/BWjhD46 wWS8rUZs0IgDyuX7JNBH+hF7OsJifD+T7mgZ3tNWa6UUUet9ryqFDFusIWNWITEJBLh5mhYZkij6q sY93+Js4XhLYFFl32T9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1okogh-007nwX-O7; Tue, 18 Oct 2022 15:39:27 +0000 Received: from mxout2.routing.net ([2a03:2900:1:a::b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1okocu-007knI-5t; Tue, 18 Oct 2022 15:35:34 +0000 Received: from mxbox4.masterlogin.de (unknown [192.168.10.79]) by mxout2.routing.net (Postfix) with ESMTP id AEDE061660; Tue, 18 Oct 2022 15:35:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailerdienst.de; s=20200217; t=1666107323; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=8ERP7oqCQlb3yIxMKGW/Oz7naZX8fIcg5ZLF84iTXro=; b=GlgOmTQo3HgsRhoPqVLsLubp7CHDgsIFxY7fyawWUgiQrD88TP5S99flVMENJ+HPzrJqJy Yxs8jWBwfEa74QR+x+lrfHkPs5CsXYCZQD8oQZVfH18eRYjp18ajrAbjrC0KakEHMSYEfS 8S27f+fLKn4XMMrbDIc3YGPgToPobmU= Received: from frank-G5.. (fttx-pool-80.245.77.116.bambit.de [80.245.77.116]) by mxbox4.masterlogin.de (Postfix) with ESMTPSA id 229178088B; Tue, 18 Oct 2022 15:35:22 +0000 (UTC) From: Frank Wunderlich To: linux-mediatek@lists.infradead.org Cc: Alexander Couzens , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , Russell King , "Russell King (Oracle)" , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Frank Wunderlich Subject: [PATCH] net: mtk_sgmii: implement mtk_pcs_ops Date: Tue, 18 Oct 2022 17:35:06 +0200 Message-Id: <20221018153506.60944-1-linux@fw-web.de> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Mail-ID: 5418bcaa-6979-443d-8992-e1535efa5739 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221018_083532_601663_5808EEB7 X-CRM114-Status: GOOD ( 12.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Alexander Couzens Implement mtk_pcs_ops for the SGMII pcs to read the current state of the hardware. Signed-off-by: Alexander Couzens Signed-off-by: Frank Wunderlich Fixes: 14a44ab0330d ("net: mtk_eth_soc: partially convert to phylink_pcs") --- without this Patch i get this trace in 6.1-rc1 when enabling the left sfp (eth1) on bpi-r3 (crash happens in phylink core because a NULL-pointer, so fixes-Tag is a guess): [ 108.302810] Unable to handle kernel execute from non-executable memory at virtual address 0000000000000000 [ 108.312462] Mem abort info: [ 108.315263] ESR = 0x0000000086000005 [ 108.319003] EC = 0x21: IABT (current EL), IL = 32 bits [ 108.324335] SET = 0, FnV = 0 [ 108.327378] EA = 0, S1PTW = 0 [ 108.330505] FSC = 0x05: level 1 translation fault [ 108.335375] user pgtable: 4k pages, 39-bit VAs, pgdp=00000000419be000 [ 108.341798] [0000000000000000] pgd=0000000000000000, p4d=0000000000000000, pu d=0000000000000000 [ 108.350489] Internal error: Oops: 0000000086000005 [#1] SMP [ 108.356047] Modules linked in: cdc_mbim cdc_ncm cdc_wdm cdc_ether qcserial us a_wwan usbnet usbser a Mmeisis ge from syslogd@bpi-r3 at Aug 7 15:26:54 ... kernel:[ 108.350489] Internal error: Oops: 0000000086000005 [#1] SMP [ 108.376743] CPU: 3 PID: 8 Comm: kworker/u8:0 Not tainted 6.0.0-bpi-r3 #1 [ 108.383461] Hardware name: Bananapi BPI-R3 (sdmmc) (DT) [ 108.388671] Workqueue: events_power_efficient phylink_resolve [ 108.394411] pstate: 60400005 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 108.401355] pc : 0x0 [ 108.403531] lr : phylink_mac_pcs_get_state+0x7c/0x100 [ 108.408572] sp : ffffffc00963bd00 [ 108.411873] x29: ffffffc00963bd00 x28: 0000000000000000 x27: 0000000000000000 [ 108.418994] x26: ffffff80000ed074 x25: ffffff800001c105 x24: 0000000000000000 [ 108.426116] x23: ffffff80022f8cd8 x22: ffffff80022f8d30 x21: ffffff80022f8c00 [ 108.433236] x20: 0000000000000000 x19: ffffff8000126040 x18: 0000000000000000 [ 108.440357] x17: 0000000000000000 x16: 0000000000000000 x15: 0000000000000000 [ 108.447478] x14: ffffffffffffffff x13: 0000000000000030 x12: 0101010101010101 [ 108.454598] x11: 7f7f7f7f7f7f7f7f x10: fefefefefefefeff x9 : ffffff80000ed07c [ 108.461720] x8 : fefefefefefefeff x7 : 0000000000000017 x6 : ffffff80000ed074 [ 108.468840] x5 : 0000000000000000 x4 : 0000020000006440 x3 : 00000000fffffffa [ 108.475960] x2 : 0000000000000000 x1 : ffffffc00963bd80 x0 : ffffff80014c3ab0 [ 108.483082] Call trace: [ 108.485516] 0x0 [ 108.487344] phylink_resolve+0x248/0x520 [ 108.491256] process_one_work+0x204/0x478 [ 108.495256] worker_thread+0x148/0x4c0 [ 108.498993] kthread+0xdc/0xe8 [ 108.502037] ret_from_fork+0x10/0x20 [ 108.505608] Code: bad PC value [ 108.508652] ---[ end trace 0000000000000000 ]--- [ 108.513255] Kernel panic - not syncing: Oops: Fatal exception [ 108.518984] SMP: stopping secondary CPUs [ 108.522894] Kernel Offset: disabled [ 108.526369] CPU features: 0x00000,00800084,0000420b [ 108.531232] Memory Limit: none [ 108.534274] Rebooting in 1 seconds.. --- drivers/net/ethernet/mediatek/mtk_sgmii.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/net/ethernet/mediatek/mtk_sgmii.c b/drivers/net/ethernet/mediatek/mtk_sgmii.c index 736839c84130..9614973fd9c4 100644 --- a/drivers/net/ethernet/mediatek/mtk_sgmii.c +++ b/drivers/net/ethernet/mediatek/mtk_sgmii.c @@ -122,10 +122,25 @@ static void mtk_pcs_link_up(struct phylink_pcs *pcs, unsigned int mode, regmap_write(mpcs->regmap, SGMSYS_SGMII_MODE, val); } +static void mtk_pcs_get_state(struct phylink_pcs *pcs, struct phylink_link_state *state) +{ + struct mtk_pcs *mpcs = pcs_to_mtk_pcs(pcs); + unsigned int val; + + regmap_read(mpcs->regmap, mpcs->ana_rgc3, &val); + state->speed = val & RG_PHY_SPEED_3_125G ? SPEED_2500 : SPEED_1000; + + regmap_read(mpcs->regmap, SGMSYS_PCS_CONTROL_1, &val); + state->an_complete = !!(val & SGMII_AN_COMPLETE); + state->link = !!(val & SGMII_LINK_STATYS); + state->pause = 0; +} + static const struct phylink_pcs_ops mtk_pcs_ops = { .pcs_config = mtk_pcs_config, .pcs_an_restart = mtk_pcs_restart_an, .pcs_link_up = mtk_pcs_link_up, + .pcs_get_state = mtk_pcs_get_state, }; int mtk_sgmii_init(struct mtk_sgmii *ss, struct device_node *r, u32 ana_rgc3)