diff mbox series

arch: crash: Remove duplicate declaration in smp.h

Message ID 20221020135913.2850550-1-guoren@kernel.org (mailing list archive)
State New, archived
Headers show
Series arch: crash: Remove duplicate declaration in smp.h | expand

Commit Message

Guo Ren Oct. 20, 2022, 1:59 p.m. UTC 
From: Guo Ren <guoren@linux.alibaba.com>

Remove crash_smp_send_stop declarations in arm64, x86 asm/smp.h
which has been in include/linux/smp.h since 6f1f942cd5fb ("smp:
kernel/panic.c - silence warnings").

Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
Signed-off-by: Guo Ren <guoren@kernel.org>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Thomas Gleixner <tglx@linutronix.de>
---

This patch is separated from the series [1] to let maintainer take
easily. It still needs a Acked-by from x86 side, hope it could be
soon done.

[1] https://lore.kernel.org/linux-riscv/20220921033134.3133319-1-guoren@kernel.org/
---
 arch/arm64/include/asm/smp.h | 1 -
 arch/x86/include/asm/crash.h | 1 -
 2 files changed, 2 deletions(-)

Comments

Borislav Petkov Oct. 20, 2022, 2:32 p.m. UTC | #1 
On Thu, Oct 20, 2022 at 09:59:13AM -0400, guoren@kernel.org wrote:
> diff --git a/arch/x86/include/asm/crash.h b/arch/x86/include/asm/crash.h
> index 8b6bd63530dc..6a9be4907c82 100644
> --- a/arch/x86/include/asm/crash.h
> +++ b/arch/x86/include/asm/crash.h
> @@ -7,6 +7,5 @@ struct kimage;
>  int crash_load_segments(struct kimage *image);
>  int crash_setup_memmap_entries(struct kimage *image,
>  		struct boot_params *params);
> -void crash_smp_send_stop(void);
>  
>  #endif /* _ASM_X86_CRASH_H */

Acked-by: Borislav Petkov <bp@suse.de>
Guo Ren Oct. 24, 2022, 10:07 a.m. UTC | #2 
On Thu, Oct 20, 2022 at 10:32 PM Borislav Petkov <bp@alien8.de> wrote:
>
> On Thu, Oct 20, 2022 at 09:59:13AM -0400, guoren@kernel.org wrote:
> > diff --git a/arch/x86/include/asm/crash.h b/arch/x86/include/asm/crash.h
> > index 8b6bd63530dc..6a9be4907c82 100644
> > --- a/arch/x86/include/asm/crash.h
> > +++ b/arch/x86/include/asm/crash.h
> > @@ -7,6 +7,5 @@ struct kimage;
> >  int crash_load_segments(struct kimage *image);
> >  int crash_setup_memmap_entries(struct kimage *image,
> >               struct boot_params *params);
> > -void crash_smp_send_stop(void);
> >
> >  #endif /* _ASM_X86_CRASH_H */
>
> Acked-by: Borislav Petkov <bp@suse.de>
Thx.

Hi, Arnd

Because it crosses the architecture, could you take this in your next-tree?

>
> --
> Regards/Gruss,
>     Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette
diff mbox series

Patch

diff --git a/arch/arm64/include/asm/smp.h b/arch/arm64/include/asm/smp.h
index fc55f5a57a06..a108ac93fd8f 100644
--- a/arch/arm64/include/asm/smp.h
+++ b/arch/arm64/include/asm/smp.h
@@ -141,7 +141,6 @@  static inline void cpu_panic_kernel(void)
  */
 bool cpus_are_stuck_in_kernel(void);
 
-extern void crash_smp_send_stop(void);
 extern bool smp_crash_stop_failed(void);
 extern void panic_smp_self_stop(void);
 
diff --git a/arch/x86/include/asm/crash.h b/arch/x86/include/asm/crash.h
index 8b6bd63530dc..6a9be4907c82 100644
--- a/arch/x86/include/asm/crash.h
+++ b/arch/x86/include/asm/crash.h
@@ -7,6 +7,5 @@  struct kimage;
 int crash_load_segments(struct kimage *image);
 int crash_setup_memmap_entries(struct kimage *image,
 		struct boot_params *params);
-void crash_smp_send_stop(void);
 
 #endif /* _ASM_X86_CRASH_H */