From patchwork Mon Oct 24 12:16:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 13017513 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BECD8ECAAA1 for ; Mon, 24 Oct 2022 12:17:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=YvseJZt6YaxYaKDekQH/TleLHuiiIXT8+xYQk3TN1NI=; b=eiAc6LRehl8l8N oW+Ujq6xEYmTYUdbIyndcq+9gIAmw8BFnGBN6Mx1lxYS8W8jt3s06l2A5biLZRkCs2X5j/vg2/jru xA2S2V+07+BSOPXgzCU6i32IVqQs2i5EEOSYs1AytB80ToIwK/XEF6idUk+tmJv55QjN4VbRHnfWd KaCYqz43r2NXfkKvEdEpsBptQnM4HAOP4zJtX3cRAL4AVnehBNrjwgduOoAtztGMgRZ/VImMHvC4d xZ1KlZgi8dUTuVeIoZ9fMTp8vor1/lPjSJsikZhiAQnhYN/T95zwHxZOQEvu3IECEM0oE2ZlH++ex LHV7fZhIdA+sgrqGSE8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1omwNM-001JzD-UU; Mon, 24 Oct 2022 12:16:17 +0000 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1omwNJ-001Jxb-Pw for linux-arm-kernel@lists.infradead.org; Mon, 24 Oct 2022 12:16:15 +0000 Received: by mail-lf1-x135.google.com with SMTP id g1so16341233lfu.12 for ; Mon, 24 Oct 2022 05:16:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=KcmwET9ycGmnRj9dlzSF/IaZ72SsXSbPQdLAIqBeDMc=; b=TkypTwkRyC+IEQfLJkO+AxzeecYSVuVzd/ZFrRP1xRW9uJVu0btsXMNfEeMzHNkxfh C3FwJivHL9WupWbeclBsjHhoNC8xUJosd8kt4bC+V7VKkcCUfyVrhCX79auUCag9VbK6 Xz75zLELtpW5109YZu6x4ahA6HUB9OFrV4jUPJvVHR4Hscyf0AjekuDrimBKPhcfIoqT OmNJcBX9i+Qjy7r0IZDwpqvLc3AvSUOeeEKByNbaqNgbQxnrphRAsux+uMBaj9YwTBfd yumx3/s1w6l6kA8uZ/hZI9kyZGAkYN9nz78niScaMKdRZGYMPjuua1vyQP9fkKQvyski WjKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KcmwET9ycGmnRj9dlzSF/IaZ72SsXSbPQdLAIqBeDMc=; b=LitBOi4LpgPymWa+ZRLGBhDJj73GmhqxFAehJqOSjQlwFgY7Hdjirl2Q7F8vIppRPA lEMLwqmFpOjTsrKghzfPjRaKllPvEGo3iu1DNFz/YnydMEtDE3NlbUhp+Hnbjv6eeJpo C7eHHlhjkWzawTXAAPxGi+V9uOGqIBJlEdZFzOAgav4eqDFhG5jBgYqJz2xWxgEbjZS1 bQY49jdB3RpH7ReQ+K1R8vPaZIeDp3bKv1y/otQB/1fzC0vsXROI1oY8b/O8g1sQHr5i BG/HtGfac/8pe25NYB5TiDDIq5yljixzXZZyvZFoxuI/JXE3YmnHMlYwrXQaaAImv0Y2 NxXQ== X-Gm-Message-State: ACrzQf0qCdwbA7TZWYCrrJN5U1VhU7MCEBVFrQaBmMifbdPiIS9DuXgV /4OSkYkW88UllPXj04QntXMvfg== X-Google-Smtp-Source: AMsMyM45EyK5jQDu4AOnll/E1IFdddpVGBZ0J1eUwpG9UPsnJI5LceNM6pArAYOPOedaJZetWg2orA== X-Received: by 2002:a19:8c5e:0:b0:4a2:2d7b:eef with SMTP id i30-20020a198c5e000000b004a22d7b0eefmr11249584lfj.206.1666613769564; Mon, 24 Oct 2022 05:16:09 -0700 (PDT) Received: from uffe-XPS13.. (h-94-254-63-18.NA.cust.bahnhof.se. [94.254.63.18]) by smtp.gmail.com with ESMTPSA id i22-20020a0565123e1600b004acb2adfa21sm165285lfv.297.2022.10.24.05.16.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Oct 2022 05:16:08 -0700 (PDT) From: Ulf Hansson To: Russell King , linux-arm-kernel@lists.infradead.org Cc: Saravana Kannan , Krzysztof Kozlowski , Linus Walleij , linux-kernel@vger.kernel.org, Ulf Hansson Subject: [PATCH] amba: Drop redundant assignments of the system PM callbacks Date: Mon, 24 Oct 2022 14:16:01 +0200 Message-Id: <20221024121601.156514-1-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221024_051613_873330_070970BF X-CRM114-Status: GOOD ( 10.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org If the system PM callbacks haven't been assigned, the PM core falls back to invoke the corresponding the pm_generic_* helpers for the device. Let's rely on this behaviour and drop the redundant assignments. Signed-off-by: Ulf Hansson Acked-by: Linus Walleij --- drivers/amba/bus.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c index 110a535648d2..ff7454a38058 100644 --- a/drivers/amba/bus.c +++ b/drivers/amba/bus.c @@ -421,12 +421,6 @@ static int amba_pm_runtime_resume(struct device *dev) #endif /* CONFIG_PM */ static const struct dev_pm_ops amba_pm = { - .suspend = pm_generic_suspend, - .resume = pm_generic_resume, - .freeze = pm_generic_freeze, - .thaw = pm_generic_thaw, - .poweroff = pm_generic_poweroff, - .restore = pm_generic_restore, SET_RUNTIME_PM_OPS( amba_pm_runtime_suspend, amba_pm_runtime_resume,