| Message ID | 20221024131527.2156810-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | pinctrl: samsung: remove variable pin | expand |
On 24/10/2022 09:15, Colin Ian King wrote: > Variable pin is just being incremented and it's never used > anywhere else. The variable and the increment are redundant so > remove it. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > --- > drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Thanks for the patch. The file is being in process of dropping (patchset is being reviewed), so I think we can skip all the fixes. Best regards, Krzysztof
diff --git a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c index 625cb1065eaf..78b7bd133566 100644 --- a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c +++ b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c @@ -509,7 +509,6 @@ static int s3c24xx_eint_init(struct samsung_pinctrl_drv_data *d) struct s3c24xx_eint_domain_data *ddata; unsigned int mask; unsigned int irq; - unsigned int pin; if (bank->eint_type != EINT_TYPE_WKUP) continue; @@ -534,7 +533,7 @@ static int s3c24xx_eint_init(struct samsung_pinctrl_drv_data *d) irq = bank->eint_offset; mask = bank->eint_mask; - for (pin = 0; mask; ++pin, mask >>= 1) { + for (; mask; mask >>= 1) { if (irq >= NUM_EINT) break; if (!(mask & 1))
Variable pin is just being incremented and it's never used anywhere else. The variable and the increment are redundant so remove it. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)