From patchwork Tue Oct 25 19:13:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 13019778 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02AB3C38A2D for ; Tue, 25 Oct 2022 19:14:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VJnfybYPMubNxM9W39xmVBg8IO5jDo/QASVrpfOsw/4=; b=u1eVrhkyp34Yh5 9FkCoqH/kRRPokw+VMVmMh37FfJRWPjUmdstjB7cAOiX1frxSNy3LPlOX+3MCqukA9Kwt11iZWIZA hBz78Pxg+7jBo4YUXVDklz9dbQvyZnq+Xs2h8F6VUGrbdcv23S5hFRJsLeXOMPTqRGO/omgX7tFZT bRYInaHZEwp6wRd/KHg4B7P3Xk0u6KG7WcMHoWqCVKTa5Rd/0Flvk/buqvh3iZMOFG2jP5P9FDuUx q7hVwrB9GAfjMJMrV5ZBlqVVz7QL/AzesPBYTgpmW2NnsfcoKrwtheWd5iRqdk9A/3p3pfCl/q7IC JC9IZTakxtl8D3CNw7vQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1onPNB-006oov-7S; Tue, 25 Oct 2022 19:14:01 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1onPMz-006oll-DE for linux-arm-kernel@lists.infradead.org; Tue, 25 Oct 2022 19:13:50 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 02E8861B01; Tue, 25 Oct 2022 19:13:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25457C433C1; Tue, 25 Oct 2022 19:13:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666725227; bh=AdyKWW3kGsGFXnVfnmHp1ENXlUnPRsBFMxwcFLjmBrI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Hk/xayVVcKCpHaAzHXbaviYa6so4a/D3kV4UKD/14yg2QgkhwqQf3ZSwDlv7OWxsF pEQD2XT0EKxPtHgbfbjgznJNg5Zs/VwXrHjQnTC+Ntg+6aquFUqES3q0/xu136WYW+ GS0vljuz32rwaBQMR8l0AtbVomECjXfTx9q0DTYzf9sEZPU03P3xuzmkyKo1RLwuhv yoIHjwl8th4X0rnz3v4HlP9SXtu2Avyo3xoLciZl/3D+ZGy1LPzCHJK4XV/SwGIpYC sP1RusB8B8hLxUOqD0d8HCG8FM+GtbKw7SZU69lG/WXtsDy1KcOGKbcLCGjBTAmEa1 XZdx9Q4pyPyCQ== From: Bjorn Helgaas To: Lorenzo Pieralisi Cc: Rob Herring , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Bjorn Helgaas Subject: [PATCH 1/2] PCI: Drop of_match_ptr() to avoid unused variables Date: Tue, 25 Oct 2022 14:13:38 -0500 Message-Id: <20221025191339.667614-2-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221025191339.667614-1-helgaas@kernel.org> References: <20221025191339.667614-1-helgaas@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221025_121349_504514_77DC2E64 X-CRM114-Status: GOOD ( 15.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Bjorn Helgaas We have stubs for most OF interfaces even when CONFIG_OF is not set, so we allow building of most controller drivers in that case for compile testing. When CONFIG_OF is not set, "of_match_ptr()" compiles to NULL, which leaves unused, resulting in errors like this: $ make W=1 drivers/pci/controller/pci-xgene.c:636:34: error: ‘xgene_pcie_match_table’ defined but not used [-Werror=unused-const-variable=] Drop of_match_ptr() to avoid the unused variable warning. See also 1dff012f636d ("PCI: Drop of_match_ptr() to avoid unused variables"). Signed-off-by: Bjorn Helgaas --- drivers/pci/controller/pci-ftpci100.c | 2 +- drivers/pci/controller/pci-v3-semi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/pci-ftpci100.c b/drivers/pci/controller/pci-ftpci100.c index 0cfd9d5a497c..ecd3009df586 100644 --- a/drivers/pci/controller/pci-ftpci100.c +++ b/drivers/pci/controller/pci-ftpci100.c @@ -553,7 +553,7 @@ static const struct of_device_id faraday_pci_of_match[] = { static struct platform_driver faraday_pci_driver = { .driver = { .name = "ftpci100", - .of_match_table = of_match_ptr(faraday_pci_of_match), + .of_match_table = faraday_pci_of_match, .suppress_bind_attrs = true, }, .probe = faraday_pci_probe, diff --git a/drivers/pci/controller/pci-v3-semi.c b/drivers/pci/controller/pci-v3-semi.c index 154a5398633c..d1f9ee4a1ede 100644 --- a/drivers/pci/controller/pci-v3-semi.c +++ b/drivers/pci/controller/pci-v3-semi.c @@ -902,7 +902,7 @@ static const struct of_device_id v3_pci_of_match[] = { static struct platform_driver v3_pci_driver = { .driver = { .name = "pci-v3-semi", - .of_match_table = of_match_ptr(v3_pci_of_match), + .of_match_table = v3_pci_of_match, .suppress_bind_attrs = true, }, .probe = v3_pci_probe,