diff mbox series

arm64: dts: broadcom: bcmbca: bcm4908: drop invalid "nand" interrupt name

Message ID 20221103104152.19502-1-zajec5@gmail.com (mailing list archive)
State New, archived
Headers show
Series arm64: dts: broadcom: bcmbca: bcm4908: drop invalid "nand" interrupt name | expand

Commit Message

Rafał Miłecki Nov. 3, 2022, 10:41 a.m. UTC 
From: Rafał Miłecki <rafal@milecki.pl>

String "nand" was never a valid interrupt name. It was never documented
and never used in Linux or U-Boot driver. This mistake was propagated
from the bcm63138.dtsi.

The whole "interrupt-names" property is optional and can be skipped.

Fixes: 2961f69f151c ("arm64: dts: broadcom: add BCM4908 and Asus GT-AC5300 early DTS files")
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 arch/arm64/boot/dts/broadcom/bcmbca/bcm4908.dtsi | 1 -
 1 file changed, 1 deletion(-)

Comments

Florian Fainelli Nov. 9, 2022, 6:37 p.m. UTC | #1 
On 11/3/22 03:41, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> String "nand" was never a valid interrupt name. It was never documented
> and never used in Linux or U-Boot driver. This mistake was propagated
> from the bcm63138.dtsi.
> 
> The whole "interrupt-names" property is optional and can be skipped.
> 
> Fixes: 2961f69f151c ("arm64: dts: broadcom: add BCM4908 and Asus GT-AC5300 early DTS files")
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

Do you still want me to apply this patch, or are we happy with renaming 
that interrupt to "nand_ctlrdy" instead?
Rafał Miłecki Nov. 9, 2022, 8:11 p.m. UTC | #2 
On 9.11.2022 19:37, Florian Fainelli wrote:
> On 11/3/22 03:41, Rafał Miłecki wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> String "nand" was never a valid interrupt name. It was never documented
>> and never used in Linux or U-Boot driver. This mistake was propagated
>> from the bcm63138.dtsi.
>>
>> The whole "interrupt-names" property is optional and can be skipped.
>>
>> Fixes: 2961f69f151c ("arm64: dts: broadcom: add BCM4908 and Asus GT-AC5300 early DTS files")
>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> 
> Do you still want me to apply this patch, or are we happy with renaming that interrupt to "nand_ctlrdy" instead?

I don't have any real preference.

Since we already have this patch, we may just apply it. If you think
having "interrupt-names" with just "nand_ctlrdy" is cleaner, I can send
V2.
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/broadcom/bcmbca/bcm4908.dtsi b/arch/arm64/boot/dts/broadcom/bcmbca/bcm4908.dtsi
index dac9d3b4e91d..ba1d44e98c32 100644
--- a/arch/arm64/boot/dts/broadcom/bcmbca/bcm4908.dtsi
+++ b/arch/arm64/boot/dts/broadcom/bcmbca/bcm4908.dtsi
@@ -532,7 +532,6 @@  nand-controller@1800 {
 			reg = <0x1800 0x600>, <0x2000 0x10>;
 			reg-names = "nand", "nand-int-base";
 			interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
-			interrupt-names = "nand";
 			status = "okay";
 
 			nandcs: nand@0 {