| Message ID | 20221103181440.232727-3-jpanis@baylibre.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | AM62x watchdog support | expand |
On 19:14-20221103, Julien Panis wrote: > MCU wdt is typically used by M4F. > Wake up wdt is typically used by DM (R5) firmware. > > Signed-off-by: Julien Panis <jpanis@baylibre.com> > --- > arch/arm64/boot/dts/ti/k3-am625-sk.dts | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-am625-sk.dts b/arch/arm64/boot/dts/ti/k3-am625-sk.dts > index 93a5f0817efc..9ade591ef563 100644 > --- a/arch/arm64/boot/dts/ti/k3-am625-sk.dts > +++ b/arch/arm64/boot/dts/ti/k3-am625-sk.dts > @@ -503,6 +503,16 @@ &main_mcan0 { > status = "disabled"; > }; > > +&mcu_rti0 { > + /* MCU RTI0 is used by M4F firmware */ > + status = "reserved"; > +}; > + > +&wkup_rti0 { > + /* WKUP RTI0 is used by DM firmware */ > + status = "reserved"; > +}; > + If this is the typical usage, should'nt we do this in soc.dtsi than sprinkle this through various boards? Andrew: ? > &epwm0 { > status = "disabled"; > }; > -- > 2.37.3 >
On 11/3/22 4:47 PM, Nishanth Menon wrote: > On 19:14-20221103, Julien Panis wrote: >> MCU wdt is typically used by M4F. >> Wake up wdt is typically used by DM (R5) firmware. >> >> Signed-off-by: Julien Panis <jpanis@baylibre.com> >> --- >> arch/arm64/boot/dts/ti/k3-am625-sk.dts | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-am625-sk.dts b/arch/arm64/boot/dts/ti/k3-am625-sk.dts >> index 93a5f0817efc..9ade591ef563 100644 >> --- a/arch/arm64/boot/dts/ti/k3-am625-sk.dts >> +++ b/arch/arm64/boot/dts/ti/k3-am625-sk.dts >> @@ -503,6 +503,16 @@ &main_mcan0 { >> status = "disabled"; >> }; >> >> +&mcu_rti0 { >> + /* MCU RTI0 is used by M4F firmware */ >> + status = "reserved"; >> +}; >> + >> +&wkup_rti0 { >> + /* WKUP RTI0 is used by DM firmware */ >> + status = "reserved"; >> +}; >> + > > If this is the typical usage, should'nt we do this in soc.dtsi than > sprinkle this through various boards? > > Andrew: ? These are only "reserved" for certain firmware, you choose your RPROCs and firmware down at the bottom level in board DTs. So I'd say these statuses should be set at this same level here. DM firmware might be the exception as it should always be present, but for M4F firmware, meh, leave it here. Andrew >> &epwm0 { >> status = "disabled"; >> }; >> -- >> 2.37.3 >> >
On 17:36-20221103, Andrew Davis wrote: > On 11/3/22 4:47 PM, Nishanth Menon wrote: > > On 19:14-20221103, Julien Panis wrote: > > > MCU wdt is typically used by M4F. > > > Wake up wdt is typically used by DM (R5) firmware. > > > > > > Signed-off-by: Julien Panis <jpanis@baylibre.com> > > > --- > > > arch/arm64/boot/dts/ti/k3-am625-sk.dts | 10 ++++++++++ > > > 1 file changed, 10 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/ti/k3-am625-sk.dts b/arch/arm64/boot/dts/ti/k3-am625-sk.dts > > > index 93a5f0817efc..9ade591ef563 100644 > > > --- a/arch/arm64/boot/dts/ti/k3-am625-sk.dts > > > +++ b/arch/arm64/boot/dts/ti/k3-am625-sk.dts > > > @@ -503,6 +503,16 @@ &main_mcan0 { > > > status = "disabled"; > > > }; > > > +&mcu_rti0 { > > > + /* MCU RTI0 is used by M4F firmware */ > > > + status = "reserved"; > > > +}; > > > + > > > +&wkup_rti0 { > > > + /* WKUP RTI0 is used by DM firmware */ > > > + status = "reserved"; > > > +}; > > > + > > > > If this is the typical usage, should'nt we do this in soc.dtsi than > > sprinkle this through various boards? > > > > Andrew: ? > > These are only "reserved" for certain firmware, you choose your RPROCs > and firmware down at the bottom level in board DTs. So I'd say these > statuses should be set at this same level here. > > DM firmware might be the exception as it should always be present, > but for M4F firmware, meh, leave it here. > That makes sense.. Julien: Could you address this please?
diff --git a/arch/arm64/boot/dts/ti/k3-am625-sk.dts b/arch/arm64/boot/dts/ti/k3-am625-sk.dts index 93a5f0817efc..9ade591ef563 100644 --- a/arch/arm64/boot/dts/ti/k3-am625-sk.dts +++ b/arch/arm64/boot/dts/ti/k3-am625-sk.dts @@ -503,6 +503,16 @@ &main_mcan0 { status = "disabled"; }; +&mcu_rti0 { + /* MCU RTI0 is used by M4F firmware */ + status = "reserved"; +}; + +&wkup_rti0 { + /* WKUP RTI0 is used by DM firmware */ + status = "reserved"; +}; + &epwm0 { status = "disabled"; };
MCU wdt is typically used by M4F. Wake up wdt is typically used by DM (R5) firmware. Signed-off-by: Julien Panis <jpanis@baylibre.com> --- arch/arm64/boot/dts/ti/k3-am625-sk.dts | 10 ++++++++++ 1 file changed, 10 insertions(+)