| Message ID | 20221104074527.37353-1-yang.lee@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next,v2] crypto: rockchip: Remove surplus dev_err() when using platform_get_irq() | expand |
Le Fri, Nov 04, 2022 at 03:45:27PM +0800, Yang Li a écrit : > There is no need to call the dev_err() function directly to print a > custom message when handling an error from either the platform_get_irq() > or platform_get_irq_byname() functions as both are going to display an > appropriate error message in case of a failure. > > ./drivers/crypto/rockchip/rk3288_crypto.c:351:2-9: line 351 is > redundant because platform_get_irq() already prints an error > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2677 > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > --- > > change in v2: > --According to Corentin's suggestion, make the subject started by "crypto: rockchip:". > > drivers/crypto/rockchip/rk3288_crypto.c | 1 - > 1 file changed, 1 deletion(-) > Hello Acked-by: Corentin Labbe <clabbe@baylibre.com> Thanks
On Fri, Nov 04, 2022 at 03:45:27PM +0800, Yang Li wrote: > There is no need to call the dev_err() function directly to print a > custom message when handling an error from either the platform_get_irq() > or platform_get_irq_byname() functions as both are going to display an > appropriate error message in case of a failure. > > ./drivers/crypto/rockchip/rk3288_crypto.c:351:2-9: line 351 is > redundant because platform_get_irq() already prints an error > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2677 > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > --- > > change in v2: > --According to Corentin's suggestion, make the subject started by "crypto: rockchip:". > > drivers/crypto/rockchip/rk3288_crypto.c | 1 - > 1 file changed, 1 deletion(-) Patch applied. Thanks.
diff --git a/drivers/crypto/rockchip/rk3288_crypto.c b/drivers/crypto/rockchip/rk3288_crypto.c index 6217e73ba4c4..9f6ba770a90a 100644 --- a/drivers/crypto/rockchip/rk3288_crypto.c +++ b/drivers/crypto/rockchip/rk3288_crypto.c @@ -348,7 +348,6 @@ static int rk_crypto_probe(struct platform_device *pdev) crypto_info->irq = platform_get_irq(pdev, 0); if (crypto_info->irq < 0) { - dev_err(&pdev->dev, "control Interrupt is not available.\n"); err = crypto_info->irq; goto err_crypto; }
There is no need to call the dev_err() function directly to print a custom message when handling an error from either the platform_get_irq() or platform_get_irq_byname() functions as both are going to display an appropriate error message in case of a failure. ./drivers/crypto/rockchip/rk3288_crypto.c:351:2-9: line 351 is redundant because platform_get_irq() already prints an error Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2677 Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- change in v2: --According to Corentin's suggestion, make the subject started by "crypto: rockchip:". drivers/crypto/rockchip/rk3288_crypto.c | 1 - 1 file changed, 1 deletion(-)