diff mbox series

[2/9] pinctrl: stm32: Remove check for pins-are-numbered

Message ID 20221121015451.2471196-3-bero@baylibre.com (mailing list archive)
State New, archived
Headers show
Series Remove the pins-are-numbered DT property | expand

Commit Message

Bernhard Rosenkränzer Nov. 21, 2022, 1:54 a.m. UTC 
Remove the check for the unnecessary pins-are-numbered
DeviceTree property

Signed-off-by: Bernhard Rosenkränzer <bero@baylibre.com>
---
 drivers/pinctrl/stm32/pinctrl-stm32.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Matthias Brugger Nov. 21, 2022, 12:34 p.m. UTC | #1 
On 21/11/2022 02:54, Bernhard Rosenkränzer wrote:
> Remove the check for the unnecessary pins-are-numbered
> DeviceTree property
> 
> Signed-off-by: Bernhard Rosenkränzer <bero@baylibre.com>


Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>


> ---
>   drivers/pinctrl/stm32/pinctrl-stm32.c | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/pinctrl-stm32.c
> index cc9472b284047..1cddca506ad7e 100644
> --- a/drivers/pinctrl/stm32/pinctrl-stm32.c
> +++ b/drivers/pinctrl/stm32/pinctrl-stm32.c
> @@ -1499,11 +1499,6 @@ int stm32_pctl_probe(struct platform_device *pdev)
>   	if (!match_data)
>   		return -EINVAL;
>   
> -	if (!device_property_present(dev, "pins-are-numbered")) {
> -		dev_err(dev, "only support pins-are-numbered format\n");
> -		return -EINVAL;
> -	}
> -
>   	pctl = devm_kzalloc(dev, sizeof(*pctl), GFP_KERNEL);
>   	if (!pctl)
>   		return -ENOMEM;
Krzysztof Kozlowski Nov. 21, 2022, 12:35 p.m. UTC | #2 
On 21/11/2022 02:54, Bernhard Rosenkränzer wrote:
> Remove the check for the unnecessary pins-are-numbered
> DeviceTree property
> 
> Signed-off-by: Bernhard Rosenkränzer <bero@baylibre.com>
> ---

FWIW:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/pinctrl-stm32.c
index cc9472b284047..1cddca506ad7e 100644
--- a/drivers/pinctrl/stm32/pinctrl-stm32.c
+++ b/drivers/pinctrl/stm32/pinctrl-stm32.c
@@ -1499,11 +1499,6 @@  int stm32_pctl_probe(struct platform_device *pdev)
 	if (!match_data)
 		return -EINVAL;
 
-	if (!device_property_present(dev, "pins-are-numbered")) {
-		dev_err(dev, "only support pins-are-numbered format\n");
-		return -EINVAL;
-	}
-
 	pctl = devm_kzalloc(dev, sizeof(*pctl), GFP_KERNEL);
 	if (!pctl)
 		return -ENOMEM;