| Message ID | 20221123014805.1993052-1-cuigaosheng1@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] rtc: st-lpc: Add missing clk_disable_unprepare in st_rtc_probe() | expand |
On Wed, 23 Nov 2022 09:48:05 +0800, Gaosheng Cui wrote: > The clk_disable_unprepare() should be called in the error handling > of clk_get_rate(), fix it. > > Applied, thanks! [1/1] rtc: st-lpc: Add missing clk_disable_unprepare in st_rtc_probe() commit: 5fb733d7bd6949e90028efdce8bd528c6ab7cf1e Best regards,
diff --git a/drivers/rtc/rtc-st-lpc.c b/drivers/rtc/rtc-st-lpc.c index bdb20f63254e..0f8e4231098e 100644 --- a/drivers/rtc/rtc-st-lpc.c +++ b/drivers/rtc/rtc-st-lpc.c @@ -238,6 +238,7 @@ static int st_rtc_probe(struct platform_device *pdev) rtc->clkrate = clk_get_rate(rtc->clk); if (!rtc->clkrate) { + clk_disable_unprepare(rtc->clk); dev_err(&pdev->dev, "Unable to fetch clock rate\n"); return -EINVAL; }
The clk_disable_unprepare() should be called in the error handling of clk_get_rate(), fix it. Fixes: b5b2bdfc2893 ("rtc: st: Add new driver for ST's LPC RTC") Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> --- v2: - Update the commit message, thanks! drivers/rtc/rtc-st-lpc.c | 1 + 1 file changed, 1 insertion(+)