From patchwork Tue Dec 6 17:09:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 13066167 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C77F9C352A1 for ; Tue, 6 Dec 2022 17:10:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Naw428bo7LdWvfSXS8uDk3/13hAZiPjvNmcSiyaNZ2E=; b=vw7YHvngEJ2c59 9wjE6h9j5HU+GD8WLw2uhUM6lvS9ZUMD6lDUdCFjsXNpBpIaiU8p6lJucL8fPx6N6AvAlsHOf23k7 EpKi9VUjudZI7aFTjX2CN/LEHWOpehGrHeLqVLZ2vRrCJiNcLy50sMkKPLGcu+HweuNZX+uHIBm0a +IM3mfYir0biq509A7XhhfAoCLqUDRKcFeiJoWkp7CaYFGtBufcnSQR7LPKrko27B2rAU+77YhnwA wR7UE+CWD6UdOxmoOnpz3pzd/AybVxEEeL3WNRFG5SIk2y/Qn/DCL6JmaCzH/T1JHnpInEhWtg2lA 8uIu6UpnGSpq8APL1xRQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2bRj-00Ffpm-11; Tue, 06 Dec 2022 17:09:31 +0000 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2bRg-00FfoK-Q5 for linux-arm-kernel@lists.infradead.org; Tue, 06 Dec 2022 17:09:30 +0000 Received: by mail-wm1-x329.google.com with SMTP id n7so11671550wms.3 for ; Tue, 06 Dec 2022 09:09:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=MxiX4xJAqzGvUOJG6dGIAYeA5k9jqvSgVNBvDNesWok=; b=FiKrRdnnu/Odmt1R/n1t39q5QwfZ5qIN6HA/spKh8UBYUbEp5m/PwauwlbcWDq1/fg f0iPgJiKeXpm+mpqMGW/CqBsUUeReZBncLjcD0EmMFPEcW0rRDCRI9Tz1gFi6IDwC1Ad L0Is4iHJySgrY9kwT1voN3pvDjihcKoCcYJdg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MxiX4xJAqzGvUOJG6dGIAYeA5k9jqvSgVNBvDNesWok=; b=JPmTgF+pQ6vuw7rU6ONzaRP1g7Y+GZffR/vx3SrqZmqnfF5js21mzX0jGnvxJX+eDt mxMLCjZdBfgs/1zJ9/HdLbZklJxN/jSexjTmz8j5AUOvW/AfI9juYjGKnPdMkMys8Ixw iImYCYWvO0MC7ywkrb5mpSk2kL8lmhJ3pIgyAdRKncBjWsObN2bC5SiZOQjdGTMfzEHD +dLXErI1mOjCdtNUsO1QMejAH+hgOH8Nh3Q9Ws3it31rlKeqwjUGrl5V4+5099A5v1wS CLpLycwttPMnUVm7uz4L1sJOV8V2Vyu8bnJ4XA94JBAUQvdCl5lJ1ZYpSsey0Fop95AB Sv+g== X-Gm-Message-State: ANoB5pn3HFeIbPb+Tc9Jw/Pv9lCaGmXKML3exetIlGpdaKZr30YDLOlu p+ZaEnn7FBu2E45VRpRT50H8SQ== X-Google-Smtp-Source: AA0mqf4DltLaz1pwxrItnzlotskGlZXAARr9Z1Mh1JJ47kLxeld0dwEQidVU2Rzg4oOrUFw3e6jHSQ== X-Received: by 2002:a1c:7715:0:b0:3cf:d18d:3bfe with SMTP id t21-20020a1c7715000000b003cfd18d3bfemr66187328wmi.203.1670346564509; Tue, 06 Dec 2022 09:09:24 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.pdxnet.pdxeng.ch (host-82-54-95-136.retail.telecomitalia.it. [82.54.95.136]) by smtp.gmail.com with ESMTPSA id e4-20020adff344000000b00236488f62d6sm17655402wrp.79.2022.12.06.09.09.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Dec 2022 09:09:24 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Amarula patchwork , Dario Binacchi , Broadcom internal kernel review list , Florian Fainelli , Ray Jui , Russell King , Scott Branden , linux-arm-kernel@lists.infradead.org Subject: [PATCH] ARM: BCM63xx: remove useless goto statement Date: Tue, 6 Dec 2022 18:09:13 +0100 Message-Id: <20221206170913.3316205-1-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221206_090928_892698_D388069F X-CRM114-Status: GOOD ( 11.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Between the 'goto out' statement and the 'out' label there are no other statements, so it is useless to check the return value of the bcm63xx_pmb_power_on_cpu() function. Then, let's remove the statements that are unnecessarily executed. Signed-off-by: Dario Binacchi --- arch/arm/mach-bcm/bcm63xx_smp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/mach-bcm/bcm63xx_smp.c b/arch/arm/mach-bcm/bcm63xx_smp.c index 641e1f8fcf5e..18d0ffc621aa 100644 --- a/arch/arm/mach-bcm/bcm63xx_smp.c +++ b/arch/arm/mach-bcm/bcm63xx_smp.c @@ -142,8 +142,7 @@ static int bcm63138_smp_boot_secondary(unsigned int cpu, */ ret = bcm63xx_pmb_power_on_cpu(dn); of_node_put(dn); - if (ret) - goto out; + out: iounmap(bootlut_base);