From patchwork Thu Dec 29 06:29:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 13083306 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0BA42C4332F for ; Thu, 29 Dec 2022 06:31:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=7LHXJZ4tjwgLwi3UrbuIb7eRIba1UWHNK0z1cmW3+dE=; b=pTqEB6B3ElZpUV Gv4kCB8V8FltcAtPxs6N2Eb+5/iG893Ta+PQ13tOPQYIimOKM43Ta0Ent0sV8z1dD0PNg8BkWDke9 yTJhNqjTWYukHNjo3AGQyZXXgO7NtIYciQJY/qqbaOjKZooOU8QvCJznIuCUAa6I7Iglc4uGTudHa Qojwnkg6unZYHDDq5mNXgONShZKoHGqa1+Qv1/c+H+Lx9Nx0VnICSU5Ftxw914kHgsHfERDW9sDo1 zHOHV9GEMPPg81Rj6qrFmu088kknhxRYEoOic+3zKpYem4dK4PBJ94aFV2HggqxYxeQWlsj4S1kFl lLuatjmXvABb6XChXdOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pAmQF-00CoUv-6T; Thu, 29 Dec 2022 06:29:47 +0000 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pAmQB-00CoQx-4f for linux-arm-kernel@lists.infradead.org; Thu, 29 Dec 2022 06:29:44 +0000 Received: by mail-pj1-x102a.google.com with SMTP id m7-20020a17090a730700b00225ebb9cd01so10150538pjk.3 for ; Wed, 28 Dec 2022 22:29:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Zu4t5YxLIzncFUTu3p6dUmcuMC3ijQM333rUPrcRni4=; b=fsuqFhBPdVqQ1s80bGVmxIXvJEuyhkH3GJHP3GvdiMYDyKPFz7cWsA236aEO19xIIg 4/56mdOPqV7Me3GGHvdtaRN2FRDrarYk5KyKK+rsx9HpJ4YesoJ0HqBU8R8lqtVVI1A5 WOpwF4b3mwpwWBVLD9VkJggoIXD0wzQo+sjuLk9aNvY38WUccSc3uyeofAgRDlelnjFZ kUTM2SfqS2dM/AB4Eq3F1IarU2buHB+ToRLREJajLU+lzh0ELrBPLq/x9DilY5e8Hlmq LhOb+94oxujhlrNiqW20l5oSF7KsNQLDMizDZjakHdSJbBuZeF02Mz2/cfXij5GkwRAl Mi8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Zu4t5YxLIzncFUTu3p6dUmcuMC3ijQM333rUPrcRni4=; b=L3X9ZBkyYcEWAm0KkyKug1eqTqnhBQ0DR9ad2Gtpy4RDe/z1PDFChT/NVWz9iU9XUV U2XjqKxYb+f5fm6tzG+ps35a7j0K+cWKgsBAfTQ3nBtsIyC6GDnKDcppAuplOjgeGgJm G/antQ/qTcJNdKOv1Pja/Ny5gd9rQhLSbKZuckhz2KDArnc2m1gid9FZDZeiP/inUyzr 8vtopF2WhRDb1V3dPvLPsy80o3Zy4NiX87X+Chvw4RhRcqqairhBlHLUVXe67H/syVuv o7PK+ZEuSMPZbjQQwsb8dhebDc5bbSV4/bfKIIhHRnh1Xgvuywy9FBefG6eeUK34PFws mxHw== X-Gm-Message-State: AFqh2krQ1rrs/jjuDCSn7s29SMSk9PqBZvdVWw/VvmZrwBEt9NWcF0KS M9bF2iI3vhPl7fCtQJT6eP0= X-Google-Smtp-Source: AMrXdXv5KtxHW3bDO3U5bYo2QYD+/RfzC2B2UULHY8aCfhPXF6dSCf58WTZv3XbLVMbI5TkgrKJmWA== X-Received: by 2002:a17:90a:de8e:b0:21e:1282:af42 with SMTP id n14-20020a17090ade8e00b0021e1282af42mr30080723pjv.40.1672295380579; Wed, 28 Dec 2022 22:29:40 -0800 (PST) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id j1-20020a17090a3e0100b00218d894fac3sm13104865pjc.3.2022.12.28.22.29.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Dec 2022 22:29:40 -0800 (PST) From: Miaoqian Lin To: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Michal Simek , Florian Fainelli , Brandon Maier , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] net: phy: xgmiitorgmii: Fix refcount leak in xgmiitorgmii_probe Date: Thu, 29 Dec 2022 10:29:25 +0400 Message-Id: <20221229062925.1372931-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221228_222943_258092_664A2498 X-CRM114-Status: GOOD ( 10.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_phy_find_device() return device node with refcount incremented. Call put_device() to relese it when not needed anymore. Fixes: ab4e6ee578e8 ("net: phy: xgmiitorgmii: Check phy_driver ready before accessing") Signed-off-by: Miaoqian Lin --- drivers/net/phy/xilinx_gmii2rgmii.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/phy/xilinx_gmii2rgmii.c b/drivers/net/phy/xilinx_gmii2rgmii.c index 8dcb49ed1f3d..7fd9fe6a602b 100644 --- a/drivers/net/phy/xilinx_gmii2rgmii.c +++ b/drivers/net/phy/xilinx_gmii2rgmii.c @@ -105,6 +105,7 @@ static int xgmiitorgmii_probe(struct mdio_device *mdiodev) if (!priv->phy_dev->drv) { dev_info(dev, "Attached phy not ready\n"); + put_device(&priv->phy_dev->mdio.dev); return -EPROBE_DEFER; }