From patchwork Sat Dec 31 09:58:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 13085997 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 265ABC3DA7A for ; Sat, 31 Dec 2022 10:00:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=mSZ1pZrqeyfyl2FzbIX1wWV9eZ9shTK7vjDBk/9k4gU=; b=kwU8DZ2uPhFfHO JL6CHJSqlWgC2OVCQzQrXNQGYUIwBawqAZvnZktE64Dg8lYgRexQe2d7GilNe2rSETU/EIB/fmn+I P/AmKA6ngaMtbsK1O6D5xKZ33NG7xd1uUPj/CQEAhhu/FYK891hyKHvSAc9QGRFEf0D/io1EHWL6b U1QbBO3b8W+Gq2kobhZ78Vp0ZFHFBjHYYCOqeaZH8SQ2teucSaZMflsKS4kHZOK6hcc6dJtSAhO6g 9Zpw/L4vP8nUY4fUVj7QSiCLIrlQzjMKaP7I88pMzxw2o1IiqnKe+bXukhV1Ci8rx6IeSXYTIHaZY 23hWEwTuHbPXSOcBprlQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pBYdu-003RhR-Va; Sat, 31 Dec 2022 09:59:07 +0000 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pBYdr-003Rdg-7n for linux-arm-kernel@lists.infradead.org; Sat, 31 Dec 2022 09:59:04 +0000 Received: by mail-pf1-x42f.google.com with SMTP id x26so9561559pfq.10 for ; Sat, 31 Dec 2022 01:59:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=c+mH6yo9QDzH3j2h09MnjaYAWpR4f/pKw+YySSE9cdM=; b=fRK/PdfPbHcHarX93IwTpy/Ytq/F07RTxGR6RD/gj/F9Sxo+MKI9gDZ4FA2FOxsRPq VPo4+eZzOMMydHrWh+mBvPP4NY6L9kj0/WMcG/yW10m3NaMKnsyIy7tZ+uNzqFZ8PqkN KzrLBw9BMP8p3fXse0VXng/zXsJ2JSc+nCv3MSShNjrR/Ye4wtm/al5QoRQ85eNZSz+t W7hUDVpUhmQ0VhW7mD+d5uKpxJTKPOWvPo6gFDNK2cWb9kClTn8DHNSD2e5ubcC8OPCi zxtKsaeRe8RCeEUQtrfZJLcgzxNbV3M/rTrhTFtE0OXB2lMrvNPWMfRtXtla1jhObyYF krGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=c+mH6yo9QDzH3j2h09MnjaYAWpR4f/pKw+YySSE9cdM=; b=s5UQkotkA36ucoEULzqw9G3+t+YtOs9h6vLpM6dIEipUOZ+aPyfF0O6E0qpcfUGNkV B3N09JCXSfCyar4nxPtrtvzQGFFLVA3lKD22w5+J0eu200PYViMbWjQvau6jNdl3XCGE hUrRZd0FjwRTivwLaGYaPonpH3UFFlv4WZQR2jldLPxhJ7EUIFyYzFk2mr5art0Ufrui 7hdM3LWlPYgY+w0lw1LvNqfzfCHyheB/9SOMfrgyZ/Bat9Oyy/hGQp9IEZqMRMLKXZNT jkQJ24TPJtU14ziZ94q22ninNXQyaI2w5JqeuACH2oGFYyD47z5CizO+HiUwYwYiqnVZ Tn2A== X-Gm-Message-State: AFqh2kqinYODCNHW9kbKmOGiDC6pK93HcnESIMiSKTq6eFDrPo9Tz0jD w/V4559WnqtC024IrsQpwqE= X-Google-Smtp-Source: AMrXdXur7RrG2roADR6sHAZPDR/bZV5urMU1ARSL4dBcVxSS+Mh4meOvFZJXX6xPGKJv8iacJWcjVg== X-Received: by 2002:aa7:960d:0:b0:56c:3fba:c5ca with SMTP id q13-20020aa7960d000000b0056c3fbac5camr52384277pfg.16.1672480741039; Sat, 31 Dec 2022 01:59:01 -0800 (PST) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id i128-20020a626d86000000b005768b4f2d0dsm15128137pfc.64.2022.12.31.01.58.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Dec 2022 01:59:00 -0800 (PST) From: Miaoqian Lin To: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Xiaolei Wang , Lucas Stach , Miaoqian Lin , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] soc: imx8m: Fix incorrect check for of_clk_get_by_name() Date: Sat, 31 Dec 2022 13:58:48 +0400 Message-Id: <20221231095851.2573710-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221231_015903_319522_09BF3B8F X-CRM114-Status: GOOD ( 11.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_clk_get_by_name() returns error pointers instead of NULL. Use IS_ERR() checks the return value to catch errors. Fixes: 836fb30949d9 ("soc: imx8m: Enable OCOTP clock before reading the register") Signed-off-by: Miaoqian Lin --- drivers/soc/imx/soc-imx8m.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soc/imx/soc-imx8m.c b/drivers/soc/imx/soc-imx8m.c index 28144c699b0c..32ed9dc88e45 100644 --- a/drivers/soc/imx/soc-imx8m.c +++ b/drivers/soc/imx/soc-imx8m.c @@ -66,8 +66,8 @@ static u32 __init imx8mq_soc_revision(void) ocotp_base = of_iomap(np, 0); WARN_ON(!ocotp_base); clk = of_clk_get_by_name(np, NULL); - if (!clk) { - WARN_ON(!clk); + if (IS_ERR(clk)) { + WARN_ON(IS_ERR(clk)); return 0; }