From patchwork Mon Jan 2 08:24:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 13086570 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E407CC4167B for ; Mon, 2 Jan 2023 08:26:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Gv59/cCwvKw6XDfX/dEGlJno6z/Y8eWbJ8g0zo6LQhc=; b=fwzPO3t19dJKFU nKqPNG1KfXtvya6yN0SSvSrPCO349KHe4uaXQ6izq1RMKzrw131a1Wi6xsFYY50IbIlwFwNzceanc kXrfEq9hRNGFZB4xYpzFv4+H+nUcOKIu3RnnJ+bydViEJlw96ncYDHuTd/i4dOi4c2PrIsflWAPQj WZRorvMjBaHrQELBpULFQLmfy92V1Gcyk93WRXislUdm4ytSkInDgTTIeNocOWqJsI81i3Fm0cpXt uTLNUFUN3E4p3xgi8/Pcy44ZVW1q+oHadytpPV3qPffrsdExeC50bNIMPV7v/ILYp/8PeaVPCoY5h 6gr6uzjrwb25ulHTmKfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCG8R-009OZm-5I; Mon, 02 Jan 2023 08:25:31 +0000 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCG8I-009OUW-AL for linux-arm-kernel@lists.infradead.org; Mon, 02 Jan 2023 08:25:27 +0000 Received: by mail-pl1-x633.google.com with SMTP id jn22so28915642plb.13 for ; Mon, 02 Jan 2023 00:25:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=93nJ5Kz+BlIZ58Rw+CqZdrGFJhp2grdsPUR6i1eSHYg=; b=ELMrLaaNHYA60UyumkyNKPmpsHkbWZ1wp0uePUanFKJQMdmeuiPk8xrbSiw9Qv+LWD QpUGYakUN5IK62N8/Zugfgf2L61dVoVqkkp8ThHB8wAIqNZhArKbsOYJN5z0GRuzhLMv MUhhXPtAAppVWP9S9sfHMghKNjcNpXb0zsOV58owX6YhEkudX4UgXdB5EqS10aFMU55A EQFGS8qS7KDxfZY08122Bw6jNZ9mWxl4I8Yo+iTRFCdFuTVTHpZaoRTkzj8vg0ZN+9h/ QyZ7Nc2/Ifub3QekUxhDpyY8OXWu2M/WM88M9z3pFwKMGp5pIfi6KcMX25Qc1CvEAEwN WjJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=93nJ5Kz+BlIZ58Rw+CqZdrGFJhp2grdsPUR6i1eSHYg=; b=JRgoFl5UvzlPg6Qdz1eYMd7RdDjYts4xpWgAQ7y4SHs55MfcdrnFTEuumbyoV/SyKd KR0qCAQ5vuGZHDZvT+C/zgz3+nnITgnLicZtw65WcRFxML80utbTaFeQ4DybZy0UbL2n SRevQdQ+Heiwu8BfaIV6bwewnWrqq2hnT5nn5fK8WHYbAbwjSYQsutj9mk3bDNsTsNcx 8VQ6oUokb0biGtfNC8Sfb47dGD3m5bROo+znL90D7uYZ+2ddibL28y7p+pdTUNwSIzDq rf2JmIU/+yujtMrBN56WZSRva9qXrXMQvXjDgxNLCXq7+xItyrtSWlkbxD8ButUOp/qO Br+A== X-Gm-Message-State: AFqh2kqJHroT2BXaBwydEYTmiOmTPkv94q5+ccO2YwjXK53JnzJEV/SX ysnVmhjINznSNtY/U5dMv+efj067qXc9T1Y6 X-Google-Smtp-Source: AMrXdXubgNR4C0fUl2MCMV1zJ50oUurN2jUlpFmeXREJ9xRDIHh0oonNJ3jsqTuPywljKSGeO8HlYA== X-Received: by 2002:a17:90a:ebc6:b0:226:5900:f2f4 with SMTP id cf6-20020a17090aebc600b002265900f2f4mr8244054pjb.4.1672647913766; Mon, 02 Jan 2023 00:25:13 -0800 (PST) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id lr4-20020a17090b4b8400b001fde655225fsm11431028pjb.2.2023.01.02.00.25.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jan 2023 00:25:13 -0800 (PST) From: Miaoqian Lin To: Linus Walleij , Maxime Coquelin , Alexandre Torgue , Fabien Dessenne , Andy Shevchenko , Marek Vasut , Miaoqian Lin , linux-gpio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] pinctrl: stm32: Fix refcount leak in stm32_pctrl_get_irq_domain Date: Mon, 2 Jan 2023 12:24:56 +0400 Message-Id: <20230102082503.3944927-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230102_002522_455385_26EC616B X-CRM114-Status: GOOD ( 12.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_irq_find_parent() returns a node pointer with refcount incremented, We should use of_node_put() on it when not needed anymore. Add missing of_node_put() to avoid refcount leak. Fixes: d86f4d71e42a ("pinctrl: stm32: check irq controller availability at probe") Signed-off-by: Miaoqian Lin --- drivers/pinctrl/stm32/pinctrl-stm32.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/pinctrl-stm32.c index 1cddca506ad7..cb33a23ab0c1 100644 --- a/drivers/pinctrl/stm32/pinctrl-stm32.c +++ b/drivers/pinctrl/stm32/pinctrl-stm32.c @@ -1382,6 +1382,7 @@ static struct irq_domain *stm32_pctrl_get_irq_domain(struct platform_device *pde return ERR_PTR(-ENXIO); domain = irq_find_host(parent); + of_node_put(parent); if (!domain) /* domain not registered yet */ return ERR_PTR(-EPROBE_DEFER);