Message ID | 20230102085611.3955984-1-linmq006@gmail.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4EC0C4167B for <linux-arm-kernel@archiver.kernel.org>; Mon, 2 Jan 2023 08:57:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=zArtHiNADEF7Zn7gXkjd2PeSfG2yJx0TbcDj0WopwhM=; b=d5z9JhyJXG1/aY F8XyU4sdeboe9Rrio++pzrco/GU7YK8r0axIBimV21JoBB5uEwfKKa7JVbVcTg/XqB6L2/zer4lvG r0Z59c8Fn3i1n4tTbpx7HdZBq7B6eiLZ235fryZjyMvYCNI2EDndpoGSYnvC1Zw2QwrFtayqZjLsZ o9VSVl+T/qqHkh2kM0sFh1GBY8b6VgmtKnLc8jKIz+Ex2hCJBF9jpArhjcwd2nm3AYC9j7eN5BJJW 5FIL2Fy6FVfZvVHn9gJJJzrYu81LJAyp8llBfUijHRG6ZZuTM6ylYGVlPzsxxOOIdJmc6vHwOVRLN y5MOKszycPeumWXDyQTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCGcT-009cu5-Tw; Mon, 02 Jan 2023 08:56:34 +0000 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCGcM-009cqe-Hw for linux-arm-kernel@lists.infradead.org; Mon, 02 Jan 2023 08:56:29 +0000 Received: by mail-pj1-x1030.google.com with SMTP id u4-20020a17090a518400b00223f7eba2c4so27689371pjh.5 for <linux-arm-kernel@lists.infradead.org>; Mon, 02 Jan 2023 00:56:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=RM8oIGfMWpApShjFHib1CmVTv++qNr1Lw9sTv4BtaVA=; b=V9ypSvZ98gXL/PrKDa1RGlnpbLcL1VjaZuZ5Adl/U6mRPQ4gDH1S/hySpgBm2eNPLt Y8f+BIa7gfiuZCQU8vqF/tsBa1WyMMzEleXv6rojrP78BFCKJo7NVQaN8fkxrmWOvPMz KU/HismQqUH8T81DPJdtrJdx0aT7niW5LDGFGLYtwP85uNJ1MaZjmYShozBwoxisis+Z B4os0aIgCF4h7wQp+Wg7dRBrqZm8vCKFGBtGo/YZQ2xJB9mxkSemu95Wn4bx7NGcUPst EA09LTtbDD1IsDYv66gE3lQd49zWqYZ7kh8Q/UQUvjqm1HWcdIBx+NiyYSZyV6RRX75U dkQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RM8oIGfMWpApShjFHib1CmVTv++qNr1Lw9sTv4BtaVA=; b=ECKHzCLksZ/8hxMOZeBTvHVnlzAu5IZS/Bwkhb5JeymIcQI0+GjtTpKT2CdsPPZdEO KsZeIV0Rds5LESynKUMjoZViptXZlmbvIOBVJCctlIecpDR2RRUIg5Z3TFiWzwEoB2db 2zPPVkb8I2mrL6UG4cStppMBSIHndWRr0oyGmv4EC5u1iquaF3f5G2Y8WGeFahchBl1j 8tqDPhQkQVXwWEcCK/XHbLb0Pktk+v54FuRnzBG8CH2dLneI01eXOuqaElVOFDu1EcF3 FjDqeDi4jzSVEcx8fHbDJAZDE8+Yl4U6/RLl49cGFlshkpVzTJArwVnkFFrHzAbv1ugO wzDg== X-Gm-Message-State: AFqh2kpx47By4S6hcWKEWZd7jPrRpt2oDHTfNcTF1C1hIzLvuWF9e9ij 3I+dXRcAU496pmEQmGjCctU= X-Google-Smtp-Source: AMrXdXuFB/vgOIi+voy9S2CaZE9FNISrdfrdKC4DSQrkF9VlXL1hqCx6CpKLUZUe2DGsbSvyTPK2BQ== X-Received: by 2002:a17:90a:bd95:b0:225:a202:5fb5 with SMTP id z21-20020a17090abd9500b00225a2025fb5mr43073574pjr.44.1672649780366; Mon, 02 Jan 2023 00:56:20 -0800 (PST) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id pf18-20020a17090b1d9200b002260b06befbsm9896028pjb.16.2023.01.02.00.56.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jan 2023 00:56:19 -0800 (PST) From: Miaoqian Lin <linmq006@gmail.com> To: Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>, Thomas Gleixner <tglx@linutronix.de>, Marc Zyngier <maz@kernel.org>, Lokesh Vutla <lokeshvutla@ti.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] irqchip/ti-sci: Fix refcount leak in ti_sci_intr_irq_domain_probe Date: Mon, 2 Jan 2023 12:56:10 +0400 Message-Id: <20230102085611.3955984-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230102_005626_909467_EDF6233F X-CRM114-Status: GOOD ( 13.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org |
Series |
irqchip/ti-sci: Fix refcount leak in ti_sci_intr_irq_domain_probe
|
expand
|
diff --git a/drivers/irqchip/irq-ti-sci-intr.c b/drivers/irqchip/irq-ti-sci-intr.c index fe8fad22bcf9..020ddf29efb8 100644 --- a/drivers/irqchip/irq-ti-sci-intr.c +++ b/drivers/irqchip/irq-ti-sci-intr.c @@ -236,6 +236,7 @@ static int ti_sci_intr_irq_domain_probe(struct platform_device *pdev) } parent_domain = irq_find_host(parent_node); + of_node_put(parent_node); if (!parent_domain) { dev_err(dev, "Failed to find IRQ parent domain\n"); return -ENODEV;
of_irq_find_parent() returns a node pointer with refcount incremented, We should use of_node_put() on it when not needed anymore. Add missing of_node_put() to avoid refcount leak. Fixes: cd844b0715ce ("irqchip/ti-sci-intr: Add support for Interrupt Router driver") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- drivers/irqchip/irq-ti-sci-intr.c | 1 + 1 file changed, 1 insertion(+)