From patchwork Mon Jan 2 09:47:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 13086620 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC134C3DA7A for ; Mon, 2 Jan 2023 09:53:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=iX0QcnT2cjaQsFOtp/Wwz49tGTNlnHwfTk2z01Z3PT4=; b=NpK+cF0PJ9b3uJ P4V5Kp84SoAB9d0c0SwaMaav+sYPjsCaTiUU28O6McMZb25OSChAs6myJ06C58fxxAEsVo5+HPJZw DBbMJH2u6EFhu229hdKHtrujPz1Lpav2qzIBnHg6VihPvyk+6Xcwuf0B+HzM4JIpwnhYgsnyvL4fx oNtcvOp6DvnK6d9mRYP4CZ2+F3pSVgHdIN2DojaDVda67XKTq5VI7tMSmP2rAuQ5deaa5n9B7CvDj u6G07R+EaYLx9icEcqBO6qi4xQ/9gjKKAJkZnJ5wcl1/8YJCKeX74QzwSRiGga0+hoAWiPHD/s/yK U8xzyO7tZ7VSkzJNnB4A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCHUV-00A6SP-9m; Mon, 02 Jan 2023 09:52:24 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCHQ3-00A3S5-Dc for linux-arm-kernel@lists.infradead.org; Mon, 02 Jan 2023 09:47:59 +0000 Received: by mail-pl1-x629.google.com with SMTP id jn22so29072057plb.13 for ; Mon, 02 Jan 2023 01:47:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=CBwV2mkPeuz+bYwsA3f6iWrfsv26cm3nPyYFJXVroCI=; b=L1GQsIa5xrmYZGgAyxeLqivX7wIoYwpsiTB1C5osf6lUMQcy4xMYrCh5bGHv23iMUH aYwJG9jkt3q3I/E9VTmUKmhjhcAOFwmjBu8KI8OAs8299HFjYj22ZZoV4GNm2FkfmqY0 eoCEB+pHOmT94kiaEoh6ga7TVlFzcWbSw+VSWFTqh+48i5TG5btjUSmi4KJnQGDImt29 K69yGGsiL2sgyDcwrIO+ifiX42lfgdUmp8xZdUbNACvUWoB66M9WeJibunHS792JBWaV gux2K/UsBvaU7s/8ocP84EvfOO8RPG5OLAaUk6+l9NhVWHCgZ0tibJKPnkEdD0ZCiGmA dkAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CBwV2mkPeuz+bYwsA3f6iWrfsv26cm3nPyYFJXVroCI=; b=SGytocMENoAfY8uDMSKAafv36jy5Ai5j0rGnCzUkjRl1syrKp/GU7ITTAIdaxFa+AL VnKaj8UpM/4YxkVzj/eh/eqErAjc+WkB3HJSD5xdpn/1CN/yBggahBiyF/m8BVB3njqf v/Sacn/bJBKGPAgw5d2LS60S/UYQtszJEb03r5NcPCNJ2o8sX9ehA5cmDvzDXsjv16Vu SpEg+ldK4KSOxQmnLnqC9IwxlkG3lUav5V/4cc2d0jEzsq35Tubj6o3Wcyn1wgX5DiI4 If8twyUWlXQsBQm+07POTLEJsHK67MRbu03cw4BdhDc1bFNjKKkPkIsQrqQh5pt3h9Q5 ODfA== X-Gm-Message-State: AFqh2kq5ne/jkB83kXbyArnTu5wIQqepm/j5Tm5T8vkgknsdvQvqLhcn GKDRUPIxoiRJDQQ6i3o4WGQ= X-Google-Smtp-Source: AMrXdXsyEajZruJ4/pBKSEHe8oH3jDHrxGO82t2KcRi3PuYbBkr7kDSxVYwEXn4mctn/u8h8fQzyrA== X-Received: by 2002:a05:6a20:3b0f:b0:af:e129:cb7 with SMTP id c15-20020a056a203b0f00b000afe1290cb7mr44296616pzh.52.1672652861448; Mon, 02 Jan 2023 01:47:41 -0800 (PST) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id t66-20020a635f45000000b0046feb2754e5sm16607991pgb.28.2023.01.02.01.47.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jan 2023 01:47:40 -0800 (PST) From: Miaoqian Lin To: Linus Walleij , Russell King , Ulf Hansson , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] ARM: ux500: Fix refcount leak in ux500_pm_domains_init Date: Mon, 2 Jan 2023 13:47:33 +0400 Message-Id: <20230102094733.3966825-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230102_014750_929727_B269F2EE X-CRM114-Status: GOOD ( 14.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_irq_find_parent() returns a node pointer with refcount incremented, We should use of_node_put() on it when not needed anymore. Add missing of_node_put() in the error path to avoid refcount leak. Fixes: cd931dcfda5e ("ARM: ux500: Initial support for PM domains") Signed-off-by: Miaoqian Lin Reviewed-by: Ulf Hansson --- arch/arm/mach-ux500/pm_domains.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-ux500/pm_domains.c b/arch/arm/mach-ux500/pm_domains.c index 427b9ac4af6c..01cae91854ca 100644 --- a/arch/arm/mach-ux500/pm_domains.c +++ b/arch/arm/mach-ux500/pm_domains.c @@ -65,8 +65,10 @@ int __init ux500_pm_domains_init(void) return -ENODEV; genpd_data = kzalloc(sizeof(*genpd_data), GFP_KERNEL); - if (!genpd_data) + if (!genpd_data) { + of_node_put(np); return -ENOMEM; + } genpd_data->domains = ux500_pm_domains; genpd_data->num_domains = ARRAY_SIZE(ux500_pm_domains);