From patchwork Fri Jan 6 05:40:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 13090937 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5747AC3DA7A for ; Fri, 6 Jan 2023 05:42:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=UCd+kLESXUgGpC577Lo6/Qt3Vh/tKLjICR/hsb2P0NQ=; b=RoF6mtYkdcNAeT fGD2GHRQz4dyjz9PMtUS+OKbNQ+KRPTVzzG0ReCo/AwGP8/lcxRar8r9MlONXyaP5VNdgq+uRts6O 1abMKv+Z1xf+L3R0qbTtvLHEj0FMFOeuhdhjbpaENoVcSg0QCE1xpgqM2Ipedi5CtFAwf0PyEQbFP lydTHwsSihUYKAex/i8SJMI37/ZP9WfAhlbkklaEbsnQ/j0Zx3O/8nZkaRfnK422CN6S1FfZ4dJAx 4zhQmlWumbBaV2Q1P6Q7HXxIJFCpKaQoRMwnk2ukBOc9T1A6BD+ZQ0/vhyX+RscObipAHkFQcomrC +OhqWXCW3nN51sgJ4Vig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDfTA-001aSW-Qf; Fri, 06 Jan 2023 05:40:45 +0000 Received: from mail-pg1-x531.google.com ([2607:f8b0:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDfT0-001a6C-5S for linux-arm-kernel@lists.infradead.org; Fri, 06 Jan 2023 05:40:35 +0000 Received: by mail-pg1-x531.google.com with SMTP id r18so527314pgr.12 for ; Thu, 05 Jan 2023 21:40:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=cAq/ViZLPRG+IbYXxjYoUcfudX/jAXQF/9Rus0IPRi8=; b=Lq8FEDrl7w73AawfkdR0gzucxPyYA88LoMQ9IKo5nwc1q0IFPeO+RrV7QfVr2J7PcU nKPGFig5ECCU1f7rLNN+fcLqS234b87jLmkLs7nMYwBVPm7z/AJzuKs/npew4GxdNkJH qoMHeDNLB5WX0XsejLBe1jTC7YLeVuodNQS4yqBNeTR5NN9htWbH5vpfu43FpPsCunum UhCQIfy+LGU7ZDkh5ZGTYMMKMi3xfVLrpc/AVEaKjSfaUvx7lpXxYScw7cgo30H5b5ty 4u484EW1raeq8/iY0uaB68T1JTP8a7Jl3IEcxQJVbA8kL5+fPDJ4ixlG0Af8xKEYhLXL qJlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cAq/ViZLPRG+IbYXxjYoUcfudX/jAXQF/9Rus0IPRi8=; b=QozYkg1yih2JGPkxkMkzper/wJ+azmSnD17sEXuoyEfMfDdT3i8ytgodNihlKu7d7I zAklwyFNO/EsidOkBCiiQGSTiZtz5GpDR3Z4whwHSyxDdoJmr7xJLcJ6SzeluK5X7tb5 OerJxALb08vRo4QrI8AgGL2qIIDCdxNwfdOVvZu/OMf5Ts7FKRHxJ3J2ZWMj2H9How/n KVYBdsx2uu8d5H0CZbyClq3C7Cm4pN4ArI6PsGnmpwYmd1khM+zB6l8/FF7WP7e+2nrg 4ApLCBoXbwRfmPLbqOet+eVaMJ01dp9WBcxZbdDgkOXKn6MHfbPOvdzLwEZMkyFuBvUI KZvg== X-Gm-Message-State: AFqh2koBnuZ84g7VkaTQgDbhK0UYeYinJh88nDsy3IKWPmJUxGJk15rl eN64FCnt+P9MdB4yd9gtkAKCLSHnRBw9V9Jh X-Google-Smtp-Source: AMrXdXu+iN/YbjZPjvZY+uZn4uVMnBgw88vBSWEuWRrgyI83KjmTV/uP9eefedbo4Dum7xGtV0Qd4g== X-Received: by 2002:aa7:99cb:0:b0:580:d188:f516 with SMTP id v11-20020aa799cb000000b00580d188f516mr52824129pfi.19.1672983631353; Thu, 05 Jan 2023 21:40:31 -0800 (PST) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id y11-20020aa79e0b000000b0057ef155103asm209763pfq.155.2023.01.05.21.40.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 21:40:30 -0800 (PST) From: Miaoqian Lin To: Nishanth Menon , Santosh Shilimkar , Keerthy , Dave Gerlach , Tony Lindgren , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: linmq006@gmail.com Subject: [PATCH] soc: ti: pm33xx: Fix refcount leak in am33xx_pm_probe Date: Fri, 6 Jan 2023 09:40:22 +0400 Message-Id: <20230106054022.947529-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230105_214034_269668_CF000C01 X-CRM114-Status: GOOD ( 12.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org wkup_m3_ipc_get() takes refcount, which should be freed by wkup_m3_ipc_put(). Add missing refcount release in the error paths. Fixes: 5a99ae0092fe ("soc: ti: pm33xx: AM437X: Add rtc_only with ddr in self-refresh support") Signed-off-by: Miaoqian Lin --- drivers/soc/ti/pm33xx.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/soc/ti/pm33xx.c b/drivers/soc/ti/pm33xx.c index ce09c42eaed2..f04c21157904 100644 --- a/drivers/soc/ti/pm33xx.c +++ b/drivers/soc/ti/pm33xx.c @@ -527,7 +527,7 @@ static int am33xx_pm_probe(struct platform_device *pdev) ret = am33xx_pm_alloc_sram(); if (ret) - return ret; + goto err_wkup_m3_ipc_put; ret = am33xx_pm_rtc_setup(); if (ret) @@ -572,13 +572,14 @@ static int am33xx_pm_probe(struct platform_device *pdev) pm_runtime_put_sync(dev); err_pm_runtime_disable: pm_runtime_disable(dev); - wkup_m3_ipc_put(m3_ipc); err_unsetup_rtc: iounmap(rtc_base_virt); clk_put(rtc_fck); err_free_sram: am33xx_pm_free_sram(); pm33xx_dev = NULL; +err_wkup_m3_ipc_put: + wkup_m3_ipc_put(m3_ipc); return ret; }