| Message ID | 20230113-syscon-child-mfd-v1-1-0dd31b7de373@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Support Child MFD Cells for the i.MX6QDL Reset Controller | expand |
On 13/01/2023 18:32, Bastian Krause wrote: > This allows passing the reboot mode from the OS to the bootloader via the > syscon-reboot-mode binding. Add a "simple-mfd" to support probing such a > child node. The actual reboot mode node could then be defined in a > board device-tree or fixed up by the bootloader. > > Suggested-by: Ahmad Fatoum <a.fatoum@pengutronix.de> > Signed-off-by: Bastian Krause <bst@pengutronix.de> > --- > Documentation/devicetree/bindings/reset/fsl,imx-src.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml b/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml > index b11ac533f914c..9ec734e14e9f5 100644 > --- a/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml > +++ b/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml > @@ -38,6 +38,8 @@ properties: > - items: > - const: "fsl,imx6q-src" > - const: "fsl,imx51-src" > + - const: "syscon" > + - const: "simple-mfd" 1. Why only this variant can be used as suscon-reboot-mode and not others? 2. Drop quotes. In a follow up patch you can also remove quotes from other compatibles. Best regards, Krzysztof
On 13/01/2023 18:32, Bastian Krause wrote: > This allows passing the reboot mode from the OS to the bootloader via the > syscon-reboot-mode binding. Add a "simple-mfd" to support probing such a > child node. The actual reboot mode node could then be defined in a > board device-tree or fixed up by the bootloader. > > Suggested-by: Ahmad Fatoum <a.fatoum@pengutronix.de> > Signed-off-by: Bastian Krause <bst@pengutronix.de> > --- > Documentation/devicetree/bindings/reset/fsl,imx-src.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml b/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml > index b11ac533f914c..9ec734e14e9f5 100644 > --- a/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml > +++ b/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml > @@ -38,6 +38,8 @@ properties: > - items: > - const: "fsl,imx6q-src" > - const: "fsl,imx51-src" > + - const: "syscon" > + - const: "simple-mfd" This is not sufficient. You can easily check it by yourself - add syscon-reboot-mode node and run dtbs_check. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml b/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml index b11ac533f914c..9ec734e14e9f5 100644 --- a/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml +++ b/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml @@ -38,6 +38,8 @@ properties: - items: - const: "fsl,imx6q-src" - const: "fsl,imx51-src" + - const: "syscon" + - const: "simple-mfd" - items: - const: "fsl,imx6sx-src" - const: "fsl,imx51-src"
This allows passing the reboot mode from the OS to the bootloader via the syscon-reboot-mode binding. Add a "simple-mfd" to support probing such a child node. The actual reboot mode node could then be defined in a board device-tree or fixed up by the bootloader. Suggested-by: Ahmad Fatoum <a.fatoum@pengutronix.de> Signed-off-by: Bastian Krause <bst@pengutronix.de> --- Documentation/devicetree/bindings/reset/fsl,imx-src.yaml | 2 ++ 1 file changed, 2 insertions(+)