diff mbox series

ARM: dts: imx7d-smegw01: Fix USB host over-current polarity

Message ID 20230117112510.109123-1-festevam@denx.de (mailing list archive)
State New, archived
Headers show
Series ARM: dts: imx7d-smegw01: Fix USB host over-current polarity | expand

Commit Message

Fabio Estevam Jan. 17, 2023, 11:25 a.m. UTC
Currently, when resetting the USB modem via AT commands, the modem is
no longer re-connected.

This problem is caused by the incorrect description of the USB_OTG2_OC
pad. It should have pull-up enabled, hysteresis enabled and the
property 'over-current-active-low' should be passed.

With this change, the USB modem can be successfully re-connected
after a reset.

Cc: stable@vger.kernel.org
Fixes: 9ac0ae97e349 ("ARM: dts: imx7d-smegw01: Add support for i.MX7D SMEGW01 board")
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm/boot/dts/imx7d-smegw01.dts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Shawn Guo Jan. 26, 2023, 7:38 a.m. UTC | #1
On Tue, Jan 17, 2023 at 08:25:10AM -0300, Fabio Estevam wrote:
> Currently, when resetting the USB modem via AT commands, the modem is
> no longer re-connected.
> 
> This problem is caused by the incorrect description of the USB_OTG2_OC
> pad. It should have pull-up enabled, hysteresis enabled and the
> property 'over-current-active-low' should be passed.
> 
> With this change, the USB modem can be successfully re-connected
> after a reset.
> 
> Cc: stable@vger.kernel.org
> Fixes: 9ac0ae97e349 ("ARM: dts: imx7d-smegw01: Add support for i.MX7D SMEGW01 board")
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied, thanks!
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/imx7d-smegw01.dts b/arch/arm/boot/dts/imx7d-smegw01.dts
index 546268b8d0b1..c0f00f5db11e 100644
--- a/arch/arm/boot/dts/imx7d-smegw01.dts
+++ b/arch/arm/boot/dts/imx7d-smegw01.dts
@@ -198,6 +198,7 @@  &usbotg1 {
 &usbotg2 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_usbotg2>;
+	over-current-active-low;
 	dr_mode = "host";
 	status = "okay";
 };
@@ -374,7 +375,7 @@  MX7D_PAD_LPSR_GPIO1_IO05__GPIO1_IO5	0x04
 
 	pinctrl_usbotg2: usbotg2grp {
 		fsl,pins = <
-			MX7D_PAD_UART3_RTS_B__USB_OTG2_OC	0x04
+			MX7D_PAD_UART3_RTS_B__USB_OTG2_OC	0x5c
 		>;
 	};