| Message ID | 20230118072656.18845-14-marcel@ziswiler.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: freescale: prepare and add apalis imx8 support | expand |
On 18/01/2023 08:26, Marcel Ziswiler wrote: > From: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > Add Apalis BKL1_PWM functionality. > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > --- > > Changes in v4: > - New patch adding Apalis BKL1_PWM functionality. > > arch/arm64/boot/dts/freescale/imx8-apalis-eval.dtsi | 7 ++++++- > .../arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi | 7 ++++++- > .../arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi | 7 ++++++- > arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi | 9 +++++++-- > 4 files changed, 25 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-eval.dtsi b/arch/arm64/boot/dts/freescale/imx8-apalis-eval.dtsi > index 060454f25c98..003bc5377ce7 100644 > --- a/arch/arm64/boot/dts/freescale/imx8-apalis-eval.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8-apalis-eval.dtsi > @@ -106,7 +106,12 @@ &lsio_pwm3 { > > /* TODO: Apalis PCIE1 */ > > -/* TODO: Apalis BKL1_PWM */ > +/* Apalis BKL1_PWM */ > +&pwm_lvds1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_pwm_bkl>; > + status = "okay"; You just added this file with that comment. This does not make sense. The same patchset adding a line and them immediately changing it. It means previous patch is incomplete or buggy. This must be squashed. Best regards, Krzysztof
On Wed, 2023-01-18 at 15:00 +0100, Krzysztof Kozlowski wrote: > On 18/01/2023 08:26, Marcel Ziswiler wrote: > > From: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > > > Add Apalis BKL1_PWM functionality. > > > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > --- > > > > Changes in v4: > > - New patch adding Apalis BKL1_PWM functionality. > > > > arch/arm64/boot/dts/freescale/imx8-apalis-eval.dtsi | 7 ++++++- > > .../arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi | 7 ++++++- > > .../arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi | 7 ++++++- > > arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi | 9 +++++++-- > > 4 files changed, 25 insertions(+), 5 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-eval.dtsi b/arch/arm64/boot/dts/freescale/imx8- > > apalis-eval.dtsi > > index 060454f25c98..003bc5377ce7 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8-apalis-eval.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8-apalis-eval.dtsi > > @@ -106,7 +106,12 @@ &lsio_pwm3 { > > > > /* TODO: Apalis PCIE1 */ > > > > -/* TODO: Apalis BKL1_PWM */ > > +/* Apalis BKL1_PWM */ > > +&pwm_lvds1 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_pwm_bkl>; > > + status = "okay"; > > You just added this file with that comment. This does not make sense. > The same patchset adding a line and them immediately changing it. It > means previous patch is incomplete or buggy. This must be squashed. Ditto. > Best regards, > Krzysztof
diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-eval.dtsi b/arch/arm64/boot/dts/freescale/imx8-apalis-eval.dtsi index 060454f25c98..003bc5377ce7 100644 --- a/arch/arm64/boot/dts/freescale/imx8-apalis-eval.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8-apalis-eval.dtsi @@ -106,7 +106,12 @@ &lsio_pwm3 { /* TODO: Apalis PCIE1 */ -/* TODO: Apalis BKL1_PWM */ +/* Apalis BKL1_PWM */ +&pwm_lvds1 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_pwm_bkl>; + status = "okay"; +}; /* TODO: Apalis DAP1 */ diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi b/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi index caaafc9900a6..97a7db1f875b 100644 --- a/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi @@ -182,7 +182,12 @@ &lsio_pwm3 { /* TODO: Apalis PCIE1 */ -/* TODO: Apalis BKL1_PWM */ +/* Apalis BKL1_PWM */ +&pwm_lvds1 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_pwm_bkl>; + status = "okay"; +}; /* TODO: Apalis DAP1 */ diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi b/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi index 5bc55a58db97..4186c6c9d5ec 100644 --- a/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi @@ -227,7 +227,12 @@ &lsio_pwm3 { /* TODO: Apalis PCIE1 */ -/* TODO: Apalis BKL1_PWM */ +/* Apalis BKL1_PWM */ +&pwm_lvds1 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_pwm_bkl>; + status = "okay"; +}; /* TODO: Apalis DAP1 */ diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi b/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi index 4c88678e2bc7..5508f0daf579 100644 --- a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi @@ -18,7 +18,7 @@ backlight: backlight { enable-gpios = <&lsio_gpio1 4 GPIO_ACTIVE_HIGH>; /* Apalis BKL1_ON */ pinctrl-names = "default"; pinctrl-0 = <&pinctrl_gpio_bkl_on>; - /* TODO: hook-up to Apalis BKL1_PWM */ + pwms = <&pwm_lvds1 0 6666667 PWM_POLARITY_INVERTED>; status = "disabled"; }; @@ -678,7 +678,12 @@ &lsio_pwm3 { /* TODO: On-module Wi-Fi */ -/* TODO: Apalis BKL1_PWM */ +/* Apalis BKL1_PWM */ +&pwm_lvds1 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_pwm_bkl>; + #pwm-cells = <3>; +}; /* TODO: Apalis DAP1 */