diff mbox series

[v8,01/10] arm64: defconfig: enable MT6357 regulator

Message ID 20230203-evk-board-support-v8-1-7019f3fd0adf@baylibre.com (mailing list archive)
State New, archived
Headers show
Series Improve the MT8365 SoC and EVK board support | expand

Commit Message

Alexandre Mergnat May 25, 2023, 8:33 a.m. UTC 
Enable the power regulator support of MediaTek MT6357 PMIC. This driver
supports the control of different power rails of device through
regulator interface.

Tested-by: Kevin Hilman <khilman@baylibre.com>
Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski May 30, 2023, 1:28 p.m. UTC | #1 
On 25/05/2023 10:33, Alexandre Mergnat wrote:
> Enable the power regulator support of MediaTek MT6357 PMIC. This driver
> supports the control of different power rails of device through
> regulator interface.
> 

It's nice to say which boards/SoCs use it which would justify why we
want it in defconfig.

Your last sentence brings no new information - it's kind of obvious for
every PMIC. Instead of redundant information add something actually
missing - why do we need it in defconfig, IOW, what platform needs it?

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index a24609e14d50..ed3fca298314 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -708,6 +708,7 @@  CONFIG_REGULATOR_MAX77620=y
 CONFIG_REGULATOR_MAX8973=y
 CONFIG_REGULATOR_MP8859=y
 CONFIG_REGULATOR_MT6315=m
+CONFIG_REGULATOR_MT6357=y
 CONFIG_REGULATOR_MT6358=y
 CONFIG_REGULATOR_MT6359=y
 CONFIG_REGULATOR_MT6360=y