diff mbox series

[v2] drm/meson/meson_venc: Relax the supported mode checks

Message ID 20230210-relax_dmt_limits-v2-1-318913f08121@baylibre.com (mailing list archive)
State New, archived
Headers show
Series [v2] drm/meson/meson_venc: Relax the supported mode checks | expand

Commit Message

Carlo Caione Feb. 13, 2023, 9:32 a.m. UTC 
Relax a bit the supported modes list by including also 480x1920 and
400x1280. This was actually tested on real hardware and it works
correctly.

Signed-off-by: Carlo Caione <ccaione@baylibre.com>
---
In particular relax the resolution checks to allow more resolutions like
480x1920 and 400x1280.
---
Changes in v2:
- Lower the hdisplay limit to support 400x1280 as well.
- Link to v1: https://lore.kernel.org/r/20230210-relax_dmt_limits-v1-0-a1474624d530@baylibre.com
---
 drivers/gpu/drm/meson/meson_venc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


---
base-commit: 38c1e0c65865426676123cc9a127526fa02bcac6
change-id: 20230210-relax_dmt_limits-355e2a1c7ccf

Best regards,

Comments

Neil Armstrong Feb. 17, 2023, 10:20 a.m. UTC | #1 
On 13/02/2023 10:32, Carlo Caione wrote:
> Relax a bit the supported modes list by including also 480x1920 and
> 400x1280. This was actually tested on real hardware and it works
> correctly.
> 
> Signed-off-by: Carlo Caione <ccaione@baylibre.com>
> ---
> In particular relax the resolution checks to allow more resolutions like
> 480x1920 and 400x1280.
> ---
> Changes in v2:
> - Lower the hdisplay limit to support 400x1280 as well.
> - Link to v1: https://lore.kernel.org/r/20230210-relax_dmt_limits-v1-0-a1474624d530@baylibre.com
> ---
>   drivers/gpu/drm/meson/meson_venc.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/meson/meson_venc.c b/drivers/gpu/drm/meson/meson_venc.c
> index 3c55ed003359..fcd532db19c1 100644
> --- a/drivers/gpu/drm/meson/meson_venc.c
> +++ b/drivers/gpu/drm/meson/meson_venc.c
> @@ -866,10 +866,10 @@ meson_venc_hdmi_supported_mode(const struct drm_display_mode *mode)
>   			    DRM_MODE_FLAG_PVSYNC | DRM_MODE_FLAG_NVSYNC))
>   		return MODE_BAD;
>   
> -	if (mode->hdisplay < 640 || mode->hdisplay > 1920)
> +	if (mode->hdisplay < 400 || mode->hdisplay > 1920)
>   		return MODE_BAD_HVALUE;
>   
> -	if (mode->vdisplay < 480 || mode->vdisplay > 1200)
> +	if (mode->vdisplay < 480 || mode->vdisplay > 1920)
>   		return MODE_BAD_VVALUE;
>   
>   	return MODE_OK;
> 
> ---
> base-commit: 38c1e0c65865426676123cc9a127526fa02bcac6
> change-id: 20230210-relax_dmt_limits-355e2a1c7ccf
> 
> Best regards,

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Neil Armstrong March 6, 2023, 8:45 a.m. UTC | #2 
Hi,

On Mon, 13 Feb 2023 10:32:09 +0100, Carlo Caione wrote:
> Relax a bit the supported modes list by including also 480x1920 and
> 400x1280. This was actually tested on real hardware and it works
> correctly.
> 
> 

Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next-fixes)

[1/1] drm/meson/meson_venc: Relax the supported mode checks
      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=bf458e5b139894234444e4f88500616a8398b719
diff mbox series

Patch

diff --git a/drivers/gpu/drm/meson/meson_venc.c b/drivers/gpu/drm/meson/meson_venc.c
index 3c55ed003359..fcd532db19c1 100644
--- a/drivers/gpu/drm/meson/meson_venc.c
+++ b/drivers/gpu/drm/meson/meson_venc.c
@@ -866,10 +866,10 @@  meson_venc_hdmi_supported_mode(const struct drm_display_mode *mode)
 			    DRM_MODE_FLAG_PVSYNC | DRM_MODE_FLAG_NVSYNC))
 		return MODE_BAD;
 
-	if (mode->hdisplay < 640 || mode->hdisplay > 1920)
+	if (mode->hdisplay < 400 || mode->hdisplay > 1920)
 		return MODE_BAD_HVALUE;
 
-	if (mode->vdisplay < 480 || mode->vdisplay > 1200)
+	if (mode->vdisplay < 480 || mode->vdisplay > 1920)
 		return MODE_BAD_VVALUE;
 
 	return MODE_OK;