| Message ID | 20230213101633.2085161-1-ryan.roberts@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1] arm64: defconfig: Enable Virtio RNG driver as built in | expand |
Hi Catalin, Will, all, Just a polite nudge: Is there any reason it would be problematic to merge this? Thanks, Ryan On 13/02/2023 10:16, Ryan Roberts wrote: > Modern versions of FVP_Base_RevC-2xAEMvA contain a Virtio RNG device, > use of which can dramatically speed up the time taken for Linux to > initialize its CRNG, from 10s of seconds in some cases, to instant. This > improves the debug cycle significantly. > > However, there are 2 barriers to getting people to use it. The first is > that the defconfig doesn't have the required driver. The second is that > the device is disabled in the device tree (for back-compat since older > versions of the FVP don't have the device). Here we solve the first > issue. > > Signed-off-by: Ryan Roberts <ryan.roberts@arm.com> > --- > arch/arm64/configs/defconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index 851e8f9be06d..e2dad45e87a7 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -464,6 +464,8 @@ CONFIG_VIRTIO_CONSOLE=y > CONFIG_IPMI_HANDLER=m > CONFIG_IPMI_DEVICE_INTERFACE=m > CONFIG_IPMI_SI=m > +CONFIG_HW_RANDOM=y > +CONFIG_HW_RANDOM_VIRTIO=y > CONFIG_TCG_TPM=y > CONFIG_TCG_TIS=m > CONFIG_TCG_TIS_SPI=m > -- > 2.25.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >
On Thu, Mar 23, 2023 at 12:51:17PM +0000, Ryan Roberts wrote:
> Just a polite nudge: Is there any reason it would be problematic to merge this?
No problems with the patch. It probably fell through the cracks. Will
and I normally leave the defconfig patches to Arnd but I guess it was
also posted fairly close to the merging window when most of maintainer
trees had already been frozen.
On Thu, Mar 23, 2023, at 18:37, Catalin Marinas wrote: > On Thu, Mar 23, 2023 at 12:51:17PM +0000, Ryan Roberts wrote: >> Just a polite nudge: Is there any reason it would be problematic to merge this? > > No problems with the patch. It probably fell through the cracks. Will > and I normally leave the defconfig patches to Arnd but I guess it was > also posted fairly close to the merging window when most of maintainer > trees had already been frozen. I've applied it to the soc/defconfig branch for 6.4 now, sorry for missing it before. Arnd
On 24/03/2023 17:49, Arnd Bergmann wrote: > On Thu, Mar 23, 2023, at 18:37, Catalin Marinas wrote: >> On Thu, Mar 23, 2023 at 12:51:17PM +0000, Ryan Roberts wrote: >>> Just a polite nudge: Is there any reason it would be problematic to merge this? >> >> No problems with the patch. It probably fell through the cracks. Will >> and I normally leave the defconfig patches to Arnd but I guess it was >> also posted fairly close to the merging window when most of maintainer >> trees had already been frozen. > > I've applied it to the soc/defconfig branch for 6.4 now, sorry > for missing it before. No problem - thanks! > > Arnd
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 851e8f9be06d..e2dad45e87a7 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -464,6 +464,8 @@ CONFIG_VIRTIO_CONSOLE=y CONFIG_IPMI_HANDLER=m CONFIG_IPMI_DEVICE_INTERFACE=m CONFIG_IPMI_SI=m +CONFIG_HW_RANDOM=y +CONFIG_HW_RANDOM_VIRTIO=y CONFIG_TCG_TPM=y CONFIG_TCG_TIS=m CONFIG_TCG_TIS_SPI=m
Modern versions of FVP_Base_RevC-2xAEMvA contain a Virtio RNG device, use of which can dramatically speed up the time taken for Linux to initialize its CRNG, from 10s of seconds in some cases, to instant. This improves the debug cycle significantly. However, there are 2 barriers to getting people to use it. The first is that the defconfig doesn't have the required driver. The second is that the device is disabled in the device tree (for back-compat since older versions of the FVP don't have the device). Here we solve the first issue. Signed-off-by: Ryan Roberts <ryan.roberts@arm.com> --- arch/arm64/configs/defconfig | 2 ++ 1 file changed, 2 insertions(+) -- 2.25.1