From patchwork Fri Feb 24 06:49:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Asahi Lina X-Patchwork-Id: 13150979 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6352C677F1 for ; Fri, 24 Feb 2023 06:51:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Message-Id:MIME-Version:Subject: Date:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=hNNJhZiLOyspprkl5+D/QFITbA/UeVJPk9NJUwdJUmY=; b=cLg3HzSNNz/DPd x5wKzFBaoTBgbcP3qSNmJm5bjwn7sEucuJ3Sp2KdDVlWF8CAn2JfeXSRe+bNyNprVFYlKDnwYb92b E4iZ2rmYXrS6V8KusX9D5pTH3WDvmXgeeeuVNKrpj+jVrFUD5Lc3EpUrt7y4tVcr6YvKqWJa3wD4Y 9izQPgnaP3jZYalXRs3oREzZFSaGzo5U24k46yYJD+ceITcTRWdF0B5usBNgkt8QoXrEDqZ5KhZ3W su241MvDKvd7jwJT8aUyaTIYDIbNK39PnXzrlo1unmiX268m0puvaVo3oQjpdNoriANkCGCEgtMUs sFHh1eHWeBkh4sptreMg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pVRuD-001MOO-Hj; Fri, 24 Feb 2023 06:50:09 +0000 Received: from marcansoft.com ([212.63.210.85] helo=mail.marcansoft.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pVRu9-001MMy-Pl for linux-arm-kernel@lists.infradead.org; Fri, 24 Feb 2023 06:50:07 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: linasend@asahilina.net) by mail.marcansoft.com (Postfix) with ESMTPSA id DDC724206F; Fri, 24 Feb 2023 06:49:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=asahilina.net; s=default; t=1677221398; bh=XEjX9AY/rxbyfPg1iE4VKDJGbOP+C/8aCuR0EDho4L0=; h=From:Date:Subject:To:Cc; b=RJNC2gX2MTkdFFrlC2XQ1+QOCIDwewtCU9rFAbNyqdbstuuKPcoGknHHgmWYl3JXT ffqH7j6PQz7v8fh0QNQS5odDEY+5+SfD71x5uba9eldJvea0aOhZPs9SwcktTGMOxh vM/wIgPK/23P4cGgWTS1wFSLG3/RHpvynTYQ3rK8kfS0EnbObYpKi0rOgqS3FDCzcB faLlt8QSxD+AZO+EfCkkjDNNYFU2UepDqpioFa1b563VtB5k3bLj1eMDGmtGqiKVUt laV1oK4GHQTxci+yRHsfsZwlVUyc67A2CNYb6Gx83CAv2zjRh2NwNKW08YBBQgjkVR nH/QMAotQYoGA== From: Asahi Lina Date: Fri, 24 Feb 2023 15:49:44 +0900 Subject: [PATCH] soc: apple: rtkit: Fix buffer address field width MIME-Version: 1.0 Message-Id: <20230224-gpu-up-rtkit-v1-1-671178cb2a5e@asahilina.net> X-B4-Tracking: v=1; b=H4sIAAde+GMC/x2NwQrCMBBEf6Xs2cU2Fgz+inhI4rZdhBh2k1II/ XcTj29mHlNBSZgUHkMFoZ2Vv7HBdBkgbC6uhPxuDGY0t9GYGddUsCSU/OGMy+zDZOlug3XQFO+ U0IuLYetS216laMae9z4JLXz8756v8/wBgXTYKH4AAAA= To: Hector Martin , Sven Peter , Alyssa Rosenzweig Cc: asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Asahi Lina X-Mailer: b4 0.12.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1677221396; l=994; i=lina@asahilina.net; s=20230221; h=from:subject:message-id; bh=XEjX9AY/rxbyfPg1iE4VKDJGbOP+C/8aCuR0EDho4L0=; b=2cGAkzXmm2kGa9fJLiypOR7qW7WO91eNDpFnITNoCLa72VF/iKWxb6QTZ6LDnRDpYw6LVm5hx +zxE9TPOBR0DEpl2fCyeB4hC+F6L8aBXAygukJSxy5swsiuQeGdX9qh X-Developer-Key: i=lina@asahilina.net; a=ed25519; pk=Qn8jZuOtR1m5GaiDfTrAoQ4NE1XoYVZ/wmt5YtXWFC4= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230223_225006_252877_1BD081B8 X-CRM114-Status: UNSURE ( 8.44 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The buffer address field is missing two bits. This matters for the GPU, which uses upper-half 64-bit addresses on the ASC and those get sign extended from the mailbox message field, so the right number of high bits need to be set. Signed-off-by: Asahi Lina Reviewed-by: Sven Peter --- drivers/soc/apple/rtkit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 83f978b63fa7ad474ca22d7e2772c5988101c9bd change-id: 20230224-gpu-up-rtkit-f4bc18e78c8a Thank you, ~~ Lina diff --git a/drivers/soc/apple/rtkit.c b/drivers/soc/apple/rtkit.c index 35ec35aa500d..a02a44a745f6 100644 --- a/drivers/soc/apple/rtkit.c +++ b/drivers/soc/apple/rtkit.c @@ -55,7 +55,7 @@ enum { #define APPLE_RTKIT_BUFFER_REQUEST 1 #define APPLE_RTKIT_BUFFER_REQUEST_SIZE GENMASK_ULL(51, 44) -#define APPLE_RTKIT_BUFFER_REQUEST_IOVA GENMASK_ULL(41, 0) +#define APPLE_RTKIT_BUFFER_REQUEST_IOVA GENMASK_ULL(43, 0) #define APPLE_RTKIT_SYSLOG_TYPE GENMASK_ULL(59, 52)